[webkit-changes] cvs commit: WebCore/khtml/rendering render_block.cpp render_container.cpp

[Maciej]

mjs         05/08/30 22:09:03

  Modified:    .        ChangeLog
               khtml/rendering render_block.cpp render_container.cpp
  Log:
          Reviewed by Vicki
  
  	<rdar://problem/4231978> many leaks of StyleSurroundData called beneath RenderStyle::setMarginTop, seen running webkit tests
  	<rdar://problem/4232017> many leaks of StyleInheritedData called from different RenderStyle methods, seen running webkit tests
  	<rdar://problem/4232175> leak of RenderObject called from RenderContainer::updatePseudoChild, seen running webkit tests
  	<rdar://problem/4232214> many leaks of RenderStyle from CSSStyleSelector::pseudoStyleForElement, seen running webkit tests
  	<rdar://problem/4232252> many leaks of RenderStyle called beneath NodeImpl::createRendererIfNeeded, seen running webkit tests
  	<rdar://problem/4232263> many leaks of RenderObject called from TextImpl::createRenderer, seen running webkit tests
  	<rdar://problem/4233690> leaks of StyleBackgroundData called within setBackgroundColor, seen running webkit tests
  
          Test cases added: None, these leaks were already caught by the layout tests.
  
          * khtml/rendering/render_block.cpp:
          (khtml::RenderBlock::updateFirstLetter):
          * khtml/rendering/render_container.cpp:
          (RenderContainer::updatePseudoChild):
  
  Revision  Changes    Path
  1.48      +19 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.47
  retrieving revision 1.48
  diff -u -r1.47 -r1.48
  --- ChangeLog	31 Aug 2005 04:55:10 -0000	1.47
  +++ ChangeLog	31 Aug 2005 05:09:02 -0000	1.48
  @@ -1,3 +1,22 @@
  +2005-08-30  Maciej Stachowiak  <mjs at apple.com>
  +
  +        Reviewed by Vicki
  +
  +	<rdar://problem/4231978> many leaks of StyleSurroundData called beneath RenderStyle::setMarginTop, seen running webkit tests
  +	<rdar://problem/4232017> many leaks of StyleInheritedData called from different RenderStyle methods, seen running webkit tests
  +	<rdar://problem/4232175> leak of RenderObject called from RenderContainer::updatePseudoChild, seen running webkit tests
  +	<rdar://problem/4232214> many leaks of RenderStyle from CSSStyleSelector::pseudoStyleForElement, seen running webkit tests
  +	<rdar://problem/4232252> many leaks of RenderStyle called beneath NodeImpl::createRendererIfNeeded, seen running webkit tests
  +	<rdar://problem/4232263> many leaks of RenderObject called from TextImpl::createRenderer, seen running webkit tests
  +	<rdar://problem/4233690> leaks of StyleBackgroundData called within setBackgroundColor, seen running webkit tests
  +
  +        Test cases added: None, these leaks were already caught by the layout tests.
  +
  +        * khtml/rendering/render_block.cpp:
  +        (khtml::RenderBlock::updateFirstLetter):
  +        * khtml/rendering/render_container.cpp:
  +        (RenderContainer::updatePseudoChild):
  +
   2005-08-30  Darin Adler  <darin at apple.com>
   
           Reviewed by Maciej.
  
  
  
  1.200     +2 -0      WebCore/khtml/rendering/render_block.cpp
  
  Index: render_block.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/rendering/render_block.cpp,v
  retrieving revision 1.199
  retrieving revision 1.200
  diff -u -r1.199 -r1.200
  --- render_block.cpp	25 Aug 2005 17:47:14 -0000	1.199
  +++ render_block.cpp	31 Aug 2005 05:09:03 -0000	1.200
  @@ -3370,6 +3370,8 @@
                   newStyle->inheritFrom(pseudoStyle);
                   letter->setStyle(newStyle);
                   firstLetter->addChild(letter);
  +
  +                textObj->detach();;
               }
           }
       }
  
  
  
  1.68      +1 -0      WebCore/khtml/rendering/render_container.cpp
  
  Index: render_container.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/rendering/render_container.cpp,v
  retrieving revision 1.67
  retrieving revision 1.68
  diff -u -r1.67 -r1.68
  --- render_container.cpp	9 Jul 2005 20:19:17 -0000	1.67
  +++ render_container.cpp	31 Aug 2005 05:09:03 -0000	1.68
  @@ -243,6 +243,7 @@
           if (child && child->style()->styleType() == type) {
               oldContentPresent = false;
               removeChild(child);
  +            child->detach();
               child = (type == RenderStyle::BEFORE) ? firstChild() : lastChild();
           }
       }