[webkit-changes] cvs commit: WebCore/khtml/html html_elementimpl.cpp

[John]

sullivan    05/08/30 13:12:57

  Modified:    .        ChangeLog
               khtml/html html_elementimpl.cpp
  Log:
          Reviewed by Kevin Decker.
  
          Test cases added: none, doesn't affect layout
  
          - fixed <rdar://problem/4238024> leak of DocumentFragmentImpl if parseXMLDocumentFragment fails
  
          * khtml/html/html_elementimpl.cpp:
          (HTMLElementImpl::createContextualFragment):
          deref fragment before early return
  
  Revision  Changes    Path
  1.42      +12 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.41
  retrieving revision 1.42
  diff -u -r1.41 -r1.42
  --- ChangeLog	30 Aug 2005 18:20:22 -0000	1.41
  +++ ChangeLog	30 Aug 2005 20:12:56 -0000	1.42
  @@ -1,5 +1,17 @@
   2005-08-30  John Sullivan  <sullivan at apple.com>
   
  +        Reviewed by Kevin Decker.
  +
  +        Test cases added: none, doesn't affect layout
  +        
  +        - fixed <rdar://problem/4238024> leak of DocumentFragmentImpl if parseXMLDocumentFragment fails
  +
  +        * khtml/html/html_elementimpl.cpp:
  +        (HTMLElementImpl::createContextualFragment):
  +        deref fragment before early return
  +
  +2005-08-30  John Sullivan  <sullivan at apple.com>
  +
           Reviewed by Maciej.
   
           Test cases added: none, doesn't affect layout
  
  
  
  1.100     +1 -0      WebCore/khtml/html/html_elementimpl.cpp
  
  Index: html_elementimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/html/html_elementimpl.cpp,v
  retrieving revision 1.99
  retrieving revision 1.100
  diff -u -r1.99 -r1.100
  --- html_elementimpl.cpp	29 Aug 2005 21:29:17 -0000	1.99
  +++ html_elementimpl.cpp	30 Aug 2005 20:12:56 -0000	1.100
  @@ -285,6 +285,7 @@
           
           if (!ret) {
               // FIXME: We should propagate a syntax error exception out here.
  +            fragment->deref();
               return 0;
           }
       }