[webkit-changes] cvs commit: WebCore/khtml/editing replace_selection_command.cpp

[John]

sullivan    05/08/29 16:39:18

  Modified:    .        ChangeLog
               khtml/editing replace_selection_command.cpp
  Log:
          Written by Justin Garcia
          Reviewed by me and Darin Adler
  
          Test cases added: none, doesn't affect layout
  
          - fixed <rdar://problem/4232303> many objects leaked from HTMLTokenizer::parseTag()
          within -[WebView paste:], seen running webkit tests (probably affects Mail)
  
          * khtml/editing/replace_selection_command.cpp:
          (khtml::ReplacementFragment::removeNode):
          guard removeChild call with ref/deref, so if this is the last reference it won't
          be left floating, and will properly self-destruct
  
  Revision  Changes    Path
  1.37      +15 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.36
  retrieving revision 1.37
  diff -u -r1.36 -r1.37
  --- ChangeLog	29 Aug 2005 21:29:06 -0000	1.36
  +++ ChangeLog	29 Aug 2005 23:39:17 -0000	1.37
  @@ -1,3 +1,18 @@
  +2005-08-29  John Sullivan  <sullivan at apple.com>
  +
  +        Written by Justin Garcia
  +        Reviewed by me and Darin Adler
  +
  +        Test cases added: none, doesn't affect layout
  +        
  +        - fixed <rdar://problem/4232303> many objects leaked from HTMLTokenizer::parseTag() 
  +        within -[WebView paste:], seen running webkit tests (probably affects Mail)
  +
  +        * khtml/editing/replace_selection_command.cpp:
  +        (khtml::ReplacementFragment::removeNode):
  +        guard removeChild call with ref/deref, so if this is the last reference it won't
  +        be left floating, and will properly self-destruct
  +
   2005-08-29  Darin Adler  <darin at apple.com>
   
           Rubber stamped by Maciej.
  
  
  
  1.12      +2 -0      WebCore/khtml/editing/replace_selection_command.cpp
  
  Index: replace_selection_command.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/editing/replace_selection_command.cpp,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- replace_selection_command.cpp	26 Aug 2005 22:39:33 -0000	1.11
  +++ replace_selection_command.cpp	29 Aug 2005 23:39:17 -0000	1.12
  @@ -269,7 +269,9 @@
           return;
           
       int exceptionCode = 0;
  +    node->ref();
       parent->removeChild(node, exceptionCode);
  +    node->deref();
       ASSERT(exceptionCode == 0);
   }