[webkit-changes] cvs commit: WebCore/layout-tests/dom/html/level1/core hc_attrcreatedocumentfragment-expected.txt

[Darin]

darin       05/08/25 10:12:32

  Modified:    .        ChangeLog
               khtml/xml dom_elementimpl.cpp
               layout-tests/dom/html/level1/core
                        hc_attrcreatedocumentfragment-expected.txt
  Log:
          Reviewed by John Sullivan.
  
          - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4564
            nodeName for attributes in HTML documents should be lowercase
  
          * khtml/xml/dom_elementimpl.cpp: (AttrImpl::nodeName): Removed the code to
          uppercase the name when in HTML documents.
  
          * layout-tests/dom/html/level1/core/hc_attrcreatedocumentfragment-expected.txt:
          Updated to reflect the fact that this test now succeeds.
  
  Revision  Changes    Path
  1.9       +13 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- ChangeLog	25 Aug 2005 17:12:10 -0000	1.8
  +++ ChangeLog	25 Aug 2005 17:12:30 -0000	1.9
  @@ -2,6 +2,19 @@
   
           Reviewed by John Sullivan.
   
  +        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4564
  +          nodeName for attributes in HTML documents should be lowercase
  +
  +        * khtml/xml/dom_elementimpl.cpp: (AttrImpl::nodeName): Removed the code to
  +        uppercase the name when in HTML documents.
  +
  +        * layout-tests/dom/html/level1/core/hc_attrcreatedocumentfragment-expected.txt:
  +        Updated to reflect the fact that this test now succeeds.
  +
  +2005-08-25  Darin Adler  <darin at apple.com>
  +
  +        Reviewed by John Sullivan.
  +
           - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4551
             implement exceptions for a few XML-specific Document DOM functions
   
  
  
  
  1.74      +0 -2      WebCore/khtml/xml/dom_elementimpl.cpp
  
  Index: dom_elementimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_elementimpl.cpp,v
  retrieving revision 1.73
  retrieving revision 1.74
  diff -u -r1.73 -r1.74
  --- dom_elementimpl.cpp	19 Aug 2005 23:09:18 -0000	1.73
  +++ dom_elementimpl.cpp	25 Aug 2005 17:12:31 -0000	1.74
  @@ -88,8 +88,6 @@
   
   DOMString AttrImpl::nodeName() const
   {
  -    if (m_element && m_element->getDocument()->isHTMLDocument())
  -        return name().upper(); // Have to uppercase attributes when returned in HTML (and not XML).
       return name();
   }
   
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrcreatedocumentfragment-expected.txt
  
  Index: hc_attrcreatedocumentfragment-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrcreatedocumentfragment-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrcreatedocumentfragment-expected.txt	26 Jul 2005 08:31:40 -0000	1.1
  +++ hc_attrcreatedocumentfragment-expected.txt	25 Aug 2005 17:12:31 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrcreatedocumentfragment	
  -Status:	failure
  -Detail:	hasLangAttr: assertEquals failed, actual 0, expected 1.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrcreatedocumentfragment
  +Status:	Success