[webkit-changes] cvs commit: WebCore/manual-tests/resources mouseevent-on-closeddoc.html

Tue Aug 23 18:46:51 PDT 2005

vicki       05/08/23 18:46:50

  Modified:    khtml    khtmlview.cpp
               .        ChangeLog
  Added:       manual-tests mouseevent-on-closeddoc.html
               manual-tests/resources mouseevent-on-closeddoc.html
  Log:
          Reviewed by Adele.

  	- fixed <rdar://problem/4229177> REGRESSION (Denver): crash dispatching mouse events (4608)

          Test cases added:
          * manual-tests/mouseevent-on-closeddoc.html: Added.
          * manual-tests/resources/mouseevent-on-closeddoc.html: Added.

          * khtml/khtmlview.cpp:
          (KHTMLView::dispatchMouseEvent): add nil check

  Revision  Changes    Path
  1.141     +1 -1      WebCore/khtml/khtmlview.cpp

  Index: khtmlview.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/khtmlview.cpp,v
  retrieving revision 1.140
  retrieving revision 1.141
  diff -u -r1.140 -r1.141
  --- khtmlview.cpp	18 Aug 2005 00:03:57 -0000	1.140
  +++ khtmlview.cpp	24 Aug 2005 01:46:49 -0000	1.141
  @@ -1796,7 +1796,7 @@
   				   int mouseEventType)
   {
       // if the target node is a text node, dispatch on the parent node - rdar://4196646
  -    if (targetNode->isTextNode())
  +    if (targetNode && targetNode->isTextNode())
           targetNode = targetNode->parentNode();
       if (d->underMouse)
   	d->underMouse->deref();

  1.4       +13 -0     WebCore/ChangeLog

  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- ChangeLog	23 Aug 2005 22:53:20 -0000	1.3
  +++ ChangeLog	24 Aug 2005 01:46:49 -0000	1.4
  @@ -1,3 +1,16 @@
  +2005-08-23  Vicki Murley  <vicki at apple.com>
  +
  +        Reviewed by Adele.
  +
  +	- fixed <rdar://problem/4229177> REGRESSION (Denver): crash dispatching mouse events (4608)
  + 
  +        Test cases added:
  +        * manual-tests/mouseevent-on-closeddoc.html: Added.
  +        * manual-tests/resources/mouseevent-on-closeddoc.html: Added.
  +
  +        * khtml/khtmlview.cpp:
  +        (KHTMLView::dispatchMouseEvent): add nil check 
  +
   2005-08-20  Darin Adler  <darin at apple.com>

           Reviewed by John.

  1.1                  WebCore/manual-tests/mouseevent-on-closeddoc.html

  Index: mouseevent-on-closeddoc.html
  ===================================================================
  <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
          "http://www.w3.org/TR/html4/strict.dtd">
  <html lang="en">
  <head>
  </head>
  <body>
  <p><b>BUG ID:</b> <a href="rdar://problem/4229177"> 4229177</a> REGRESSION (Denver): crash dispatching mouse events (4608)</p>

  <p id="test" style="background-color:skyblue; padding:3px;"><b>STEPS TO TEST:</b> 
  Click on the link below, and move your mouse cursor over the blank page that is loaded.</p>

TEST PASS: 
 No crash after moving the mouse over the blank page that is loaded. Nothing happens.

TEST FAIL: 
 Crash after moving the mouse over the blank page that opens.

  <a href="resources/mouseevent-on-closeddoc.html">Click this link</a>
  </body>
  </html>

  1.1                  WebCore/manual-tests/resources/mouseevent-on-closeddoc.html

  Index: mouseevent-on-closeddoc.html
  ===================================================================
  <body onload="document.open();document.close();document.open();"></body>