[webkit-changes] cvs commit: WebKit/WebCoreSupport.subproj WebBridge.m

[John]

sullivan    05/08/23 17:34:57

  Modified:    .        ChangeLog
               WebCoreSupport.subproj WebBridge.m
  Log:
          Reviewed by Beth Dakin.
  
          - fixed <rdar://problem/4229167> 14 leaks of WebFileButton and associated objects,
          seen after running webkit layout tests
  
          * WebCoreSupport.subproj/WebBridge.m:
          (-[WebBridge fileButtonWithDelegate:]):
          this method was returning a retained object; I added an autorelease
  
  Revision  Changes    Path
  1.3304    +11 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3303
  retrieving revision 1.3304
  diff -u -r1.3303 -r1.3304
  --- ChangeLog	23 Aug 2005 23:00:24 -0000	1.3303
  +++ ChangeLog	24 Aug 2005 00:34:54 -0000	1.3304
  @@ -1,3 +1,14 @@
  +2005-08-23  John Sullivan  <sullivan at apple.com>
  +
  +        Reviewed by Beth Dakin.
  +        
  +        - fixed <rdar://problem/4229167> 14 leaks of WebFileButton and associated objects, 
  +        seen after running webkit layout tests
  +
  +        * WebCoreSupport.subproj/WebBridge.m:
  +        (-[WebBridge fileButtonWithDelegate:]):
  +        this method was returning a retained object; I added an autorelease
  +
   2005-08-23  Darin Adler  <darin at apple.com>
   
           * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
  
  
  
  1.369     +1 -1      WebKit/WebCoreSupport.subproj/WebBridge.m
  
  Index: WebBridge.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebCoreSupport.subproj/WebBridge.m,v
  retrieving revision 1.368
  retrieving revision 1.369
  diff -u -r1.368 -r1.369
  --- WebBridge.m	17 Aug 2005 20:10:59 -0000	1.368
  +++ WebBridge.m	24 Aug 2005 00:34:57 -0000	1.369
  @@ -405,7 +405,7 @@
   
   - (NSView <WebCoreFileButton> *)fileButtonWithDelegate:(id <WebCoreFileButtonDelegate>)delegate
   {
  -    return [[WebFileButton alloc] initWithBridge:self delegate:delegate];
  +    return [[[WebFileButton alloc] initWithBridge:self delegate:delegate] autorelease];
   }
   
   - (void)runOpenPanelForFileButtonWithResultListener:(id<WebOpenPanelResultListener>)resultListener