[webkit-changes] cvs commit: WebKit/WebCoreSupport.subproj WebTextRenderer.m

[Adele]

adele       05/08/23 16:56:38

  Modified:    .        Tag: Safari-2-0-branch ChangeLog
               WebCoreSupport.subproj Tag: Safari-2-0-branch
                        WebTextRenderer.m
  Log:
          Merged fix from TOT to Safari-2-0-branch
  
      2005-08-23  Mitz Pettel  <opendarwin.org at mitzpettel.com>
  
          Reviewed and landed by Darin.
  
          - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4604
            LEAK -[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:] leaks an ATSUTextLayout
            <rdar://problem/4228787> ATSUTextLayout leak in _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs: (4604)
  
          * WebCoreSupport.subproj/WebTextRenderer.m:
          (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):
          Added missing call to ATSUDisposeTextLayout.
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.3118.4.49 +16 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3118.4.48
  retrieving revision 1.3118.4.49
  diff -u -r1.3118.4.48 -r1.3118.4.49
  --- ChangeLog	18 Aug 2005 19:22:30 -0000	1.3118.4.48
  +++ ChangeLog	23 Aug 2005 23:56:30 -0000	1.3118.4.49
  @@ -1,3 +1,19 @@
  +2005-08-23  Adele Peterson  <adele at apple.com>
  +
  +        Merged fix from TOT to Safari-2-0-branch
  +
  +    2005-08-23  Mitz Pettel  <opendarwin.org at mitzpettel.com>
  +
  +        Reviewed and landed by Darin.
  +
  +        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4604
  +          LEAK -[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:] leaks an ATSUTextLayout
  +          <rdar://problem/4228787> ATSUTextLayout leak in _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs: (4604)
  +
  +        * WebCoreSupport.subproj/WebTextRenderer.m:
  +        (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):
  +        Added missing call to ATSUDisposeTextLayout.
  +
   === Safari-416.2 ===
   
   2005-08-17  Adele Peterson  <adele at apple.com>
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.165.8.7 +3 -1      WebKit/WebCoreSupport.subproj/WebTextRenderer.m
  
  Index: WebTextRenderer.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebCoreSupport.subproj/WebTextRenderer.m,v
  retrieving revision 1.165.8.6
  retrieving revision 1.165.8.7
  diff -u -r1.165.8.6 -r1.165.8.7
  --- WebTextRenderer.m	16 Aug 2005 21:25:28 -0000	1.165.8.6
  +++ WebTextRenderer.m	23 Aug 2005 23:56:37 -0000	1.165.8.7
  @@ -1780,7 +1780,9 @@
       else {
           // Failed to find offset!  Return 0 offset.
       }
  -       
  +    
  +    ATSUDisposeTextLayout(layout);
  +    
       if (style->visuallyOrdered) {
           free ((void *)swappedRun.characters);
       }