[webkit-changes] cvs commit: WebKit/WebCoreSupport.subproj WebTextRenderer.m

[Darin]

darin       05/08/23 14:42:18

  Modified:    .        ChangeLog
               WebCoreSupport.subproj WebTextRenderer.m
  Log:
          Reviewed and landed by Darin.
  
          - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4604
            LEAK -[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:] leaks an ATSUTextLayout
            <rdar://problem/4228787> ATSUTextLayout leak in _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs: (4604)
  
          * WebCoreSupport.subproj/WebTextRenderer.m:
          (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):
          Added missing call to ATSUDisposeTextLayout.
  
  Revision  Changes    Path
  1.3302    +12 -0     WebKit/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebKit/ChangeLog,v
  retrieving revision 1.3301
  retrieving revision 1.3302
  diff -u -r1.3301 -r1.3302
  --- ChangeLog	23 Aug 2005 01:22:13 -0000	1.3301
  +++ ChangeLog	23 Aug 2005 21:42:15 -0000	1.3302
  @@ -1,3 +1,15 @@
  +2005-08-23  Mitz Pettel  <opendarwin.org at mitzpettel.com>
  +
  +        Reviewed and landed by Darin.
  +
  +        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4604
  +          LEAK -[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:] leaks an ATSUTextLayout
  +          <rdar://problem/4228787> ATSUTextLayout leak in _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs: (4604)
  +
  +        * WebCoreSupport.subproj/WebTextRenderer.m:
  +        (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):
  +        Added missing call to ATSUDisposeTextLayout.
  +
   2005-08-22  Geoffrey Garen  <ggaren at apple.com>
   
           - fixed <rdar://problem/4227011> Debugger SPI should be removed from WebView.h API
  
  
  
  1.188     +2 -0      WebKit/WebCoreSupport.subproj/WebTextRenderer.m
  
  Index: WebTextRenderer.m
  ===================================================================
  RCS file: /cvs/root/WebKit/WebCoreSupport.subproj/WebTextRenderer.m,v
  retrieving revision 1.187
  retrieving revision 1.188
  diff -u -r1.187 -r1.188
  --- WebTextRenderer.m	16 Aug 2005 19:03:30 -0000	1.187
  +++ WebTextRenderer.m	23 Aug 2005 21:42:17 -0000	1.188
  @@ -1751,6 +1751,8 @@
           // Failed to find offset!  Return 0 offset.
       }
          
  +    ATSUDisposeTextLayout(layout);
  +    
       if (style->visuallyOrdered || (style->rtl && !ATSUMirrors)) {
           free ((void *)swappedRun.characters);
       }