[webkit-changes] cvs commit: WebCore/layout-tests/dom/html/level1/core hc_attrappendchild1-expected.txt hc_attrappendchild3-expected.txt hc_attrappendchild6-expected.txt hc_attrchildnodes1-expected.txt hc_attrchildnodes2-expected.txt hc_attrclonenode1-expected.txt hc_attrcreatetextnode-expected.txt hc_attrfirstchild-expected.txt hc_attrhaschildnodes-expected.txt hc_attrinsertbefore1-expected.txt hc_attrinsertbefore2-expected.txt hc_attrinsertbefore3-expected.txt hc_attrinsertbefore4-expected.txt hc_attrlastchild-expected.txt hc_attrnormalize-expected.txt hc_attrremovechild1-expected.txt hc_attrreplacechild1-expected.txt hc_attrreplacechild2-expected.txt hc_attrsetvalue1-expected.txt hc_attrsetvalue2-expected.txt hc_elementnormalize2-expected.txt

David harrison at opensource.apple.com
Fri Aug 19 16:09:22 PDT 2005


harrison    05/08/19 16:09:22

  Modified:    .        ChangeLog
               khtml/ecma kjs_dom.cpp
               khtml/xml dom_docimpl.cpp dom_elementimpl.cpp
                        dom_elementimpl.h dom_nodeimpl.cpp
               layout-tests/dom/html/level1/core
                        hc_attrappendchild1-expected.txt
                        hc_attrappendchild3-expected.txt
                        hc_attrappendchild6-expected.txt
                        hc_attrchildnodes1-expected.txt
                        hc_attrchildnodes2-expected.txt
                        hc_attrclonenode1-expected.txt
                        hc_attrcreatetextnode-expected.txt
                        hc_attrfirstchild-expected.txt
                        hc_attrhaschildnodes-expected.txt
                        hc_attrinsertbefore1-expected.txt
                        hc_attrinsertbefore2-expected.txt
                        hc_attrinsertbefore3-expected.txt
                        hc_attrinsertbefore4-expected.txt
                        hc_attrlastchild-expected.txt
                        hc_attrnormalize-expected.txt
                        hc_attrremovechild1-expected.txt
                        hc_attrreplacechild1-expected.txt
                        hc_attrreplacechild2-expected.txt
                        hc_attrsetvalue1-expected.txt
                        hc_attrsetvalue2-expected.txt
                        hc_elementnormalize2-expected.txt
  Log:
          Reviewed by Darin.
          Landed by David Harrison.
  
          Test cases added: None.  Fixes existing tests.
  
          * khtml/ecma/kjs_dom.cpp:
          Attribute values are writable
  
          * khtml/xml/dom_docimpl.cpp:
          (DocumentImpl::createAttributeNS):
          Update for new AttrImpl constructor.
  
          * khtml/xml/dom_elementimpl.cpp:
          (AttributeImpl::allocateImpl):
          Update for new AttrImpl constructor.
  
          (AttrImpl::AttrImpl):
          Initialize m_ignoreChildCount to 0. If createTextChild.
          is true, create a child text node with the contents
          of the attribute value.
  
          (AttrImpl::setValue):
          Remove all children and create a new text node with the contents
          of the attribute value.
  
          (AttrImpl::cloneNode):
          Make sure to clone any children.
  
          (AttrImpl::childrenChanged):
          If m_ignoreChildrenChanged is 0, update the attribute value.
  
          * khtml/xml/dom_elementimpl.h:
          Add childrenChanged, update AttrImpl constructor and
          add m_ignoreChildrenChanged to AttrImpl.
  
          * khtml/xml/dom_nodeimpl.cpp:
          (DOM::NodeImpl::normalize):
          If an element has attributes, make sure to normalize them.
  
          * layout-tests/dom/html/level1/core/hc_attrappendchild1-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrappendchild3-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrappendchild6-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrchildnodes1-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrchildnodes2-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrclonenode1-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrcreatetextnode-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrfirstchild-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrhaschildnodes-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrinsertbefore1-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrinsertbefore2-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrinsertbefore3-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrinsertbefore4-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrlastchild-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrnormalize-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrremovechild1-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrreplacechild1-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrreplacechild2-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrsetvalue1-expected.txt:
          * layout-tests/dom/html/level1/core/hc_attrsetvalue2-expected.txt:
          * layout-tests/dom/html/level1/core/hc_elementnormalize2-expected.txt:
          These tests pass now.
  
  Revision  Changes    Path
  1.4606    +64 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4605
  retrieving revision 1.4606
  diff -u -r1.4605 -r1.4606
  --- ChangeLog	19 Aug 2005 22:29:49 -0000	1.4605
  +++ ChangeLog	19 Aug 2005 23:09:09 -0000	1.4606
  @@ -1,3 +1,67 @@
  +2005-08-19  Anders Carlsson  <andersca at mac.com>
  +
  +        Reviewed by Darin.
  +        Landed by David Harrison.
  +
  +        Test cases added: None.  Fixes existing tests.
  +
  +        * khtml/ecma/kjs_dom.cpp:
  +        Attribute values are writable
  +        
  +        * khtml/xml/dom_docimpl.cpp:
  +        (DocumentImpl::createAttributeNS):
  +        Update for new AttrImpl constructor.
  +        
  +        * khtml/xml/dom_elementimpl.cpp:
  +        (AttributeImpl::allocateImpl):
  +        Update for new AttrImpl constructor.
  +        
  +        (AttrImpl::AttrImpl):
  +        Initialize m_ignoreChildCount to 0. If createTextChild.
  +        is true, create a child text node with the contents
  +        of the attribute value.
  +        
  +        (AttrImpl::setValue):
  +        Remove all children and create a new text node with the contents
  +        of the attribute value.
  +        
  +        (AttrImpl::cloneNode):
  +        Make sure to clone any children.
  +        
  +        (AttrImpl::childrenChanged):
  +        If m_ignoreChildrenChanged is 0, update the attribute value.
  +        
  +        * khtml/xml/dom_elementimpl.h:
  +        Add childrenChanged, update AttrImpl constructor and
  +        add m_ignoreChildrenChanged to AttrImpl.
  +
  +        * khtml/xml/dom_nodeimpl.cpp:
  +        (DOM::NodeImpl::normalize):
  +        If an element has attributes, make sure to normalize them.
  +
  +        * layout-tests/dom/html/level1/core/hc_attrappendchild1-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrappendchild3-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrappendchild6-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrchildnodes1-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrchildnodes2-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrclonenode1-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrcreatetextnode-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrfirstchild-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrhaschildnodes-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrinsertbefore1-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrinsertbefore2-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrinsertbefore3-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrinsertbefore4-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrlastchild-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrnormalize-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrremovechild1-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrreplacechild1-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrreplacechild2-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrsetvalue1-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_attrsetvalue2-expected.txt:
  +        * layout-tests/dom/html/level1/core/hc_elementnormalize2-expected.txt:
  +        These tests pass now.
  +
   2005-08-19  Mitz Pettel  <opendarwin.org at mitzpettel.com>
   
           Reviewed by Darin.
  
  
  
  1.88      +1 -1      WebCore/khtml/ecma/kjs_dom.cpp
  
  Index: kjs_dom.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/ecma/kjs_dom.cpp,v
  retrieving revision 1.87
  retrieving revision 1.88
  diff -u -r1.87 -r1.88
  --- kjs_dom.cpp	16 Aug 2005 00:47:43 -0000	1.87
  +++ kjs_dom.cpp	19 Aug 2005 23:09:17 -0000	1.88
  @@ -810,7 +810,7 @@
   @begin DOMAttrTable 5
     name		DOMAttr::Name		DontDelete|ReadOnly
     specified	DOMAttr::Specified	DontDelete|ReadOnly
  -  value		DOMAttr::ValueProperty	DontDelete|ReadOnly
  +  value		DOMAttr::ValueProperty	DontDelete
     ownerElement	DOMAttr::OwnerElement	DontDelete|ReadOnly
   @end
   */
  
  
  
  1.246     +1 -1      WebCore/khtml/xml/dom_docimpl.cpp
  
  Index: dom_docimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_docimpl.cpp,v
  retrieving revision 1.245
  retrieving revision 1.246
  diff -u -r1.245 -r1.246
  --- dom_docimpl.cpp	17 Aug 2005 20:12:15 -0000	1.245
  +++ dom_docimpl.cpp	19 Aug 2005 23:09:18 -0000	1.246
  @@ -3030,7 +3030,7 @@
       // documents if we're wrong.
       return new AttrImpl(0, docPtr(), new MappedAttributeImpl(QualifiedName(prefix.implementation(), 
                                                                              localName.implementation(),
  -                                                                           namespaceURI.implementation()), DOMString("").implementation()));
  +                                                                           namespaceURI.implementation()), DOMString("").implementation()), false);
   }
   
   SharedPtr<HTMLCollectionImpl> DocumentImpl::images()
  
  
  
  1.73      +41 -6     WebCore/khtml/xml/dom_elementimpl.cpp
  
  Index: dom_elementimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_elementimpl.cpp,v
  retrieving revision 1.72
  retrieving revision 1.73
  diff -u -r1.72 -r1.73
  --- dom_elementimpl.cpp	5 Aug 2005 18:36:29 -0000	1.72
  +++ dom_elementimpl.cpp	19 Aug 2005 23:09:18 -0000	1.73
  @@ -57,18 +57,26 @@
   }
   
   void AttributeImpl::allocateImpl(ElementImpl* e) {
  -    m_impl = new AttrImpl(e, e->docPtr(), this);
  +    m_impl = new AttrImpl(e, e->docPtr(), this, true);
   }
   
  -AttrImpl::AttrImpl(ElementImpl* element, DocumentPtr* docPtr, AttributeImpl* a)
  +AttrImpl::AttrImpl(ElementImpl* element, DocumentPtr* docPtr, AttributeImpl* a, bool createTextChild)
       : ContainerNodeImpl(docPtr),
         m_element(element),
  -      m_attribute(a)
  +      m_attribute(a),
  +      m_ignoreChildrenChanged(0)
   {
       assert(!m_attribute->m_impl);
       m_attribute->m_impl = this;
       m_attribute->ref();
       m_specified = true;
  +    
  +    if (createTextChild && !m_attribute->value().isEmpty()) {
  +        int exceptioncode = 0;
  +        m_ignoreChildrenChanged++;
  +        appendChild(getDocument()->createTextNode(m_attribute->value().implementation()), exceptioncode);
  +        m_ignoreChildrenChanged--;
  +    }
   }
   
   AttrImpl::~AttrImpl()
  @@ -113,8 +121,6 @@
   {
       exceptioncode = 0;
   
  -    // ### according to the DOM docs, we should create an unparsed Text child
  -    // node here
       // do not interprete entities in the string, its literal!
   
       // NO_MODIFICATION_ALLOWED_ERR: Raised when the node is readonly
  @@ -129,6 +135,12 @@
           return;
       }
   
  +    int e = 0;
  +    m_ignoreChildrenChanged++;
  +    removeChildren();
  +    appendChild(getDocument()->createTextNode(v.implementation()), e);
  +    m_ignoreChildrenChanged--;
  +    
       m_attribute->setValue(v.implementation());
       if (m_element)
           m_element->attributeChanged(m_attribute);
  @@ -143,7 +155,10 @@
   
   NodeImpl *AttrImpl::cloneNode ( bool /*deep*/)
   {
  -    return new AttrImpl(0, docPtr(), m_attribute->clone());
  +    AttrImpl *clone = new AttrImpl(0, docPtr(), m_attribute->clone(), false);
  +    
  +    cloneChildNodes(clone);
  +    return clone;
   }
   
   // DOM Section 1.1.1
  @@ -167,6 +182,26 @@
       }
   }
   
  +void AttrImpl::childrenChanged()
  +{
  +    NodeImpl::childrenChanged();
  +    
  +    if (m_ignoreChildrenChanged > 0)
  +        return;
  +    
  +    // FIXME: We should include entity references in the value
  +    
  +    DOMString val = "";
  +    for (NodeImpl *n = firstChild(); n; n = n->nextSibling()) {
  +        if (n->isTextNode())
  +            val += static_cast<TextImpl *>(n)->data();
  +    }
  +    
  +    m_attribute->setValue(val.implementation());
  +    if (m_element)
  +        m_element->attributeChanged(m_attribute);
  +}
  +
   DOMString AttrImpl::toString() const
   {
       DOMString result;
  
  
  
  1.51      +3 -1      WebCore/khtml/xml/dom_elementimpl.h
  
  Index: dom_elementimpl.h
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_elementimpl.h,v
  retrieving revision 1.50
  retrieving revision 1.51
  diff -u -r1.50 -r1.51
  --- dom_elementimpl.h	5 Aug 2005 18:36:29 -0000	1.50
  +++ dom_elementimpl.h	19 Aug 2005 23:09:18 -0000	1.51
  @@ -115,7 +115,7 @@
       friend class NamedAttrMapImpl;
   
   public:
  -    AttrImpl(ElementImpl* element, DocumentPtr* docPtr, AttributeImpl* a);
  +    AttrImpl(ElementImpl* element, DocumentPtr* docPtr, AttributeImpl* a, bool createTextChild);
       ~AttrImpl();
   
   private:
  @@ -147,11 +147,13 @@
       virtual bool childAllowed( NodeImpl *newChild );
       virtual bool childTypeAllowed( unsigned short type );
   
  +    virtual void childrenChanged();
       virtual DOMString toString() const;
   
   protected:
       ElementImpl* m_element;
       AttributeImpl* m_attribute;
  +    int m_ignoreChildrenChanged;
   };
   
   
  
  
  
  1.175     +18 -1     WebCore/khtml/xml/dom_nodeimpl.cpp
  
  Index: dom_nodeimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_nodeimpl.cpp,v
  retrieving revision 1.174
  retrieving revision 1.175
  diff -u -r1.174 -r1.175
  --- dom_nodeimpl.cpp	14 Aug 2005 08:28:01 -0000	1.174
  +++ dom_nodeimpl.cpp	19 Aug 2005 23:09:18 -0000	1.175
  @@ -233,10 +233,27 @@
   
   void NodeImpl::normalize ()
   {
  -    // ### normalize attributes? (when we store attributes using child nodes)
       int exceptioncode = 0;
       NodeImpl *child = firstChild();
   
  +    if (isElementNode()) {
  +        // Normalize any attribute children we might have 
  +        ElementImpl *element = static_cast<ElementImpl *>(this);
  +        NamedAttrMapImpl *attrMap = element->attributes();
  +        
  +        if (attrMap) {
  +            unsigned long numAttrs = attrMap->length();
  +            
  +            for (unsigned long i = 0; i < numAttrs; i++) {
  +                AttributeImpl *attribute = attrMap->attributeItem(i);
  +                AttrImpl *attr = attribute->attrImpl();
  +                
  +                if (attr)
  +                    attr->normalize();
  +            }
  +        }
  +    }
  +    
       // Recursively go through the subtree beneath us, normalizing all nodes. In the case
       // where there are two adjacent text nodes, they are merged together
       while (child) {
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrappendchild1-expected.txt
  
  Index: hc_attrappendchild1-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrappendchild1-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrappendchild1-expected.txt	26 Jul 2005 08:31:40 -0000	1.1
  +++ hc_attrappendchild1-expected.txt	19 Aug 2005 23:09:19 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrappendchild1	
  -Status:	failure
  -Detail:	attrValue: assertEquals failed, actual Yes, expected Yesterday.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrappendchild1
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrappendchild3-expected.txt
  
  Index: hc_attrappendchild3-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrappendchild3-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrappendchild3-expected.txt	26 Jul 2005 08:31:40 -0000	1.1
  +++ hc_attrappendchild3-expected.txt	19 Aug 2005 23:09:19 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrappendchild3	
  -Status:	failure
  -Detail:	attrValue: assertEquals failed, actual Yes, expected Yesterday.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrappendchild3
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrappendchild6-expected.txt
  
  Index: hc_attrappendchild6-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrappendchild6-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrappendchild6-expected.txt	26 Jul 2005 08:31:40 -0000	1.1
  +++ hc_attrappendchild6-expected.txt	19 Aug 2005 23:09:19 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrappendchild6	
  -Status:	failure
  -Detail:	attrValue: assertEquals failed, actual , expected Yesterday.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrappendchild6
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrchildnodes1-expected.txt
  
  Index: hc_attrchildnodes1-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrchildnodes1-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrchildnodes1-expected.txt	26 Jul 2005 08:31:40 -0000	1.1
  +++ hc_attrchildnodes1-expected.txt	19 Aug 2005 23:09:19 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrchildnodes1	
  -Status:	failure
  -Detail:	childNodesSize: assertEquals failed, actual 0, expected 1.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrchildnodes1
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrchildnodes2-expected.txt
  
  Index: hc_attrchildnodes2-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrchildnodes2-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrchildnodes2-expected.txt	26 Jul 2005 08:31:40 -0000	1.1
  +++ hc_attrchildnodes2-expected.txt	19 Aug 2005 23:09:19 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrchildnodes2	
  -Status:	failure
  -Detail:	childNodesSize: assertEquals failed, actual 1, expected 2.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrchildnodes2
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrclonenode1-expected.txt
  
  Index: hc_attrclonenode1-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrclonenode1-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrclonenode1-expected.txt	26 Jul 2005 08:31:40 -0000	1.1
  +++ hc_attrclonenode1-expected.txt	19 Aug 2005 23:09:19 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrclonenode1	
  -Status:	failure
  -Detail:	attrValue: assertEquals failed, actual Yes, expected Yesterday.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrclonenode1
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrcreatetextnode-expected.txt
  
  Index: hc_attrcreatetextnode-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrcreatetextnode-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrcreatetextnode-expected.txt	26 Jul 2005 08:31:40 -0000	1.1
  +++ hc_attrcreatetextnode-expected.txt	19 Aug 2005 23:09:19 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrcreatetextnode	
  -Status:	failure
  -Detail:	value: assertEquals failed, actual Yα, expected Y&ent1;.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrcreatetextnode
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrfirstchild-expected.txt
  
  Index: hc_attrfirstchild-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrfirstchild-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrfirstchild-expected.txt	26 Jul 2005 08:31:40 -0000	1.1
  +++ hc_attrfirstchild-expected.txt	19 Aug 2005 23:09:19 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrfirstchild	
  -Status:	failure
  -Detail:	textNodeNotNull: assertNotNull failed
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrfirstchild
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrhaschildnodes-expected.txt
  
  Index: hc_attrhaschildnodes-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrhaschildnodes-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrhaschildnodes-expected.txt	26 Jul 2005 08:31:41 -0000	1.1
  +++ hc_attrhaschildnodes-expected.txt	19 Aug 2005 23:09:19 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrhaschildnodes	
  -Status:	failure
  -Detail:	hasChildrenIsTrue: assertTrue failed
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrhaschildnodes
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrinsertbefore1-expected.txt
  
  Index: hc_attrinsertbefore1-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrinsertbefore1-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrinsertbefore1-expected.txt	26 Jul 2005 08:31:41 -0000	1.1
  +++ hc_attrinsertbefore1-expected.txt	19 Aug 2005 23:09:19 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrinsertbefore1	
  -Status:	failure
  -Detail:	attrValue: assertEquals failed, actual Yes, expected Yesterday.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrinsertbefore1
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrinsertbefore2-expected.txt
  
  Index: hc_attrinsertbefore2-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrinsertbefore2-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrinsertbefore2-expected.txt	26 Jul 2005 08:31:41 -0000	1.1
  +++ hc_attrinsertbefore2-expected.txt	19 Aug 2005 23:09:19 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrinsertbefore2	
  -Status:	failure
  -Detail:	attrValue: assertEquals failed, actual Yes, expected terdayYes.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrinsertbefore2
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrinsertbefore3-expected.txt
  
  Index: hc_attrinsertbefore3-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrinsertbefore3-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrinsertbefore3-expected.txt	26 Jul 2005 08:31:41 -0000	1.1
  +++ hc_attrinsertbefore3-expected.txt	19 Aug 2005 23:09:19 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrinsertbefore3	
  -Status:	failure
  -Detail:	attrValue: assertEquals failed, actual Yes, expected Yesterday.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrinsertbefore3
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrinsertbefore4-expected.txt
  
  Index: hc_attrinsertbefore4-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrinsertbefore4-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrinsertbefore4-expected.txt	26 Jul 2005 08:31:41 -0000	1.1
  +++ hc_attrinsertbefore4-expected.txt	19 Aug 2005 23:09:20 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrinsertbefore4	
  -Status:	failure
  -Detail:	attrValue: assertEquals failed, actual Yes, expected terdayYes.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrinsertbefore4
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrlastchild-expected.txt
  
  Index: hc_attrlastchild-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrlastchild-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrlastchild-expected.txt	26 Jul 2005 08:31:41 -0000	1.1
  +++ hc_attrlastchild-expected.txt	19 Aug 2005 23:09:20 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrlastchild	
  -Status:	failure
  -Detail:	textNodeNotNull: assertNotNull failed
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrlastchild
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrnormalize-expected.txt
  
  Index: hc_attrnormalize-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrnormalize-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrnormalize-expected.txt	26 Jul 2005 08:31:41 -0000	1.1
  +++ hc_attrnormalize-expected.txt	19 Aug 2005 23:09:20 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrnormalize	
  -Status:	failure
  -Detail:	attrNodeValue: assertEquals failed, actual Yes, expected Yesterday.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrnormalize
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrremovechild1-expected.txt
  
  Index: hc_attrremovechild1-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrremovechild1-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrremovechild1-expected.txt	26 Jul 2005 08:31:41 -0000	1.1
  +++ hc_attrremovechild1-expected.txt	19 Aug 2005 23:09:20 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrremovechild1	
  -Status:	failure
  -Detail:	attrChildNotNull: assertNotNull failed
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrremovechild1
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrreplacechild1-expected.txt
  
  Index: hc_attrreplacechild1-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrreplacechild1-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrreplacechild1-expected.txt	26 Jul 2005 08:31:42 -0000	1.1
  +++ hc_attrreplacechild1-expected.txt	19 Aug 2005 23:09:20 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrreplacechild1	
  -Status:	failure
  -Detail:	attrChildNotNull: assertNotNull failed
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrreplacechild1
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrreplacechild2-expected.txt
  
  Index: hc_attrreplacechild2-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrreplacechild2-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrreplacechild2-expected.txt	26 Jul 2005 08:31:42 -0000	1.1
  +++ hc_attrreplacechild2-expected.txt	19 Aug 2005 23:09:20 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrreplacechild2	
  -Status:	failure
  -Detail:	attrChildNotNull: assertNotNull failed
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrreplacechild2
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrsetvalue1-expected.txt
  
  Index: hc_attrsetvalue1-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrsetvalue1-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrsetvalue1-expected.txt	26 Jul 2005 08:31:42 -0000	1.1
  +++ hc_attrsetvalue1-expected.txt	19 Aug 2005 23:09:20 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrsetvalue1	
  -Status:	failure
  -Detail:	attrChildNotNull: assertNotNull failed
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrsetvalue1
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_attrsetvalue2-expected.txt
  
  Index: hc_attrsetvalue2-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_attrsetvalue2-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_attrsetvalue2-expected.txt	26 Jul 2005 08:31:42 -0000	1.1
  +++ hc_attrsetvalue2-expected.txt	19 Aug 2005 23:09:20 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrsetvalue2	
  -Status:	failure
  -Detail:	attrValue: assertEquals failed, actual Yes, expected Tomorrow.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_attrsetvalue2
  +Status:	Success
  
  
  
  1.2       +2 -3      WebCore/layout-tests/dom/html/level1/core/hc_elementnormalize2-expected.txt
  
  Index: hc_elementnormalize2-expected.txt
  ===================================================================
  RCS file: /cvs/root/WebCore/layout-tests/dom/html/level1/core/hc_elementnormalize2-expected.txt,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- hc_elementnormalize2-expected.txt	26 Jul 2005 08:31:47 -0000	1.1
  +++ hc_elementnormalize2-expected.txt	19 Aug 2005 23:09:20 -0000	1.2
  @@ -1,3 +1,2 @@
  -Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_elementnormalize2	
  -Status:	failure
  -Detail:	firstChild: assertEquals failed, actual , expected Yes.
  +Test:	http://www.w3.org/2001/DOM-Test-Suite/level1/core/hc_elementnormalize2
  +Status:	Success
  
  
  



More information about the webkit-changes mailing list