[webkit-changes] cvs commit: WebCore/khtml khtmlview.cpp
Adele
adele at opensource.apple.com
Wed Aug 17 17:19:03 PDT 2005
adele 05/08/17 17:19:02
Modified: . Tag: Safari-OC-branch ChangeLog
khtml Tag: Safari-OC-branch khtmlview.cpp
Log:
Merged fix from TOT to branch
2005-08-17 Justin Garcia <justin.garcia at apple.com>
Reviewed by darin, adele
Fixes <rdar://problem/4219869> REGRESSION (OC): First frame never draws if it's delayed
A recent change uncovered a bug where on early returns from KHTMLView::layout(), layoutSchedulingEnabled
was not reset to true, preventing later layouts from occuring.
* khtml/khtmlview.cpp:
(KHTMLView::layout):
Revision Changes Path
No revision
No revision
1.4104.2.68.2.4 +15 -0 WebCore/ChangeLog
Index: ChangeLog
===================================================================
RCS file: /cvs/root/WebCore/ChangeLog,v
retrieving revision 1.4104.2.68.2.3
retrieving revision 1.4104.2.68.2.4
diff -u -r1.4104.2.68.2.3 -r1.4104.2.68.2.4
--- ChangeLog 17 Aug 2005 21:41:22 -0000 1.4104.2.68.2.3
+++ ChangeLog 18 Aug 2005 00:18:54 -0000 1.4104.2.68.2.4
@@ -1,3 +1,18 @@
+2005-08-17 Adele Peterson <adele at apple.com>
+
+ Merged fix from TOT to branch
+
+ 2005-08-17 Justin Garcia <justin.garcia at apple.com>
+
+ Reviewed by darin, adele
+
+ Fixes <rdar://problem/4219869> REGRESSION (OC): First frame never draws if it's delayed
+ A recent change uncovered a bug where on early returns from KHTMLView::layout(), layoutSchedulingEnabled
+ was not reset to true, preventing later layouts from occuring.
+
+ * khtml/khtmlview.cpp:
+ (KHTMLView::layout):
+
2005-08-17 Vicki Murley <vicki at apple.com>
Reviewed by Darin.
No revision
No revision
1.128.8.1.6.1 +3 -1 WebCore/khtml/khtmlview.cpp
Index: khtmlview.cpp
===================================================================
RCS file: /cvs/root/WebCore/khtml/khtmlview.cpp,v
retrieving revision 1.128.8.1
retrieving revision 1.128.8.1.6.1
diff -u -r1.128.8.1 -r1.128.8.1.6.1
--- khtmlview.cpp 27 Apr 2005 00:58:14 -0000 1.128.8.1
+++ khtmlview.cpp 18 Aug 2005 00:19:02 -0000 1.128.8.1.6.1
@@ -571,7 +571,6 @@
if (d->layoutSuppressed)
return;
- d->layoutSchedulingEnabled=false;
killTimer(d->layoutTimerId);
d->layoutTimerId = 0;
d->delayedLayout = false;
@@ -590,6 +589,8 @@
return;
}
+ d->layoutSchedulingEnabled = false;
+
// Always ensure our style info is up-to-date. This can happen in situations where
// the layout beats any sort of style recalc update that needs to occur.
if (document->hasChangedChild())
@@ -598,6 +599,7 @@
khtml::RenderCanvas* root = static_cast<khtml::RenderCanvas*>(document->renderer());
if (!root) {
// FIXME: Do we need to set _width or _height here?
+ d->layoutSchedulingEnabled = true;
return;
}
More information about the webkit-changes
mailing list