[webkit-changes] cvs commit: WebCore/WebCore.xcodeproj project.pbxproj

[Darin]

darin       05/08/15 14:57:17

  Modified:    .        ChangeLog
               WebCore.xcodeproj project.pbxproj
  Log:
          Reviewed by Justin.
  
          - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4324
            WebCore build does a slow "nmedit -s" step that's unnecessary
  
          * WebCore.xcodeproj/project.pbxproj: Stop using EXPORTED_SYMBOLS_FILE, since it does an
          unneccessary nmedit step that is particularly slow for WebCore. Instead, define
          WEBCORE_EXPORTED_SYMBOLS_FILE and put a flag into OTHER_LDFLAGS.
  
  Revision  Changes    Path
  1.4578    +11 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4577
  retrieving revision 1.4578
  diff -u -r1.4577 -r1.4578
  --- ChangeLog	15 Aug 2005 05:01:43 -0000	1.4577
  +++ ChangeLog	15 Aug 2005 21:57:12 -0000	1.4578
  @@ -1,3 +1,14 @@
  +2005-08-15  Darin Adler  <darin at apple.com>
  +
  +        Reviewed by Justin.
  +
  +        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4324
  +          WebCore build does a slow "nmedit -s" step that's unnecessary
  +
  +        * WebCore.xcodeproj/project.pbxproj: Stop using EXPORTED_SYMBOLS_FILE, since it does an
  +        unneccessary nmedit step that is particularly slow for WebCore. Instead, define
  +        WEBCORE_EXPORTED_SYMBOLS_FILE and put a flag into OTHER_LDFLAGS.
  +
   2005-08-14  Andrew Wellington  <proton at wiretapped.net>
   
           Reviewed and landed by Darin.
  
  
  
  1.10      +8 -4      WebCore/WebCore.xcodeproj/project.pbxproj
  
  Index: project.pbxproj
  ===================================================================
  RCS file: /cvs/root/WebCore/WebCore.xcodeproj/project.pbxproj,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- project.pbxproj	8 Aug 2005 21:11:58 -0000	1.9
  +++ project.pbxproj	15 Aug 2005 21:57:16 -0000	1.10
  @@ -10049,7 +10049,6 @@
   				DEBUG_DEFINES = "";
   				DYLIB_COMPATIBILITY_VERSION = 1;
   				DYLIB_CURRENT_VERSION = 1;
  -				EXPORTED_SYMBOLS_FILE = "$(DERIVED_FILES_DIR)/WebCore-combined.exp";
   				FRAMEWORK_SEARCH_PATHS = /System/Library/Frameworks/WebKit.framework/Frameworks;
   				GCC_ENABLE_CPP_EXCEPTIONS = NO;
   				GCC_ENABLE_CPP_RTTI = NO;
  @@ -10080,6 +10079,7 @@
   				OTHER_LDFLAGS = (
   					"$(STYLE_LDFLAGS)",
   					"-lxml2-WebCore",
  +					"-Wl,-exported_symbols_list,$(WEBCORE_EXPORTED_SYMBOLS_FILE)",
   				);
   				PREBINDING = NO;
   				PRODUCT_NAME = WebCore;
  @@ -10097,6 +10097,7 @@
   					"-Wno-format-y2k",
   					"-Wno-unused-parameter",
   				);
  +				WEBCORE_EXPORTED_SYMBOLS_FILE = "$(DERIVED_FILES_DIR)/WebCore-combined.exp";
   			};
   			name = Development;
   		};
  @@ -10107,7 +10108,6 @@
   				DEBUG_DEFINES = NDEBUG;
   				DYLIB_COMPATIBILITY_VERSION = 1;
   				DYLIB_CURRENT_VERSION = 1;
  -				EXPORTED_SYMBOLS_FILE = WebCore.exp;
   				FRAMEWORK_SEARCH_PATHS = /System/Library/Frameworks/WebKit.framework/Frameworks;
   				GCC_ENABLE_CPP_EXCEPTIONS = NO;
   				GCC_ENABLE_CPP_RTTI = NO;
  @@ -10138,6 +10138,7 @@
   				OTHER_LDFLAGS = (
   					"$(STYLE_LDFLAGS)",
   					"-lxml2-WebCore",
  +					"-Wl,-exported_symbols_list,$(WEBCORE_EXPORTED_SYMBOLS_FILE)",
   				);
   				PREBINDING = NO;
   				PRODUCT_NAME = WebCore;
  @@ -10155,6 +10156,7 @@
   					"-Wno-format-y2k",
   					"-Wno-unused-parameter",
   				);
  +				WEBCORE_EXPORTED_SYMBOLS_FILE = WebCore.exp;
   			};
   			name = Deployment;
   		};
  @@ -10165,7 +10167,6 @@
   				DEBUG_DEFINES = NDEBUG;
   				DYLIB_COMPATIBILITY_VERSION = 1;
   				DYLIB_CURRENT_VERSION = 1;
  -				EXPORTED_SYMBOLS_FILE = WebCore.exp;
   				FRAMEWORK_SEARCH_PATHS = /System/Library/Frameworks/WebKit.framework/Frameworks;
   				GCC_ENABLE_CPP_EXCEPTIONS = NO;
   				GCC_ENABLE_CPP_RTTI = NO;
  @@ -10196,6 +10197,7 @@
   				OTHER_LDFLAGS = (
   					"$(STYLE_LDFLAGS)",
   					"-lxml2-WebCore",
  +					"-Wl,-exported_symbols_list,$(WEBCORE_EXPORTED_SYMBOLS_FILE)",
   				);
   				PREBINDING = NO;
   				PRODUCT_NAME = WebCore;
  @@ -10213,6 +10215,7 @@
   					"-Wno-format-y2k",
   					"-Wno-unused-parameter",
   				);
  +				WEBCORE_EXPORTED_SYMBOLS_FILE = WebCore.exp;
   			};
   			name = OptimizedWithSymbols;
   		};
  @@ -10223,7 +10226,6 @@
   				DEBUG_DEFINES = NDEBUG;
   				DYLIB_COMPATIBILITY_VERSION = 1;
   				DYLIB_CURRENT_VERSION = 1;
  -				EXPORTED_SYMBOLS_FILE = WebCore.exp;
   				FRAMEWORK_SEARCH_PATHS = /System/Library/Frameworks/WebKit.framework/Frameworks;
   				GCC_ENABLE_CPP_EXCEPTIONS = NO;
   				GCC_ENABLE_CPP_RTTI = NO;
  @@ -10253,6 +10255,7 @@
   				OTHER_LDFLAGS = (
   					"$(STYLE_LDFLAGS)",
   					"-lxml2-WebCore",
  +					"-Wl,-exported_symbols_list,$(WEBCORE_EXPORTED_SYMBOLS_FILE)",
   				);
   				PRODUCT_NAME = WebCore;
   				SECTORDER_FLAGS = (
  @@ -10274,6 +10277,7 @@
   					"-Wno-format-y2k",
   					"-Wno-unused-parameter",
   				);
  +				WEBCORE_EXPORTED_SYMBOLS_FILE = WebCore.exp;
   			};
   			name = Default;
   		};