[webkit-changes] cvs commit: WebCore/khtml/ecma xmlhttprequest.cpp

[Vicki]

vicki       05/08/10 15:46:08

  Modified:    .        ChangeLog
               khtml/ecma xmlhttprequest.cpp
  Log:
          Reviewed by John.
  
  	- attempted fix for <rdar://problem/4070895> 8A428: Unrepro Safari crash on
  	friendster.com (XMLHttpRequest::changeState)
  
          Test cases added: None - there are no known reproducible cases of this crash
  
          * khtml/ecma/xmlhttprequest.cpp:
          (KJS::XMLHttpRequest::changeState): add checks for NULL document
  
  Revision  Changes    Path
  1.4554    +12 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4553
  retrieving revision 1.4554
  diff -u -r1.4553 -r1.4554
  --- ChangeLog	10 Aug 2005 21:55:12 -0000	1.4553
  +++ ChangeLog	10 Aug 2005 22:45:58 -0000	1.4554
  @@ -1,3 +1,15 @@
  +2005-08-10  Vicki Murley  <vicki at apple.com>
  +
  +        Reviewed by John.
  + 
  +	- attempted fix for <rdar://problem/4070895> 8A428: Unrepro Safari crash on 
  +	friendster.com (XMLHttpRequest::changeState) 
  +
  +        Test cases added: None - there are no known reproducible cases of this crash
  +
  +        * khtml/ecma/xmlhttprequest.cpp:
  +        (KJS::XMLHttpRequest::changeState): add checks for NULL document
  +
   2005-08-10  Adele Peterson  <adele at apple.com>
   
           Bumping version to 420+
  
  
  
  1.36      +2 -2      WebCore/khtml/ecma/xmlhttprequest.cpp
  
  Index: xmlhttprequest.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/ecma/xmlhttprequest.cpp,v
  retrieving revision 1.35
  retrieving revision 1.36
  diff -u -r1.35 -r1.36
  --- xmlhttprequest.cpp	8 Aug 2005 04:07:42 -0000	1.35
  +++ xmlhttprequest.cpp	10 Aug 2005 22:46:08 -0000	1.36
  @@ -262,7 +262,7 @@
     if (state != newState) {
       state = newState;
       
  -    if (onReadyStateChangeListener != 0 && doc->part()) {
  +    if (doc && doc->part() && onReadyStateChangeListener != 0) {
         int ignoreException;
         EventImpl *ev = doc->createEvent("HTMLEvents", ignoreException);
         ev->ref();
  @@ -271,7 +271,7 @@
         ev->deref();
       }
       
  -    if (state == Completed && onLoadListener != 0 && doc->part()) {
  +    if (doc && doc->part() && state == Completed && onLoadListener != 0) {
         int ignoreException;
         EventImpl *ev = doc->createEvent("HTMLEvents", ignoreException);
         ev->ref();