[webkit-changes] cvs commit: WebCore ChangeLog

[Darin]

darin       05/08/04 15:23:04

  Modified:    kwq      DOM.mm
               .        ChangeLog
  Log:
          Reviewed by John Sullivan.
  
          - fixed Objective-C binding for getOverrideStyle
  
          * kwq/DOM.mm: ([DOMDocument getOverrideStyle::]): Change to call the DOM
          getOverrideStyle. It was not correct to call getComputedStyle just because
          getOverrideStyle is not yet implemented in our DOM.
  
  Revision  Changes    Path
  1.40      +6 -6      WebCore/kwq/DOM.mm
  
  Index: DOM.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/DOM.mm,v
  retrieving revision 1.39
  retrieving revision 1.40
  diff -u -r1.39 -r1.40
  --- DOM.mm	30 Jul 2005 02:33:09 -0000	1.39
  +++ DOM.mm	4 Aug 2005 22:23:00 -0000	1.40
  @@ -1059,11 +1059,11 @@
       return [DOMCSSStyleDeclaration _styleDeclarationWithImpl:[self _documentImpl]->defaultView()->getComputedStyle(elementImpl, pseudoEltString.implementation())];
   }
   
  -- (DOMCSSStyleDeclaration *)getOverrideStyle:(DOMElement *)elt :(NSString *)pseudoElt;
  +- (DOMCSSStyleDeclaration *)getOverrideStyle:(DOMElement *)elt :(NSString *)pseudoElt
   {
  -    // FIXME: This is unimplemented by khtml, 
  -    // so for now, we just return the computed style
  -    return [self getComputedStyle:elt :pseudoElt];
  +    ElementImpl *elementImpl = [elt _elementImpl];
  +    DOMString pseudoEltString(pseudoElt);
  +    return [DOMCSSStyleDeclaration _styleDeclarationWithImpl:[self _documentImpl]->getOverrideStyle(elementImpl, pseudoEltString.implementation())];
   }
   
   @end
  @@ -1079,7 +1079,7 @@
   
   @implementation DOMDocument (DOMDocumentExtensions)
   
  -- (DOMCSSStyleDeclaration *)createCSSStyleDeclaration;
  +- (DOMCSSStyleDeclaration *)createCSSStyleDeclaration
   {
       return [DOMCSSStyleDeclaration _styleDeclarationWithImpl:[self _documentImpl]->createCSSStyleDeclaration()];
   }
  @@ -1163,7 +1163,7 @@
       raiseOnDOMError(exceptionCode);
   }
   
  -- (void)deleteData:(unsigned long)offset :(unsigned long) count;
  +- (void)deleteData:(unsigned long)offset :(unsigned long) count
   {
       int exceptionCode = 0;
       [self _characterDataImpl]->deleteData(offset, count, exceptionCode);
  
  
  
  1.4523    +10 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4522
  retrieving revision 1.4523
  diff -u -r1.4522 -r1.4523
  --- ChangeLog	4 Aug 2005 21:33:43 -0000	1.4522
  +++ ChangeLog	4 Aug 2005 22:23:00 -0000	1.4523
  @@ -1,3 +1,13 @@
  +2005-08-04  Darin Adler  <darin at apple.com>
  +
  +        Reviewed by John Sullivan.
  +
  +        - fixed Objective-C binding for getOverrideStyle
  +
  +        * kwq/DOM.mm: ([DOMDocument getOverrideStyle::]): Change to call the DOM
  +        getOverrideStyle. It was not correct to call getComputedStyle just because
  +        getOverrideStyle is not yet implemented in our DOM.
  +
   2005-08-04  Adele Peterson  <adele at apple.com>
   
           Reviewed by John.