[webkit-changes] cvs commit: WebCore/manual-tests mouseevents-on-textnodes.html

Wed Aug 3 14:23:23 PDT 2005

vicki       05/08/03 14:23:22

  Modified:    .        ChangeLog
               khtml    khtmlview.cpp
  Added:       manual-tests mouseevents-on-textnodes.html
  Log:
          Reviewed by Beth and Hyatt.

  	<rdar://problem/4196646> target returns text node when it should return the parent node

          Test cases added: manual-tests/mouseevents-on-textnodes.html

          * khtml/khtmlview.cpp:
          (KHTMLView::dispatchMouseEvent): if the targetNode is a text node, set the
  	targetNode to the parent node

  Revision  Changes    Path
  1.4519    +12 -0     WebCore/ChangeLog

  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4518
  retrieving revision 1.4519
  diff -u -r1.4518 -r1.4519
  --- ChangeLog	3 Aug 2005 00:07:01 -0000	1.4518
  +++ ChangeLog	3 Aug 2005 21:23:18 -0000	1.4519
  @@ -1,3 +1,15 @@
  +2005-08-03  Vicki Murley  <vicki at apple.com>
  +
  +        Reviewed by Beth and Hyatt.
  + 
  +	<rdar://problem/4196646> target returns text node when it should return the parent node
  +
  +        Test cases added: manual-tests/mouseevents-on-textnodes.html
  +
  +        * khtml/khtmlview.cpp:
  +        (KHTMLView::dispatchMouseEvent): if the targetNode is a text node, set the 
  +	targetNode to the parent node
  +
   2005-08-02  Bruce DiBello  <bdibello at apple.com>

           Reviewed by Geoffrey Garen.

  1.139     +3 -0      WebCore/khtml/khtmlview.cpp

  Index: khtmlview.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/khtmlview.cpp,v
  retrieving revision 1.138
  retrieving revision 1.139
  diff -u -r1.138 -r1.139
  --- khtmlview.cpp	30 Jul 2005 02:33:11 -0000	1.138
  +++ khtmlview.cpp	3 Aug 2005 21:23:22 -0000	1.139
  @@ -1793,6 +1793,9 @@
   				   int detail,QMouseEvent *_mouse, bool setUnder,
   				   int mouseEventType)
   {
  +    // if the target node is a text node, dispatch on the parent node - rdar://4196646
  +    if (targetNode->isTextNode())
  +        targetNode = targetNode->parentNode();
       if (d->underMouse)
   	d->underMouse->deref();
       d->underMouse = targetNode;

  1.1                  WebCore/manual-tests/mouseevents-on-textnodes.html

  Index: mouseevents-on-textnodes.html
  ===================================================================
  <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
          "http://www.w3.org/TR/html4/strict.dtd">
  <html lang="en">
  <head>
  <script type="text/javascript" language="javascript" charset="utf-8">

  	document.onmousedown = doIt;

  	function doIt(evt) {
  		var elem = evt.target;
  		var anAttr = null;
  		alert (elem);
  	}

  </script>

  </head>
  <body>
  <p><b>BUG ID:</b> <a href="rdar://problem/4196646">4196646</a> target returns text node when it should return the parent node</p>

STEPS TO TEST: 
 Click where indicated below.

TEST PASS: 
 After clicking, see alert dialogs as described below.

TEST FAIL: 
 After clicking, see alert dialogs other than what is described below.
 Specifically, tests #1 and #3 below will alert "[object TEXT]"

1. click on this text - you should see an alert that says "[object P]"

<div style="border: 1px dotted red; width: 500px; ">2. click on white space next to this text --> you should see an alert that says "[object DIV]" --> </div>

3. click on this text - you should see an alert that says "[object BODY]"

  4. click on empty whitespace on this page, below this text - you should see an alert that says "[object HTML]"

  </body>
  </html>