[webkit-changes] cvs commit: WebCore/kwq KWQComboBox.mm

[Adele]

adele       05/08/02 14:39:01

  Modified:    .        Tag: Safari-2-0-branch ChangeLog
               kwq      Tag: Safari-2-0-branch KWQComboBox.mm
  Log:
          Merged fix from TOT to Safari-2-0-branch
  
      2005-07-25  Vicki Murley  <vicki at apple.com>
  
          Reviewed by Beth Dakin.
  
  	- fixed <rdar://problem/4011544> selecting an item from a <select> menu with
  	the mouse doesn't place the focus on the menu
  
  	Test cases added:
          * manual-tests/focus-select-when-clicked.html: Added.
  
          * kwq/KWQComboBox.mm:
          (-[KWQPopUpButton needsPanelToBecomeKey]): override this NSView method to return YES
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.4104.2.83 +17 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4104.2.82
  retrieving revision 1.4104.2.83
  diff -u -r1.4104.2.82 -r1.4104.2.83
  --- ChangeLog	2 Aug 2005 21:35:24 -0000	1.4104.2.82
  +++ ChangeLog	2 Aug 2005 21:38:53 -0000	1.4104.2.83
  @@ -2,6 +2,23 @@
   
           Merged fix from TOT to Safari-2-0-branch
   
  +    2005-07-25  Vicki Murley  <vicki at apple.com>
  +
  +        Reviewed by Beth Dakin.
  +
  +	- fixed <rdar://problem/4011544> selecting an item from a <select> menu with 
  +	the mouse doesn't place the focus on the menu
  +        
  +	Test cases added: 
  +        * manual-tests/focus-select-when-clicked.html: Added.
  +
  +        * kwq/KWQComboBox.mm:
  +        (-[KWQPopUpButton needsPanelToBecomeKey]): override this NSView method to return YES
  +
  +2005-08-02  Adele Peterson  <adele at apple.com>
  +
  +        Merged fix from TOT to Safari-2-0-branch
  +
       2005-06-29  Anders Carlsson  <andersca at mac.com>
   
           Reviewed and landed by Darin Adler.
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.59.10.2 +6 -0      WebCore/kwq/KWQComboBox.mm
  
  Index: KWQComboBox.mm
  ===================================================================
  RCS file: /cvs/root/WebCore/kwq/KWQComboBox.mm,v
  retrieving revision 1.59.10.1
  retrieving revision 1.59.10.2
  diff -u -r1.59.10.1 -r1.59.10.2
  --- KWQComboBox.mm	22 Jul 2005 01:18:35 -0000	1.59.10.1
  +++ KWQComboBox.mm	2 Aug 2005 21:39:00 -0000	1.59.10.2
  @@ -498,6 +498,12 @@
       return resign;
   }
   
  +- (BOOL)needsPanelToBecomeKey
  +{
  +    // override this NSView method so that <select> elements gain focus when clicked - 4011544
  +    return YES;
  +}
  +
   - (BOOL)canBecomeKeyView
   {
       // Simplified method from NSView; overridden to replace NSView's way of checking