[webkit-changes] cvs commit: WebCore/khtml/css css_valueimpl.cpp

[Adele]

adele       05/08/02 09:47:38

  Modified:    .        Tag: Safari-2-0-branch ChangeLog
               khtml/css Tag: Safari-2-0-branch css_valueimpl.cpp
  Log:
          Merged fix from TOT to Safari-2-0-branch
  
      2005-07-28  Beth Dakin  <bdakin at apple.com>
  
  	This is a fix for <rdar://problem/4190684>. Hyatt and I
  	(okay, mostly Hyatt) wrote this for Cayenne so that they
  	can change the value of a style of a rule and have everything
  	update dynamically without causing a crash.
  
  	Reviewed by Hyatt
  
          Test cases added: (NONE)
  
          * khtml/css/css_valueimpl.cpp:
          (DOM::CSSMutableStyleDeclarationImpl::setChanged):
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.4104.2.79 +18 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4104.2.78
  retrieving revision 1.4104.2.79
  diff -u -r1.4104.2.78 -r1.4104.2.79
  --- ChangeLog	27 Jul 2005 21:08:10 -0000	1.4104.2.78
  +++ ChangeLog	2 Aug 2005 16:47:31 -0000	1.4104.2.79
  @@ -1,3 +1,21 @@
  +2005-08-02  Adele Peterson  <adele at apple.com>
  +
  +        Merged fix from TOT to Safari-2-0-branch
  +
  +    2005-07-28  Beth Dakin  <bdakin at apple.com>
  +
  +	This is a fix for <rdar://problem/4190684>. Hyatt and I
  +	(okay, mostly Hyatt) wrote this for Cayenne so that they
  +	can change the value of a style of a rule and have everything
  +	update dynamically without causing a crash.         
  +
  +	Reviewed by Hyatt
  +
  +        Test cases added: (NONE)
  +
  +        * khtml/css/css_valueimpl.cpp:
  +        (DOM::CSSMutableStyleDeclarationImpl::setChanged):
  +
   2005-07-27  Adele Peterson  <adele at apple.com>
   
           Merged fix from TOT to Safari-2-0-branch
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.66.8.1  +6 -5      WebCore/khtml/css/css_valueimpl.cpp
  
  Index: css_valueimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/css/css_valueimpl.cpp,v
  retrieving revision 1.66
  retrieving revision 1.66.8.1
  diff -u -r1.66 -r1.66.8.1
  --- css_valueimpl.cpp	15 Mar 2005 00:43:10 -0000	1.66
  +++ css_valueimpl.cpp	2 Aug 2005 16:47:38 -0000	1.66.8.1
  @@ -337,11 +337,12 @@
       }
   
       // ### quick&dirty hack for KDE 3.0... make this MUCH better! (Dirk)
  -    for (StyleBaseImpl* stylesheet = this; stylesheet; stylesheet = stylesheet->parent())
  -        if (stylesheet->isCSSStyleSheet()) {
  -            static_cast<CSSStyleSheetImpl*>(stylesheet)->doc()->updateStyleSelector();
  -            break;
  -        }
  +    StyleBaseImpl *root = this;
  +    StyleBaseImpl *parent;
  +    while ( ( parent = root->parent()) )
  +        root = parent;
  +    if (root->isCSSStyleSheet())
  +        static_cast<CSSStyleSheetImpl*>(root)->doc()->updateStyleSelector();
   }
   
   bool CSSMutableStyleDeclarationImpl::getPropertyPriority(int propertyID) const