[jsc-dev] JSC build with unified sources.

Keith Miller keith_miller at apple.com
Wed Sep 20 15:45:51 PDT 2017


Hi all,

As discussed more widely on webkit-dev, I’m working on switching us to unified source builds. I’m starting with JavaScriptCore since it seems like a good starting point. You can check out the bug here: https://bugs.webkit.org/show_bug.cgi?id=177190. Right now, we are only doing unified sources for platform specific files (plus LowLevelInterpreter.cpp due to a clang bug on armv7s). 

The new workflow for adding a platform independent source file to the build is to add it to Source/JavaScriptCore/sources.txt. It’s not necessary to add the source file to the CMakeLists.txt file anymore, CMake will get the source information from the sources.txt file. You should also add the source to the Xcode project but be sure you don’t add it to the JavaScriptCore framework target. The build script should handle everything else. 

Due to limitations of Xcode, we cannot automatically add more unified source bundle files to the Xcode build. Sometimes when new files are added you’ll see an error message asking you to add a new bundle file. I’d like it if new developers could figure out what to do just from the error message alone so I’m not going to describe what you’ll need to change in this email. If the error message isn’t clear enough let me know. 

In an upcoming patch there will also be a Source/JavaScriptCore/sources-<Mac/GTK/...>.txt file for port specific files.

Thanks for helping me test the new build system! Even though I didn’t ask if you wanted to! Let me know if you have any questions.

Cheers,
Keith 


More information about the jsc-dev mailing list