WKEinaSharedString
Hi, New WKEinaSharedString class was added at r125035. It is basically a smart pointer for Eina_Stringshare . You may use it to save some lines of code and be safe about invoking eina_stringshare_del in time. Example of using WKEinaSharedString can be found at Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list_item.cpp. BR, Mikhail --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
Hello Mikhail, Thank you for your patch. I wonder how do efl folks think to adjust this string class existing implementations as well as to add this usage to EFL coding style doc. Cheers, Gyuyoung. From: webkit-efl-bounces@lists.webkit.org [mailto:webkit-efl-bounces@lists.webkit.org] On Behalf Of Pozdnyakov, Mikhail Sent: Tuesday, August 14, 2012 5:46 PM To: webkit-efl@lists.webkit.org Subject: [webkit-efl] WKEinaSharedString Hi, New WKEinaSharedString class was added at r125035. It is basically a smart pointer for Eina_Stringshare . You may use it to save some lines of code and be safe about invoking eina_stringshare_del in time. Example of using WKEinaSharedString can be found at Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list_item.cpp. BR, Mikhail --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
Hi, Thanks Mikhail, I like it :) I think we should refactor the other ewk classes to use it and make it part of the WebKit-EFL coding style. It results in smaller code which is less bug-prone and easier to maintain. This is also very consistent with the rest of WebKit: this basically behave similarly to OwnPtr but for Eina StringShare. Kr, On Tue, Aug 14, 2012 at 11:45 AM, Pozdnyakov, Mikhail < mikhail.pozdnyakov@intel.com> wrote:
Hi,****
** **
New WKEinaSharedString class was added at r125035.****
It is basically a smart pointer for Eina_Stringshare .****
You may use it to save some lines of code and be ****
safe about invoking eina_stringshare_del in time.****
** **
Example of using WKEinaSharedString can be found at****
Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list_item.cpp.****
** **
BR,****
Mikhail****
--------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
_______________________________________________ webkit-efl mailing list webkit-efl@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-efl
-- Christophe Dumez Linux Software Engineer, PhD Intel Finland Oy - Open Source Technology Center
participants (3)
-
Dumez, Christophe
-
Gyuyoung Kim
-
Pozdnyakov, Mikhail