Re: [webkit-efl] Update Skipped file of EFL layout test for Ubuntu 11.10
Hello Dominik,
Wouldn't it make sense to adopt the approach of the GTK port and to augment Ubuntu 11.10 with jhbuild?
Yes, I agree with your suggestion. We also need to have a script like jhbuild to run layout test on same environment.
If you let us know, we can work on 1) adopting JHBuild for EFL build procedure 2) creating a defined font configuration before runTest()
I also think we should define which font we use when DRT is run. If you guys help to support above featurers, I'm willing to help your contribution. :-) Cheers, Gyuyoung. ------- Original Message ------- Sender : Dominik R?ttsches<dominik.rottsches@linux.intel.com> Date : 2012-02-24 17:37 (GMT+09:00) Title : Re: [webkit-efl] Update Skipped file of EFL layout test for Ubuntu 11.10 Hello Gyuyoung, as you mentioned in the previous mail: https://lists.webkit.org/pipermail/webkit-efl/2012-February/000133.html On top of Ubuntu, there's a need for quite a number of packages to be installed on top. Also, the version numbers in this list might change as we go forward with development. Wouldn't it make sense to adopt the approach of the GTK port and to augment Ubuntu 11.10 with jhbuild? Also, I am not sure whether the installation/setup of fonts on Ubuntu is a good reference. If you for example enable Korean language support in Ubuntu, it installs additional fonts which may already give different results than a vanilla Ubuntu installation in some cases. There's already a possibility for error. Don't we need to adopt some kind of font-clamping mechanism as in the GTK port of DRT which hard-resets Fontconfig to a defined state before each test? If you let us know, we can work on 1) adopting JHBuild for EFL build procedure 2) creating a defined font configuration before runTest() Regards, Dominik On 02/24/2012 08:54 AM, Gyuyoung Kim wrote:
Hello WebKit EFL folks,
As mentioned in below mail thread, I would like to set Ubuntu 11.10 as reference platform. https://lists.webkit.org/pipermail/webkit-efl/2012-February/000133.html
In order to run layout test on Ubuntu 11.10, we need to update *Skipped* file because layout test exit early when fail count is above 500. IMHO, we need to run layout test as soon as possible because it is more clear to do rebaseline by means of reference platform.
I file a bug for this. https://bugs.webkit.org/show_bug.cgi?id=79440
I got below result by Bug 79440's patch on Ubunt 11.10 and similar result is shown on EFL build bot as well.
=> Results: 19465/28451 tests passed (68.4%) => Tests to be fixed (8986): 239 text diff mismatch ( 2.7%) 21 image mismatch ( 0.2%) 8726 skipped (97.1%) => Tests that will only be fixed if they crash (WONTFIX) (0):
- Gyuyoung. _______________________________________________ webkit-efl mailing list webkit-efl@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-efl
-- Dominik R?ttsches Linux Software Engineer Intel Finland Oy (OTC, SSD)
On 02/24/2012 10:50 AM, Gyuyoung Kim wrote:
Hello Dominik,
Wouldn't it make sense to adopt the approach of the GTK port and to augment Ubuntu 11.10 with jhbuild? Yes, I agree with your suggestion. We also need to have a script like jhbuild to run layout test on same environment. Good, we'll start looking into it and try to provide patches. I think, for the beginning we can work with the same dependencies as the gtk port defines in the jhbuild.modules.
One more reason this will prove useful: While looking into why the LayoutTests/jquery/* ones would fail on my system, I found what I believe is a regression in libsoup: https://bugzilla.gnome.org/show_bug.cgi?id=670733 It's really important to have a defined library environment.
If you let us know, we can work on 1) adopting JHBuild for EFL build procedure 2) creating a defined font configuration before runTest() I also think we should define which font we use when DRT is run. If you guys help to support above featurers, I'm willing to help your contribution. :-)
Yes, we'll start with JHBuild, then look at making font configuration more robust. Dominik
Dominik Röttsches <dominik.rottsches@linux.intel.com> writes:
On 02/24/2012 10:50 AM, Gyuyoung Kim wrote:
If you let us know, we can work on 1) adopting JHBuild for EFL build procedure 2) creating a defined font configuration before runTest() I also think we should define which font we use when DRT is run. If you guys help to support above featurers, I'm willing to help your contribution. :-)
Yes, we'll start with JHBuild, then look at making font configuration more robust.
I thought about JHBuild at the time I was writing the DRT code mainly to try to overcome the font rendering differences we get across distros, but the GTK+ folks had not gone "nuclear" [1] yet and I ended up considering it too extreme a measure. What intrigues me is the distiction being made between points 1 and 2: are you guys thinking of using jhbuild for something else other than making it easier to run the layout tests in different machines? [1] https://lists.webkit.org/pipermail/webkit-gtk/2011-December/000831.html -- Raphael Kubo da Costa ProFUSION embedded systems http://profusion.mobi
Raphael Kubo da Costa <kubo@profusion.mobi> writes:
I thought about JHBuild at the time I was writing the DRT code mainly to try to overcome the font rendering differences we get across distros, but the GTK+ folks had not gone "nuclear" [1] yet and I ended up considering it too extreme a measure.
BTW, is anyone aware of how chromium-linux and Qt deal with this kind of rendering inconsistency? -- Raphael Kubo da Costa ProFUSION embedded systems http://profusion.mobi
are you guys thinking of using jhbuild for something else other than making it easier to run the layout tests in different machines?
I think we need to define which font we use during the layout test first. Then, we are able to start to use jhbuild to run the layout test more easier in different machines. Gyuyoung.
-----Original Message----- From: webkit-efl-bounces@lists.webkit.org [mailto:webkit-efl- bounces@lists.webkit.org] On Behalf Of Raphael Kubo da Costa Sent: Monday, February 27, 2012 8:05 AM To: webkit-efl@lists.webkit.org Subject: Re: [webkit-efl] Update Skipped file of EFL layout test for Ubuntu 11.10
Dominik Röttsches <dominik.rottsches@linux.intel.com> writes:
On 02/24/2012 10:50 AM, Gyuyoung Kim wrote:
If you let us know, we can work on 1) adopting JHBuild for EFL build procedure 2) creating a defined font configuration before runTest() I also think we should define which font we use when DRT is run. If you guys help to support above featurers, I'm willing to help your contribution. :-)
Yes, we'll start with JHBuild, then look at making font configuration more robust.
I thought about JHBuild at the time I was writing the DRT code mainly to try to overcome the font rendering differences we get across distros, but the GTK+ folks had not gone "nuclear" [1] yet and I ended up considering it too extreme a measure.
What intrigues me is the distiction being made between points 1 and 2: are you guys thinking of using jhbuild for something else other than making it easier to run the layout tests in different machines?
[1] https://lists.webkit.org/pipermail/webkit-gtk/2011- December/000831.html
-- Raphael Kubo da Costa ProFUSION embedded systems http://profusion.mobi
_______________________________________________ webkit-efl mailing list webkit-efl@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-efl
Hi Raphael, On 02/27/2012 01:05 AM, Raphael Kubo da Costa wrote:
Dominik Röttsches<dominik.rottsches@linux.intel.com> writes:
On 02/24/2012 10:50 AM, Gyuyoung Kim wrote:
If you let us know, we can work on 1) adopting JHBuild for EFL build procedure 2) creating a defined font configuration before runTest() I also think we should define which font we use when DRT is run. If you guys help to support above featurers, I'm willing to help your contribution. :-) Yes, we'll start with JHBuild, then look at making font configuration more robust. I thought about JHBuild at the time I was writing the DRT code mainly to try to overcome the font rendering differences we get across distros, but the GTK+ folks had not gone "nuclear" [1] yet and I ended up considering it too extreme a measure.
What intrigues me is the distiction being made between points 1 and 2: are you guys thinking of using jhbuild for something else other than making it easier to run the layout tests in different machines?
[1] https://lists.webkit.org/pipermail/webkit-gtk/2011-December/000831.html
No, the intention is indeed to increase consistency of layout test results. In the EFL case, the additional benefit is getting the EFL libraries in consistent versions. The reason why I distinguished 1) & 2) is because in GTK there's additional font-clamping code in DRT resetting FontConfig for every test run and making sure only a configured list of fonts is loaded. It would be interesting to know: Do you think this code becomes redundant once font configuration is controlled by jhbuild? Regards, Dominik -- Dominik Röttsches<dominik.rottsches@linux.intel.com> Linux Software Engineer Intel Finland Oy (OTC, SSD)
participants (3)
-
Dominik Röttsches
-
Gyuyoung Kim
-
Raphael Kubo da Costa