Hi, Thanks for you comments guys. I really appreciate that. I'd like to point out that even if xserver doesn't have regression my fixes still make sense as they wrap code in #ifs depending on the features like 3D_GRAPHICS, ACCELERATED_COMPOSITING, etc. So, they have some value by themselves, not just because they fix --no-tiled-backing-store build. Considering Gyuyoung's comment in the bug about removing coorditaned graphics I'm going to split my patch to several patches just to make them accepted easier. Sorry for the newby question. Any suggestions whom to ask for review? I'm new to this project and it's not clear for me what to do to make my changes landed in the tree faster. Thank you, Ed 2013/3/28 Tiago Vignatti <tiago.vignatti@linux.intel.com>
Xorg 1.13.2 has the proper fix in place. In the ideal world, distros would update for the latest minor version of Xorg and then you would just fetch it in your machine...
Tiago
On 03/28/2013 03:36 AM, Gyuyoung Kim wrote:
Hi,
As I commented on the bug, I think it would be best X server 1.13.0 supports WebKit EFL layout test. However, if it will not support EFL layout test in the near future, it looks we may need to support --no-tiled-backing-store option again. Because I also heard that some WebKit EFL engineers suffered from this issue. But, I still think best is to support X server 1.13.0 on EFL.
Any other opinions?
Gyuyoung.
On Thu, Mar 28, 2013 at 9:06 AM, Ed Bartosh <bartosh@gmail.com <mailto:bartosh@gmail.com>> wrote:
Hi,
I need your suggestions.
I'm trying to fix EFL build with disabled accelerated composition (--no-tiled-backing-store build option). I used this option because of X server 1.13.0 <http://lists.webkit.org/**pipermail/webkit-efl/2012-** November/000434.html<http://lists.webkit.org/pipermail/webkit-efl/2012-November/000434.html>> issue,
mentioned here: http://trac.webkit.org/wiki/**WebKitEFLLayoutTest#**Knownissues<http://trac.webkit.org/wiki/WebKitEFLLayoutTest#Knownissues> I'm trying to build on Ubuntu 12.10, which has X server 1.13.0 with this regression.
It was not that easy to fix this as I suspected as it's required a lot of changes, but it was fun and I learned a bit of WebKit code. You can see some details in this bug: https://bugs.webkit.org/show_**bug.cgi?id=11315<https://bugs.webkit.org/show_bug.cgi?id=11315> <https://bugs.webkit.org/show_**bug.cgi?id=113153<https://bugs.webkit.org/show_bug.cgi?id=113153>
3
Can you please suggest what should I do next? Should I split this patch to several patches or leave it as it is? Whom to ask for review?
Considering the amount of changes was it at all feasible to fix this build or it would be better to simply get rid of --no-tiled-backing-store option?
Thank you, -- BR, Ed
______________________________**_________________ webkit-efl mailing list webkit-efl@lists.webkit.org <mailto:webkit-efl@lists.**webkit.org<webkit-efl@lists.webkit.org>
-- BR, Ed