July 2012 - webkit-efl - lists.webkit.org

API Unit Tests
by Thiago Marcos P. Santos 20 Aug '12

20 Aug '12

Hi WebKit EFL, Thanks to the great work done by Krzysztof at the bug 68509, we have now an API Unit Test Framework for EWK. You can run the tests individually or all tests at once by calling the runner script: $ ./Tools/Scripts/run-efl-tests [--debug|--release] The runner was integrated as a step of the build bots running tests. The only thing missing now is test coverage, and I hope the EFL community can work together at the meta bug tracking the missing tests [1]. I strongly recommend if you are working on a test, to add as dependency to this bug to give visibility to all the developers involved on the task. Another suggestion would be that we do not accept any addition/modification to the APIs if there is no test backing the change. IMO this is aligned to the WebKit best practices and can only bring benefits to the port. [1] https://bugs.webkit.org/show_bug.cgi?id=90451 Cheers!

3 5

Dropping support for the pango network backend.
by ryuan Choi 17 Aug '12

17 Aug '12

Hello, Efl folks. We've supported freetype and pango backend as font backend of webkit-efl. However, pango backend can not render well because of missing features and webkit-efl builds with freetype by default. Does anyone need pango backend? If possible, I will remove font backend selection checks and just use freetype backend with FontPango.cpp for the complex font. Related bug is https://bugs.webkit.org/show_bug.cgi?id=86369 Best Regards, Ryuan Choi

4 8

Re: [webkit-efl] Need to decide coding style for WebKit2 EFL port.
by JongSeok Yang 08 Aug '12

08 Aug '12

2 1

Using 0 or NULL in public C headers documentation ?
by Dumez, Christophe 17 Jul '12

17 Jul '12

Hi, At the moment, we using not consistent in the usage of NULL or 0 in the documentation of our public C headers. The best practice is not currently documented by: http://trac.webkit.org/wiki/EFLWebKitCodingStyle However, Gyuyoung is telling me there is an "unspoken" rule for WebKit-EFL port that we should use 0. I personally disagree and I think we should *always* use NULL in our public C headers. While 0 is advised for null pointers in C++, it is not for C ( http://lwn.net/Articles/93574/) If you look at the EVAS documentation, it is also using NULL in its documentation, not 0. What do other WebKit EFL developers think? We need to agree first, then document it on the coding style page and patch the code accordingly. For example, /** * Gets the Ewk_Settings of this view. * * @param o the view object to get Ewk_Settings * * @return the Ewk_Settings of this view or @c *NULL* on failure */ EAPI Ewk_Settings *ewk_view_settings_get(const Evas_Object *o); Kr, -- Christophe Dumez Linux Software Engineer, PhD Intel Finland Oy - Open Source Technology Center

4 4

Re: [webkit-efl] Using 0 or NULL in public C headers documentation ?
by Gyuyoung Kim 16 Jul '12

16 Jul '12

Hi, As you may know, there is a little document in WebKit. So, it looks EFL port has one of best documentation among other ports. In my opinion, we decide to follow EFL coding style for public APIs because those are used by EFL application. If NULL is C style and EFL style, I think we can use NULL instead of 0. But, if specific bus only start to use it, I think this can make confusion in other bug. So, if we decide to use NULL for API documentation, I think it is better to change this at once. Gyuyoung. ------- Original Message ------- Sender : Dumez, Christophe<christophe.dumez(a)intel.com> Date : 2012-07-16 15:25 (GMT+09:00) Title : Using 0 or NULL in public C headers documentation ? Hi, At the moment, we using not consistent in the usage of NULL or 0 in the documentation of our public C headers. The best practice is not currently documented by: http://trac.webkit.org/wiki/EFLWebKitCodingStyle However, Gyuyoung is telling me there is an "unspoken" rule for WebKit-EFL port that we should use 0. I personally disagree and I think we should *always* use NULL in our public C headers. While 0 is advised for null pointers in C++, it is not for C (http://lwn.net/Articles/93574/) If you look at the EVAS documentation, it is also using NULL in its documentation, not 0. What do other WebKit EFL developers think? We need to agree first, then document it on the coding style page and patch the code accordingly. For example, /** * Gets the Ewk_Settings of this view. * * @param o the view object to get Ewk_Settings * * @return the Ewk_Settings of this view or @c NULL on failure */ EAPI Ewk_Settings *ewk_view_settings_get(const Evas_Object *o); Kr, -- Christophe Dumez Linux Software Engineer, PhD Intel Finland Oy - Open Source Technology Center

2 1

Need to decide coding style for WebKit2 EFL port.
by Gyuyoung Kim 16 Jul '12

16 Jul '12

1 0

efl library dependency bump
by Gyuyoung Kim 04 Jul '12

04 Jul '12

Hello EFL port folks, I would like to bump efl library dependency because there was crash problem in network information APIs. So, the crash bug was fixed by r73025 in EFL community. http://trac.enlightenment.org/e/changeset/73025 I have seen that some bugs also wanna bump efl library version. But, I need to use latest efl version. Could you check if bug below can support your patches ? Bug 90333 <https://bugs.webkit.org/show_bug.cgi?id=90333> - [EFL] Bump version number of EFL libraries (https://bugs.webkit.org/show_bug.cgi?id=90333) Cheers, Gyuyoung

2 2