January 2012 - webkit-efl - lists.webkit.org

Fwd: Fwd: DRT can't be started on EFL.
by Gyuyoung Kim 06 Jan '12

06 Jan '12

1 0

DRT can't be started on EFL.
by Gyuyoung Kim 06 Jan '12

06 Jan '12

1 0

Re: [webkit-efl] Announcement of Coding Style Change in WebKit EFL port
by Gyuyoung Kim 06 Jan '12

06 Jan '12

1 0

Announcement of Coding Style Change in WebKit EFL port
by Gyuyoung Kim 04 Jan '12

04 Jan '12

3 5

Re: [webkit-efl] Announcement of Coding Style Change in WebKit EFL port
by Gyuyoung Kim 03 Jan '12

03 Jan '12

1 0

I'd like to share webkit2 efl patch
by Ryuan Choi 03 Jan '12

03 Jan '12

Hello WebKit/Efl guys, As you may know, I and some collegues are trying to contribute webkit2 EFL port. Unfortunately, we are developing it in a local because of development schedule and it have many internal implementations and test codes. So, I prepared minimum patche for the first drop. This patch is quite immature to review, so we will upstream this ater refining and fixing issues. If you can't wait them, you can test webkit2/efl using this patch and Minibrowser patch ( https://bugs.webkit.org/show_bug.cgi?id=61850 ) Master bug of webkit2/efl : https://bugs.webkit.org/show_bug.cgi?id=61838 Best Regards, Ryuan Choi

1 0

Re: [webkit-efl] [webkit-dev] Announcement of Coding Style Change in WebKit EFL port
by David Levin 02 Jan '12

02 Jan '12

Feel free to patch the style checker as appropriate. I suspect there may be some changes needed here: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/style/checker.p… Best wishes, dave On Tue, Dec 27, 2011 at 11:54 PM, Gyuyoung Kim <gyuyoung.kim(a)samsung.com>wrote: > Hello WebKit folks, > > > As you may know, I have changed the coding style of EFL port via Bug > 68209. This is to eliminate unnecessary difficulties > > that reviewers have experienced when they review EFL bugs, due to EFL > specific coding style. > > > > Bug 68209 - [EFL] Change WebKit EFL coding style > > (https://bugs.webkit.org/show_bug.cgi?id=68209) > > > > Major changes are as below, > > > > 1. Use full variable name instead of abbreviation name. > > 2. Use standard boolean type instead of EFL boolean type. > > 3. Place '*' operator immediately after the data type. (For example, use > char* userAgent. instead of char *userAgent.) > > 4. Use C++ type casting instead of C type casting. > > 5. Remove void parameter from internal functions. > > 6. Use camelCase instead of underbar(_) in variable names. > > > > I made a wiki page for this rule. I will update this page whenever EFL > port coding style guide is changed. > > (http://trac.webkit.org/wiki/EFLWebKitCodingStyle) > > > > To sum up, EFL port adheres to WebKit coding style except for public > header from now. > > (Because public header is used by EFL applications, public header will > continue to follow the coding style rule of EFL.) > > > > We hope that reviewing of EFL port patches will be much easier after this > change. > > > > Happy new year !! > > > > Regards, > > Gyuyoung Kim. > > _______________________________________________ > webkit-dev mailing list > webkit-dev(a)lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >

2 1

Re: [webkit-efl] RFC: Changes to the ewk_settings_cache_* API
by Ryuan Choi 01 Jan '12

01 Jan '12

I like what you want. I have one minor points for the renaming. IMO, ewk_view_setting_offline_app_cache_{get,set} also should be considered. Best Regards, Ryuan Choi ------- Original Message ------- Sender : Raphael Kubo da Costa<kubo(a)profusion.mobi> Date : 2011-11-08 01:17 (GMT+09:00) Title : [webkit-efl] RFC: Changes to the ewk_settings_cache_* API The ewk_settings_cache_* family of functions is quite messy right now. Some calls deal with Offline Web Applications (ewk_settings_cache_directory_path_{get,set}) and others deal with in-memory cache settings (ewk_settings_cache_enable_{get,set} and ewk_settings_cache_capacity_set). I see the following issues with the current situation: 1) Offline Web Applications are completely unrelated to the in-memory cache. The former handles the appcache part of the HTML5 spec, wheareas the latter just caches stylesheets, images and scripts in memory. Yet they both share the same function prefix. The current apidox also does not help at all (the term "offline web applications" is not even mentioned). 2) The exposed API to control the memory cache is redundant and insufficient. - It is insufficient because one cannot pass all parameters accepted by MemoryCache::setCapacities(). It also does not clear other in-memory caches, such as the page and the font caches. - It is redundant because if the user could specify all the parameters accepted by MemoryCache::setCapacities() there would be no need to have the getter and setter for MemoryCache::disabled(). Please tell me what you think of the following proposal: - Rename ewk_settings_cache_directory_path_{get,set} to ewk_settings_offline_web_applications_cache_directory_{get,set}. - Follow more closely what the Qt API does and have: - ewk_settings_cache_clear(Ewk_Cache_Clear_Mode mode) Ewk_Cache_Clear_Mode is an enum which currently has only one value: enum Ewk_Cache_Clear_Mode { EWK_CACHE_CLEAR_MODE_MEMORY_CACHE }; This one clears the memory cache, the page cache, the font cache and the cross-origin preflight cache, like Qt does. Once we have the necessary code to have a network disk-cache, we can add another item to the enum to make it possible to clear it as well. - ewk_settings_object_cache_capacity_set(minDeadBytes, maxDeadBytes, totalBytes) Pass the received parameters to MemoryCache::setCapacities(). If they are all 0, disable the in-memory object cache. -- Raphael Kubo da Costa ProFUSION embedded systems http://profusion.mobi _______________________________________________ webkit-efl mailing list webkit-efl(a)lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-efl

2 2