September 2011 - webkit-efl - lists.webkit.org

Proposal of WebKit-EFL unit tests
by Krzysztof Czech 21 Sep '11

21 Sep '11

Hello All, I have added today patches with implementation of unit testing framework for WebKit-EFL port. Generally framework based on google's gtest which is already used by some ports in WebKit. Patches numbers are: 68509, 68510, 68511. I would be glad to hear your opinion about it. Regards Krzysztof

1 0

Re: [webkit-efl] HEADS-UP: webkit-efl to require cairo 1.10
by Ryuan Choi 16 Sep '11

16 Sep '11

> WRT the changes in FindCairo.cmake: > > * The libfind_pkg_check_modules macro only accepts 2 parameters. Sorry, It's my mistake. > * You can experiment with the FindPackageHandleStandardArgs module > (which also offers other benefits) to avoid writing the version > message manually. A simple example can be found in [1]. > > [1] https://projects.kde.org/projects/kde/kdelibs/repository/revisions/master/e… I agree. But I can't use FindPackageHandleStandardArgs for version error.( I can't open above url. So I referenced FindXXX.cmake in cmake-2.8/Modules/ ) Attached file is different approach. IMO, libfind_pkg_check_modules should be smarter. Best Regards Ryuan Choi.

2 1

Coding style issue in EFL port
by Gyuyoung Kim 16 Sep '11

16 Sep '11

Hello all, As you may know, ewk files are .cpp files, except for two files(ewk_tiled_matrix.c and ewk_tiled_model.c). It means we have to use C++ coding style in .cpp files. However, it looks efl ports are using mixed C and C++ coding style. I think we need to use C++ coding style in efl port except for public APIs. In addition, if port implementation is compiled by C++ compiler, reviewers prefer to use C++ coding style for port implementation, except for platform specific implementation. If nobody oppose my opinion, I'd like to file bugs for this issue, then I prepare patches for that bugs. Because I have lots of interests in coding style since before. In Bug 67705, Kubo suggested that it is better to fix this problem together when other bugs are reviewed. But, I heared that reviewers are concerning this problem now. So, I would like to fix this issue as soon as possible. Furthermore, demarchi already suggested we should use C++ coding style in our implementation. https://bugs.webkit.org/show_bug.cgi?id=67705 Though there are many difficulties, IMHO, we need to use *class* for port implementation like qt port eventually. - Gyuyoung

3 5

Re: [webkit-efl] HEADS-UP: webkit-efl to require cairo 1.10
by Raphael Kubo da Costa 16 Sep '11

16 Sep '11

On Thu, Sep 15, 2011 at 9:28 PM, Ryuan Choi <ryuan.choi(a)samsung.com> wrote: >> Actually, I'm not sure there's going to be someone here to commit this > tomorrow, but this is going to happen no sooner than the beginning of > next week. > > I prepared patch. > I'll create bug within today after internal review. WRT the changes in FindCairo.cmake: * The libfind_pkg_check_modules macro only accepts 2 parameters. * You can experiment with the FindPackageHandleStandardArgs module (which also offers other benefits) to avoid writing the version message manually. A simple example can be found in [1]. [1] https://projects.kde.org/projects/kde/kdelibs/repository/revisions/master/e… -- Raphael Kubo da Costa ProFUSION embedded systems http://profusion.mobi

1 0

Re: [webkit-efl] HEADS-UP: webkit-efl to require cairo 1.10
by Ryuan Choi 16 Sep '11

16 Sep '11

> Actually, I'm not sure there's going to be someone here to commit this tomorrow, but this is going to happen no sooner than the beginning of next week. I prepared patch. I'll create bug within today after internal review. Best Regards, Ryuan Choi

2 1

HEADS-UP: webkit-efl to require cairo 1.10
by Raphael Kubo da Costa 15 Sep '11

15 Sep '11

Hello there, Right now the minimum Cairo version we require at build-time is 1.6. The last 1.6 release, 1.6.4, happened in April of 2008. Since r94876, we cannot build with Cairo < 1.10 due to some data structures and functions which were introduced in this release. Since 1.10 was released more than one year ago and the GTK+ also requires it as a minimum version, we are going to bump the version requirement in Source/cmake/OptionsEfl.cmake soon (as in 'between now and tomorrow'). -- Raphael Kubo da Costa ProFUSION embedded systems http://profusion.mobi

1 1