September 2011 - webkit-efl - lists.webkit.org

Re: [webkit-efl] I want to change *.c to *.cpp
by Ryuan Choi 24 Sep '11

24 Sep '11

> > Do you really need the extern "C" declarations in the headers? This code > will only be used by C++ files. > Yes, I need it. > If not, it makes linking errors. I realize that this is because ewk_tiled_backing_store declare extern "C". I removed. > > > > > And I dislike using typeof here, as it will really break the build for > > anything that is not gcc or clang. I suggest getting rid of the macros > > (you could even turn them into proper template functions) or passing > > another parameter to them specifying the data type. > > I agree, I'll remove those macro. > I thought that I'll prepare next bug for this bug to be focused renaming. Update like you mentioned. please see attached file. > > > Or, taking another step back, is this all really needed? We are have to > > make so many adjustments to make code which is clearly C code into an > > uglified C++ version, and IIRC the reason given for that was some kind > > of #include problem. Couldn't we fix that instead of spending so much > > effort into this? > > Previous bug is for #include problem. so that I didn't touch other c files. > But now, we are in phase to improve WebKit/efl code quality. > > Because we need to change our tiled backing store until we decide whether we use WebCore version, > We need reviewer's help and these cleanup will help them review easily.

1 0

Re: [webkit-efl] I want to change *.c to *.cpp
by 최병운 24 Sep '11

24 Sep '11

> Do you really need the extern "C" declarations in the headers? This code > will only be used by C++ files. Yes, I need it. If not, it makes linking errors. > > And I dislike using typeof here, as it will really break the build for > anything that is not gcc or clang. I suggest getting rid of the macros > (you could even turn them into proper template functions) or passing > another parameter to them specifying the data type. I agree, I'll remove those macro. I thought that I'll prepare next bug for this bug to be focused renaming. > Or, taking another step back, is this all really needed? We are have to > make so many adjustments to make code which is clearly C code into an > uglified C++ version, and IIRC the reason given for that was some kind > of #include problem. Couldn't we fix that instead of spending so much > effort into this? Previous bug is for #include problem. so that I didn't touch other c files. But now, we are in phase to improve WebKit/efl code quality. Because we need to change our tiled backing store until we decide whether we use WebCore version, We need review's help and these cleanup will help them review easily. Best Regards, Ryuan Choi

1 0

Re: [webkit-efl] I want to change *.c to *.cpp
by Ryuan Choi 24 Sep '11

24 Sep '11

> > Ok, committed in r63568 of EFL. Thank you. Attached file is simple diff after renaming for easy review. If there are no objection, I'll create a patch Best Regards, Ryuan Choi

2 2

Re: [webkit-efl] I want to change *.c to *.cpp
by Lucas De Marchi 23 Sep '11

23 Sep '11

Hi Ryuan On Fri, Sep 23, 2011 at 6:51 AM, Ryuan Choi <ryuan.choi(a)samsung.com> wrote: > >> I thought you would change all *.c and not just ewk_view_single.c and >> ewk_view_tiled.c. > > I'd like to share patch to fix above issue. > Now I'm waiting internal review for it. > > There are build break issues, so that I tried to not only rename but also fix breaks, pointer operator and cast. > > BTW, I realize that EINA_INLIST_FOREACH make build break with cpp. > For now, I redefine EINA_INLIST_FOREACH. > Should we need to fix it? Damn C++ that doesn't allow the conversion from void* to type*. We have some options: 1) Use "-fpermissive" flag and live with the warning (there doesn't seem to be an option to turn it off in gcc). 2) Patch eina to provide a c++ version of the macro. This would mean using typeof() though, which is a gcc feature. Looking at how it's implemented, it would be very simple, just casting to typeof(ptr) instead of to void*. 3) Use a different version of the macro in WebKit, like you did. 4) Don't do this conversion from c to c++. Ryuan, was this the only issue of converting from C to C++? I like option 2. I made a simple patch to eina that fixes it if we are using C++, but I didn't committed it yet. I'd like to hear opinions from others. regards, Lucas De Marchi

1 1

Fwd: Re: Re: Re: I want to change *.c to *.cpp
by Ryuan Choi 23 Sep '11

23 Sep '11

> I thought you would change all *.c and not just ewk_view_single.c and > ewk_view_tiled.c. I'd like to share patch to fix above issue. Now I'm waiting internal review for it. There are build break issues, so that I tried to not only rename but also fix breaks, pointer operator and cast. BTW, I realize that EINA_INLIST_FOREACH make build break with cpp. For now, I redefine EINA_INLIST_FOREACH. Should we need to fix it? Best Regards, Ryuan Choi

1 0

Change C-casting with C++ casting
by Gyuyoung Kim 22 Sep '11

22 Sep '11

Hello Lucas, Thank you for your patch on Bug 68231. I think patch owner is going to submit new patch based on latest WebKit again. BTW, I think our next item is to replace C-casting with C++ casting in .cpp files. (https://bugs.webkit.org/show_bug.cgi?id=68321) I wonder if your script can change them automatically. If your script can do it, I think it is better to use it. But, it can't do that, I'd like to get a review for attached patch. Gyuyoung Kim

2 2

[HEADS-UP] Patches probably broken
by Lucas De Marchi 21 Sep '11

21 Sep '11

Hey, As part of the coding-style cleanup task I landed today a patch to change "type *ptr" to "type* ptr". This probably broke a great part of the patches pending on bugzilla. If you care about them, please make sure to check if they still apply to tot. Sorry for this, but it was necessary. If a patch is not updated and it doesn't apply anymore, probably no one cares and we should close the bug, right? So, make sure to update the patches on bugzilla if you want them to be eventually applied. In other words, don't wait the commit bot saying your patch could not be applied anymore, ok? regards, Lucas De Marchi

1 0

Re: [webkit-efl] I want to change *.c to *.cpp
by Ryuan Choi 21 Sep '11

21 Sep '11

> I thought you would change all *.c and not just ewk_view_single.c and > ewk_view_tiled.c. Sure, I'll create new bug for them. Regards, Ryuan Choi

1 0

Re: [webkit-efl] I want to change *.c to *.cpp
by Ryuan Choi 21 Sep '11

21 Sep '11

> On Mon, Aug 15, 2011 at 11:23 PM, Ryuan Choi wrote: > > Hello, WebKit/EFL guys. > > > > Could anyone know why we use *.c like ewk_view_single.c and ewk_view_tiled.c? > > Did you create a bug report for this? > > Lucas De Marchi It was already merged. ( https://bugs.webkit.org/show_bug.cgi?id=66542 ) Anyway, we should change other c files to cpp. Thanks. +------------------------------------------------------------------------ Listen and listen and listen -----------------------+

2 1

I want to change *.c to *.cpp
by Ryuan Choi 21 Sep '11

21 Sep '11

Hello, WebKit/EFL guys. Could anyone know why we use *.c like ewk_view_single.c and ewk_view_tiled.c? Although EFL is based on C, but WebKit is not. If we don't have any reason, I think that we reconcile extensions to remove warning and clear APIs.

3 2