July 2011 - webkit-efl - lists.webkit.org

Issues from static program analysis tool(s)
by Kangil Han 28 Jul '11

28 Jul '11

Dear EFL developers, I am writing this to hear your voices on the issues from static program analysis tool. 'Coverity Static Analysis' can be a tool of those. For example, lately I've got a below report. There should be null check for 'o' in 'EWK_VIEW_SD_GET(o, ptr)' macro. This is the whole source code for this macro. #define EWK_VIEW_SD_GET(o, ptr) \ Ewk_View_Smart_Data* ptr = (Ewk_View_Smart_Data*)evas_object_smart_data_get(o) If we only look at this macro, report seems clear. But, when it comes to look at 'evas_object_smart_data_get' function, this point is not so clear. This is because 'evas_object_smart_data_get' function can handle NULL argument of 'o'. However, if we should have strict view in programming, this report makes sense. I am looking forward to hearing your opinion on handling this kind of stuff. Thanks and regards, Kangil

2 3

C Dom Bindings Announcement
by Piotrek Roguski 27 Jul '11

27 Jul '11

Hello, Right now I'm working on C API for DOM Bindings which I would like to contribute to EFL port. Few informations about implementation: - DOM Objects will be represented as instances of structures containing pointers to WebCore objects, - inheritance represented as inclusion, - implementation will be mainly generated by code generator similar to GObject, CPP, ObjC ones etc. Contribution will include code generator, some custom implementations, API for acquiring access to those bindings and of course changes in CMake files. I'm looking forward your comments, best regards, Piotrek Roguski

1 0

Unit Tests for the EFL port
by Krzysztof Czech 19 Jul '11

19 Jul '11

Hello, I' am working on an implementation of unit tests for the EFL port. I think, having such a functionality will help us to produce a better code. There are of course other reasons. I am using google c++ testing framework, I have noticed one is used by other ports as well and it's used to test WebKit API. Framework is very simple to use, sources can be found in the WebKit tree (ThirdParty folder). Regards Krzysztof Czech

1 0

Re: [webkit-efl] Question related to API comment location.
by Grzegorz Czajkowski 15 Jul '11

15 Jul '11

Hi Ryuan, I think we need to move documentation to the header files first, without any modification of current one. Of course your proposition is worth the effort. We can prepare another patch for this. Regards Grzegorz From: Ryuan Choi [mailto:ryuan.choi@samsung.com] Sent: 15 July 2011 13:22 To: g.czajkowski(a)samsung.com Cc: webkit-efl(a)lists.webkit.org Subject: Re: Re: [webkit-efl] Question related to API comment location. Hello, grzegorz A few minutes ago, I discussed somthing about doxygen with kangil han. He want @file, @brief in header files to prepare doxygen document. How do you think about adding doxygen attributes ( '@file', '@brief') when you prepared patch you mentioned. Regards, Ryuan Choi ------- Original Message ------- Sender : Grzegorz Czajkowski<g.czajkowski(a)samsung.com> Junior Software Engineer/Poland R&D Center-Linux (MSD)/삼성전자 Date : 2011-07-15 15:26 (GMT+09:00) Title : Re: [webkit-efl] Question related to API comment location. Hello, I am preparing a patch which moves API documentation from cpp to the header files. Is there a chance for review that huge patch? Or do you prefer smaller patches? Regards Grzegorz -----Original Message----- From: webkit-efl-bounces(a)lists.webkit.org [mailto:webkit-efl-bounces@lists.webkit.org] On Behalf Of Gyuyoung Kim Sent: 13 July 2011 10:25 To: 'Łukasz Ślachciak' Cc: webkit-efl(a)lists.webkit.org Subject: Re: [webkit-efl] Question related to API comment location. Hello Lukasz, Thank you for your kindly reply. I also think API description in .h files has more advantages. If nobody prepares patches for this, I'm going to file a bug. - Gyuyoung > -----Original Message----- > From: webkit-efl-bounces(a)lists.webkit.org [mailto:webkit-efl- > bounces(a)lists.webkit.org] On Behalf Of Łukasz ?lachciak > Sent: Wednesday, July 13, 2011 5:01 PM > To: webkit-efl(a)lists.webkit.org > Subject: Re: [webkit-efl] Question related to API comment location. > > > > Hello Gyuyoung > > We were discussing this in June on webkit-dev but in more broad > approach. See Grzegorz proposition here: > https://lists.webkit.org/pipermail/webkit-dev/2011-June/thread.html#17246 > > There are two arguments of keeping documentation in cpp files: > 1) when developer is working on function code he will not forget about > updating documentation which is just in front of his eyes > 2) changing header file causes more cpp files to be rebuild what makes > building time longer > > Argument 2) in my opinion is not important in current times. > Argument 1) is important but I think that advantages of keeping doc in > .h file are more important: > > 1) dev packages with .h files will contain description so developers > using webkit-efl-dev package don't need to check source code of cpp > files when they want to know how to use given API > > 2) doxygen can generate documentation just using webkit-ef-dev package > so there will be no need to have WebKit sources > > 3) it will be consistent with structures descriptions > > Summing up: > Let's do this > > Regards > > Lukasz Slachciak > > On 07/13/2011 04:32 AM, Gyuyoung Kim wrote: > > Hello, > > > > I wonder why API's description is added to .cpp files. > > > > For example, in ewk_view.cpp, > > > > /** > > * Sets the spatial navigation. > > * > > * @param o view object to set spatial navigation setting. > > * @return @c EINA_TRUE on success and @c EINA_FALSE on failure > > */ > > Eina_Bool ewk_view_setting_spatial_navigation_set(Evas_Object* o, > Eina_Bool > > enable) > > { > > EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE); > > EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE); > > ... > > } > > > > In contrast, type definition's description are put on .h files. > > > > /** > > * Cache (pool) that contains unused tiles for ewk_view_tiled. > > * > > * This cache will maintain unused tiles and flush them when the total > > * memory exceeds the set amount when > > * ewk_tile_unused_cache_auto_flush() or explicitly set value when > > * ewk_tile_unused_cache_flush() is called. > > * > > * The tile may be shared among different ewk_view_tiled instances to > > * group maximum unused memory resident in the system. > > */ > > typedef struct _Ewk_Tile_Unused_Cache Ewk_Tile_Unused_Cache; > > > > > > It looks there are no consistency for API description. > > > > IMO, it is better to move all descriptions to .h files. Because, > application > > developers > > can refer to the usage of API through header files. If efl developers > agree > > with my suggestion, > > I'd like to move all descriptions to header files. > > > > - Gyuyoung > > > > > > > > _______________________________________________ > > webkit-efl mailing list > > webkit-efl(a)lists.webkit.org > > http://lists.webkit.org/mailman/listinfo.cgi/webkit-efl > > > > _______________________________________________ > webkit-efl mailing list > webkit-efl(a)lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-efl _______________________________________________ webkit-efl mailing list webkit-efl(a)lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-efl _______________________________________________ webkit-efl mailing list webkit-efl(a)lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-efl

1 0

Re: [webkit-efl] Question related to API comment location.
by Ryuan Choi 15 Jul '11

15 Jul '11

1 0

Question related to API comment location.
by Gyuyoung Kim 15 Jul '11

15 Jul '11

Hello, I wonder why API's description is added to .cpp files. For example, in ewk_view.cpp, /** * Sets the spatial navigation. * * @param o view object to set spatial navigation setting. * @return @c EINA_TRUE on success and @c EINA_FALSE on failure */ Eina_Bool ewk_view_setting_spatial_navigation_set(Evas_Object* o, Eina_Bool enable) { EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE); EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE); ... } In contrast, type definition's description are put on .h files. /** * Cache (pool) that contains unused tiles for ewk_view_tiled. * * This cache will maintain unused tiles and flush them when the total * memory exceeds the set amount when * ewk_tile_unused_cache_auto_flush() or explicitly set value when * ewk_tile_unused_cache_flush() is called. * * The tile may be shared among different ewk_view_tiled instances to * group maximum unused memory resident in the system. */ typedef struct _Ewk_Tile_Unused_Cache Ewk_Tile_Unused_Cache; It looks there are no consistency for API description. IMO, it is better to move all descriptions to .h files. Because, application developers can refer to the usage of API through header files. If efl developers agree with my suggestion, I'd like to move all descriptions to header files. - Gyuyoung

3 3

Re: [webkit-efl] Remove dirty flag and ewk_tile_unused_cache_dirty
by JungJik Lee 14 Jul '11

14 Jul '11

Dear Raphael Kubo da Costa, Thank you for reading, I will report a bug which is for removing the dirty flag and the function tonight. JungJik Lee

1 0

Remove dirty flag and ewk_tile_unused_cache_dirty
by JungJik Lee 13 Jul '11

13 Jul '11

2 1

The list is now accessible via Gmane too
by Raphael Kubo da Costa 13 Jul '11

13 Jul '11

Hey there, For those of you who prefer to follow mailing lists with a newsreader, the webkit-efl list is now tracked by Gmane as well, so you can point your newsreader to nntp://news.gmane.org and choose the gmane.os.opendarwin.webkit.efl group. As a side-effect, the list is now archived by mail-archive.com too. It has started tracking messages from July 12th, but we can import the previous messages as well (I need to talk to Gyuyoung about that). Cheers, -- Raphael Kubo da Costa ProFUSION embedded systems http://profusion.mobi

1 0

Re: [webkit-efl] Scope of 'ewk_util.h'
by Kangil Han 13 Jul '11

13 Jul '11

Dear Gyuyoung, Sure, I will make a patch. Thanks and regards, Kangil ------- Original Message ------- Sender : 김규영<gyuyoung.kim(a)samsung.com> E4(선임)/선임/S/W Platform Lab(DMC연)/삼성전자 Date : 2011-07-13 09:40 (GMT+09:00) Title : RE: [webkit-efl] Scope of 'ewk_util.h' Hello Rafael, Long time no see. How are you? :-) I understand role of the function. I also think we don't need to add the ewk_util.h to EWebKit_HEADERS yet. IMO, we can add it to EWebkit_HEADER again when we need to open the function. Kangil, Could you make a patch for this ? You can remove it from Source/WebKit/efl/CMakeListEfl.txt. Please make reference to the file. 217 FILE(GLOB EWebKit_HEADERS "${CMAKE_CURRENT_SOURCE_DIR}/efl/ewk/*.h") 218 LIST(REMOVE_ITEM EWebKit_HEADERS "${CMAKE_CURRENT_SOURCE_DIR}/efl/ewk/ewk_private.h") 219 LIST(REMOVE_ITEM EWebKit_HEADERS "${CMAKE_CURRENT_SOURCE_DIR}/efl/ewk/ewk_tiled_private.h") 220 LIST(REMOVE_ITEM EWebKit_HEADERS "${CMAKE_CURRENT_SOURCE_DIR}/efl/ewk/ewk_tiled_backing_store.h") 221 LIST(REMOVE_ITEM EWebKit_HEADERS "${CMAKE_CURRENT_SOURCE_DIR}/efl/ewk/ewk_tiled_matrix.h") 222 LIST(REMOVE_ITEM EWebKit_HEADERS "${CMAKE_CURRENT_SOURCE_DIR}/efl/ewk/ewk_tiled_model.h") - Gyuyoung > -----Original Message----- > From: Rafael Antognolli [mailto:antognolli@profusion.mobi] > Sent: Tuesday, July 12, 2011 10:12 PM > To: Gyuyoung Kim > Cc: ryuan.choi(a)samsung.com; 한강일; webkit-efl(a)lists.webkit.org > Subject: Re: [webkit-efl] Scope of 'ewk_util.h' > > Hello Gyuyoung and Ryuan! > > Long time no see! :-) > > On Tue, Jul 12, 2011 at 4:05 AM, Gyuyoung Kim <gyuyoung.kim(a)samsung.com> > wrote: > > It looks role of “ewk_util_image_from_cairo_surface_add()” APIs is to > get > > image from cairo surface. > > I also don’t know why the APIs was created. I think Profusion guys may > know > > the reason. > > The reason is that ewk_history.cpp and ewk_settings.cpp use this > function to create an Evas_Object of type image from the cairo > surface. This is useful when creating a thumbnail, or an icon for that > page. Look for this function on these files and you will understand. > > > Anyway, I think we don’t need to open ewk_util.h unless ewk_util has > > valuable APIs. > > I agree. > > > - Gyuyoung > > > > From: webkit-efl-bounces(a)lists.webkit.org > > [mailto:webkit-efl-bounces@lists.webkit.org] On Behalf Of Ryuan Choi > > Sent: Tuesday, July 12, 2011 4:00 PM > > To: 한강일 > > Cc: webkit-efl(a)lists.webkit.org > > Subject: Re: [webkit-efl] Scope of 'ewk_util.h' > > > > > > > >> Otherwise, ‘EAPI’ should be added in front of return type. > > > > > > > > ewk_util.h is not public now. > > > > I saw bugs to enable it as public, but I am not sure. > > > > > > > > Does we have any reasons to make EAPI? > > > > IMO, we'd better to remove it from EWebKit_HEADERS. > > Not sure now why this file is in EWebKit_HEADERS but I think removing > it from there is probably a good idea. > > Regards, > -- > Rafael Antognolli > ProFUSION embedded systems > http://profusion.mobi <p> </p><p> </p>

1 0