Deprecate webkit_web_page_get_main_frame?
In https://github.com/WebKit/WebKit/pull/30763 I’m deprecating injected bundle frame access interfaces as part of the site isolation development. Would glib API maintainers be willing to deprecate webkit_web_page_get_main_frame to discourage its adoption and indicate plans to remove it at some point in the future? I’ve kept the functionality for now because we are still moving off it, but at some point that will be complete and it would be nice to remove bundle frame access together.
Hi Alex, sorry for the delay to reply, I was on vacation last week. So, we mainly use the frame object to get its javascript context, so what's the plan for that? I mean, it's only the api to get the main frame what's going to be deprecated or the frame object entirely? In most of the cases we get the frame from the script world on the window- object-cleared event, so we can probably deprecate get_main_frame(). I think it's only used in epiphany and evolution, but I would need to check how it's used there. El vie, 12-07-2024 a las 16:19 -0600, Alex Christensen via webkit-dev escribió:
In https://github.com/WebKit/WebKit/pull/30763 I’m deprecating injected bundle frame access interfaces as part of the site isolation development. Would glib API maintainers be willing to deprecate webkit_web_page_get_main_frame to discourage its adoption and indicate plans to remove it at some point in the future? I’ve kept the functionality for now because we are still moving off it, but at some point that will be complete and it would be nice to remove bundle frame access together. _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
-- Carlos Garcia Campos
We definitely have a lot of work to do, but the plan is to make UI process driven replacements for all uses of the injected bundle. It’s a large problem without a currently completely known solution, but we’re working on it and welcome collaboration from people working on webkit-based browsers on other platforms. I’m pushing to deprecate things to discourage further adoption of things we are planning to remove, even before we have a complete replacement plan.
On Jul 22, 2024, at 4:31 AM, Carlos Garcia Campos via webkit-dev <webkit-dev@lists.webkit.org> wrote:
Hi Alex,
sorry for the delay to reply, I was on vacation last week.
So, we mainly use the frame object to get its javascript context, so what's the plan for that? I mean, it's only the api to get the main frame what's going to be deprecated or the frame object entirely? In most of the cases we get the frame from the script world on the window- object-cleared event, so we can probably deprecate get_main_frame(). I think it's only used in epiphany and evolution, but I would need to check how it's used there.
El vie, 12-07-2024 a las 16:19 -0600, Alex Christensen via webkit-dev escribió:
In https://github.com/WebKit/WebKit/pull/30763 I’m deprecating injected bundle frame access interfaces as part of the site isolation development. Would glib API maintainers be willing to deprecate webkit_web_page_get_main_frame to discourage its adoption and indicate plans to remove it at some point in the future? I’ve kept the functionality for now because we are still moving off it, but at some point that will be complete and it would be nice to remove bundle frame access together. _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
-- Carlos Garcia Campos _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
On Tue, Jul 23 2024 at 12:51:36 PM -06:00:00, Alex Christensen via webkit-dev <webkit-dev@lists.webkit.org> wrote:
We definitely have a lot of work to do
Yes, this seems tough. I wonder if we could introduce something like WebKitWebPageProxy and WebKitFrameProxy to replace WebKitWebPage and WebKitFrame....
El mar, 23-07-2024 a las 12:51 -0600, Alex Christensen escribió:
We definitely have a lot of work to do, but the plan is to make UI process driven replacements for all uses of the injected bundle. It’s a large problem without a currently completely known solution, but we’re working on it and welcome collaboration from people working on webkit-based browsers on other platforms. I’m pushing to deprecate things to discourage further adoption of things we are planning to remove, even before we have a complete replacement plan.
Ok, sounds good to me. We are of course happy to collaborate on this, so count on us for whatever we can do to help.
On Jul 22, 2024, at 4:31 AM, Carlos Garcia Campos via webkit-dev <webkit-dev@lists.webkit.org> wrote:
Hi Alex,
sorry for the delay to reply, I was on vacation last week.
So, we mainly use the frame object to get its javascript context, so what's the plan for that? I mean, it's only the api to get the main frame what's going to be deprecated or the frame object entirely? In most of the cases we get the frame from the script world on the window- object-cleared event, so we can probably deprecate get_main_frame(). I think it's only used in epiphany and evolution, but I would need to check how it's used there.
El vie, 12-07-2024 a las 16:19 -0600, Alex Christensen via webkit- dev escribió:
In https://github.com/WebKit/WebKit/pull/30763 I’m deprecating injected bundle frame access interfaces as part of the site isolation development. Would glib API maintainers be willing to deprecate webkit_web_page_get_main_frame to discourage its adoption and indicate plans to remove it at some point in the future? I’ve kept the functionality for now because we are still moving off it, but at some point that will be complete and it would be nice to remove bundle frame access together. _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
-- Carlos Garcia Campos _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
-- Carlos Garcia Campos
participants (3)
-
Alex Christensen
-
Carlos Garcia Campos
-
Michael Catanzaro