I am embarking on a journey to reduce the number of global variables and singletons we use instead member variables on the proper objects. Feel free to join! Specifically, I’m looking into reducing the number of members in the NetworkProcessCreationParameters structure. Many of them need to go to NetworkSessionCreationParameters instead. Could those maintaining the libsoup and libcurl networking implementations please lend a hand and move the members enclosed in USE(SOUP) or USE(CURL)? I have done similar moves in https://trac.webkit.org/changeset/238654/webkit and https://trac.webkit.org/changeset/238630/webkit if you would like a pattern to follow.
On Thu, 2018-11-29 at 18:15 -0800, Alex Christensen wrote:
I am embarking on a journey to reduce the number of global variables and singletons we use instead member variables on the proper objects. Feel free to join!
Specifically, I’m looking into reducing the number of members in the NetworkProcessCreationParameters structure. Many of them need to go to NetworkSessionCreationParameters instead. Could those maintaining the libsoup and libcurl networking implementations please lend a hand and move the members enclosed in USE(SOUP) or USE(CURL)? I have done similar moves in https://trac.webkit.org/changeset/238654/webkit and https://trac.webkit.org/changeset/238630/webkit if you would like a pattern to follow.
Thanks for the reference. I'll have a look at the libsoup members whenever I have some time. Claudio
Alex, Got it. Curl port will catch up this move soon. I just want to confirm my understanding about Network Session. It is pretty similar concept with Cocoa's URLSession, isn't it? Curl Port uses default NetworkSession at everywhere so that it is almost same with global NetworkProcess. We need to move forward to support NetworkSession correctly. ----- Basuke Suzuki SONY PlayStation
-----Original Message----- From: webkit-dev <webkit-dev-bounces@lists.webkit.org> On Behalf Of Alex Christensen Sent: Thursday, November 29, 2018 6:15 PM To: Webkit Development List <webkit-dev@lists.webkit.org> Subject: [webkit-dev] Reducing globals
I am embarking on a journey to reduce the number of global variables and singletons we use instead member variables on the proper objects. Feel free to join!
Specifically, I’m looking into reducing the number of members in the NetworkProcessCreationParameters structure. Many of them need to go to NetworkSessionCreationParameters instead. Could those maintaining the libsoup and libcurl networking implementations please lend a hand and move the members enclosed in USE(SOUP) or USE(CURL)? I have done similar moves in https://trac.webkit.org/changeset/238654/webkit and https://trac.webkit.org/changeset/238630/webkit if you would like a pattern to follow. _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
On Dec 3, 2018, at 12:55 PM, Basuke.Suzuki@sony.com wrote:
Alex,
Got it. Curl port will catch up this move soon. Great! Thanks!
I just want to confirm my understanding about Network Session. It is pretty similar concept with Cocoa's URLSession, isn't it? It tries.
Curl Port uses default NetworkSession at everywhere so that it is almost same with global NetworkProcess. We need to move forward to support NetworkSession correctly.
----- Basuke Suzuki SONY PlayStation
-----Original Message----- From: webkit-dev <webkit-dev-bounces@lists.webkit.org> On Behalf Of Alex Christensen Sent: Thursday, November 29, 2018 6:15 PM To: Webkit Development List <webkit-dev@lists.webkit.org> Subject: [webkit-dev] Reducing globals
I am embarking on a journey to reduce the number of global variables and singletons we use instead member variables on the proper objects. Feel free to join!
Specifically, I’m looking into reducing the number of members in the NetworkProcessCreationParameters structure. Many of them need to go to NetworkSessionCreationParameters instead. Could those maintaining the libsoup and libcurl networking implementations please lend a hand and move the members enclosed in USE(SOUP) or USE(CURL)? I have done similar moves in https://trac.webkit.org/changeset/238654/webkit and https://trac.webkit.org/changeset/238630/webkit if you would like a pattern to follow. _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
It’s been three weeks. Is anyone maintaining the soup or curl loading code?
On Dec 3, 2018, at 1:03 PM, Alex Christensen <achristensen@apple.com> wrote:
On Dec 3, 2018, at 12:55 PM, Basuke.Suzuki@sony.com wrote:
Alex,
Got it. Curl port will catch up this move soon. Great! Thanks!
I just want to confirm my understanding about Network Session. It is pretty similar concept with Cocoa's URLSession, isn't it? It tries.
Curl Port uses default NetworkSession at everywhere so that it is almost same with global NetworkProcess. We need to move forward to support NetworkSession correctly.
----- Basuke Suzuki SONY PlayStation
-----Original Message----- From: webkit-dev <webkit-dev-bounces@lists.webkit.org> On Behalf Of Alex Christensen Sent: Thursday, November 29, 2018 6:15 PM To: Webkit Development List <webkit-dev@lists.webkit.org> Subject: [webkit-dev] Reducing globals
I am embarking on a journey to reduce the number of global variables and singletons we use instead member variables on the proper objects. Feel free to join!
Specifically, I’m looking into reducing the number of members in the NetworkProcessCreationParameters structure. Many of them need to go to NetworkSessionCreationParameters instead. Could those maintaining the libsoup and libcurl networking implementations please lend a hand and move the members enclosed in USE(SOUP) or USE(CURL)? I have done similar moves in https://trac.webkit.org/changeset/238654/webkit and https://trac.webkit.org/changeset/238630/webkit if you would like a pattern to follow. _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
On Thu, 2018-12-20 at 17:12 -0800, Alex Christensen wrote:
It’s been three weeks. Is anyone maintaining the soup or curl loading code?
I've started on the soup work locally but I've been swamped with other things and now it's time for the holiday break. I'll retake it in January. Claudio
On Thu, 2018-12-20 at 17:12 -0800, Alex Christensen wrote:
It’s been three weeks. Is anyone maintaining the soup or curl loading code?
If the main concern is the usage of NetworkProcess::singleton(), turns out that in the end this patch is all that is needed https://bugs.webkit.org/show_bug.cgi?id=193444 to stop using it in the soup code. Was there anything else that needs cleaning up? Claudio
This: On Thu, Nov 29, 2018 at 8:15 PM, Alex Christensen <achristensen@apple.com> wrote:
Specifically, I’m looking into reducing the number of members in the NetworkProcessCreationParameters structure. Many of them need to go to NetworkSessionCreationParameters instead. Could those maintaining the libsoup and libcurl networking implementations please lend a hand and move the members enclosed in USE(SOUP) or USE(CURL)? I have done similar moves in https://trac.webkit.org/changeset/238654/webkit and https://trac.webkit.org/changeset/238630/webkit if you would like a pattern to follow.
I'll try. Michael
Sorry again for the delay. I've started here: https://bugs.webkit.org/show_bug.cgi?id=194075 That covers the first two out of six parameters. I'll do CookieAcceptPolicy next, separately, since it requires modifying cross-platform stuff to do properly. And then the second half. Michael
participants (4)
-
Alex Christensen
-
Basuke.Suzuki＠sony.com
-
Claudio Saavedra
-
Michael Catanzaro