Hi, I was just seeing that we have about 84 bugs which are in the pending-commit state, on the Gtk+ bugs I clicked the patches need to be landed manually. It would be nice to get a hand landing these patches, or asking the commit queue to take care of them. thanks holger
I tried to clean out pending-commit a few weeks ago. I found that many of the patches had already been landed but the bugs hadn't been closed. The commit-queue should be able to handle as many patches as you throw at it, so that shouldn't be the limiting factor. Adam On Tue, Sep 7, 2010 at 1:03 AM, Holger Freyther <zecke@selfish.org> wrote:
Hi,
I was just seeing that we have about 84 bugs which are in the pending-commit state, on the Gtk+ bugs I clicked the patches need to be landed manually.
It would be nice to get a hand landing these patches, or asking the commit queue to take care of them.
thanks holger _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
I also attempted to look through pending-commit last week. I decided to clean it out someone needs to write a script which can make a guess if a bug is landed or not. I would guess that over half of http://webkit.org/pending-commit are already landed and the lander forgot to close the bug. [1] You should feel free to CQ as much of it as you like. The CQ is far from capacity. It's slower than it should be during peek hours (mostly due to flaky tests combined with ChangeLog/checkout contention), but I'm working on making it faster. -eric 1. FYI, if you prefer to land your patches w/o the assistance of webkit-patch land (which will update and close the bug for you), you might consider using "webkit-patch mark-bug-fixed" right after landing. It's a command written by Dave Kiltzer which looks at the most recent revision and updates and closes the bug associated with that revision. On Tue, Sep 7, 2010 at 1:09 AM, Adam Barth <abarth@webkit.org> wrote:
I tried to clean out pending-commit a few weeks ago. I found that many of the patches had already been landed but the bugs hadn't been closed. The commit-queue should be able to handle as many patches as you throw at it, so that shouldn't be the limiting factor.
Adam
On Tue, Sep 7, 2010 at 1:03 AM, Holger Freyther <zecke@selfish.org> wrote:
Hi,
I was just seeing that we have about 84 bugs which are in the pending-commit state, on the Gtk+ bugs I clicked the patches need to be landed manually.
It would be nice to get a hand landing these patches, or asking the commit queue to take care of them.
thanks holger _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Sep 7, 2010, at 9:51 AM, Eric Seidel <eric@webkit.org> wrote:
I also attempted to look through pending-commit last week. I decided to clean it out someone needs to write a script which can make a guess if a bug is landed or not. I would guess that over half of http://webkit.org/pending-commit are already landed and the lander forgot to close the bug. [1]
You should feel free to CQ as much of it as you like. The CQ is far from capacity. It's slower than it should be during peek hours (mostly due to flaky tests combined with ChangeLog/checkout contention), but I'm working on making it faster.
-eric
1. FYI, if you prefer to land your patches w/o the assistance of webkit-patch land (which will update and close the bug for you), you might consider using "webkit-patch mark-bug-fixed" right after landing. It's a command written by Dave Kiltzer which looks at the most recent revision and updates and closes the bug associated with that revision.
It's most useful immediately after landing a patch. Otherwise, you may need to specify both the bug number and revision on the command-line. It should work in both git and svn working directories, though. Dave -- Sent from my iPhone 4
On Tue, Sep 7, 2010 at 1:09 AM, Adam Barth <abarth@webkit.org> wrote:
I tried to clean out pending-commit a few weeks ago. I found that many of the patches had already been landed but the bugs hadn't been closed. The commit-queue should be able to handle as many patches as you throw at it, so that shouldn't be the limiting factor.
Adam
On Tue, Sep 7, 2010 at 1:03 AM, Holger Freyther <zecke@selfish.org> wrote:
Hi,
I was just seeing that we have about 84 bugs which are in the pending-commit state, on the Gtk+ bugs I clicked the patches need to be landed manually.
It would be nice to get a hand landing these patches, or asking the commit queue to take care of them.
thanks holger _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
participants (4)
-
Adam Barth
-
David Kilzer
-
Eric Seidel
-
Holger Freyther