On May 15, 2009, at 9:29 PM, Joonghoon Kim wrote:
1) Sometimes, cairo doesn't render Korean 'bold' letters correctly. English looks fine. It seems to be very close to this cairo bug. http://bugs.freedesktop.org/show_bug.cgi?id=21543 But I'm not sure both are same. (Of course, I'm using Cairo 1.8.6 in requirements.zip)
I just committed a fix yesterday (http://trac.webkit.org/changeset/ 44268) contributed by Alexander Macdonald that might fix this problem.
2) In ACID3 test, some assertion failure occures, for WebCore attempts to destroy cairo font structures which has 0 ref count. I changed SimpleFontData::platformDestroy() to destroy the structures while ref-count is bigger than 0. The failure has gone, but I'm not sure it's right.
I've noticed this, too, but have not looked into it much.
3) I can't see context-menu localized strings, for CreateBundle() with WebKit.resources/ fails. It's due to Open CF-Lite. _CFGetFileProperties() returns -1 for createFileA() fails. GetLastError() reports ERROR_ACCESS_DENIED. Anyone know why this happens?
I'm not sure if this is a bug in CFLite (perhaps missing functionality for handling bundles on Windows), or if you are just missing the appropriate bundle directory in the location CFLite is checking. Do you have the various bundle/resource directories alongside WebKit/ CFLite? -Brent
Hi Everyone, 2009/5/15 Joonghoon Kim <lunaris@tmax.co.kr>:
3) I can't see context-menu localized strings, for CreateBundle() with WebKit.resources/ fails. It's due to Open CF-Lite. _CFGetFileProperties() returns -1 for createFileA() fails. GetLastError() reports ERROR_ACCESS_DENIED. Anyone know why this happens?
I tracked down the cause of this problem. Updated DLL's are now available from my iDisk (http://files.me.com/bfulgham/iay8p5), and the SVN sources at the OpenCFLite (http://sourceforge.net/projects/opencflite/) project include this fix. We will produce an official download in a few days. The problem turned out to be incorrect file handling. For reasons locked in Microsoft's dark underbelly, the CreateFile call requires that you pass the flag FILE_FLAG_BACKUP_SEMANTICS (instead of the more obvious-seeming NULL used in all the example programs.) If you use this flag, then it will create a file handle to the directory. Correcting this bug opened up a ton of functionality in the Cairo port, including access to the web inspector and a myriad of other right-click (contextual) menu features. Thanks for making me feel guilty enough to fix this -- I had no idea how much cool stuff I was missing because of this long-standing bug. :-) Thanks, -Brent
Hi Everyone, 2009/5/15 Joonghoon Kim <lunaris@tmax.co.kr>:
2) In ACID3 test, some assertion failure occures, for WebCore attempts to destroy cairo font structures which has 0 ref count. I changed SimpleFontData::platformDestroy() to destroy the structures while ref-count is bigger than 0. The failure has gone, but I'm not sure it's right.
I finally tracked this problem down. You can read all about it in https://bugs.webkit.org/show_bug.cgi?id=26353, but this is now fixed in ToT as of revision @r44630. Thanks, -Brent
participants (2)
-
Brent Fulgham
-
Joonghoon Kim