Re: [webkit-dev] [webkit-changes] [47447] trunk
On Aug 18, 2009, at 3:53 PM, bweinstein@apple.com wrote:
Modified: trunk/WebKitTools/DumpRenderTree/win/UIDelegate.cpp (47446 => 47447)
--- trunk/WebKitTools/DumpRenderTree/win/UIDelegate.cpp 2009-08-18 19:53:27 UTC (rev 47446) +++ trunk/WebKitTools/DumpRenderTree/win/UIDelegate.cpp 2009-08-18 19:53:31 UTC (rev 47447) @@ -43,6 +43,8 @@ #include <WebKit/WebKit.h> #include <stdio.h>
+#include <atlbase.h> + using std::wstring;
class DRTUndoObject { @@ -563,6 +565,17 @@ /* [in] */ IWebSecurityOrigin *origin, /* [in] */ BSTR databaseIdentifier) { + CComBSTR protocol; + CComBSTR host; + unsigned short port; + + origin->protocol(&protocol); + origin->host(&host); + origin->port(&port); + + if (!done && gLayoutTestController->dumpDatabaseCallbacks()) + printf("UI DELEGATE DATABASE CALLBACK: exceededDatabaseQuotaForSecurityOrigin:{%S, %S, %i} database:%S\n", protocol, host, port, databaseIdentifier); +
We avoid ATL in WebKit/DRT code because ATL is not included with VC++ Express. Presumably this patch has broken the VC++ Express build. -Adam
On Aug 18, 2009, at 3:12 PM, Adam Roben wrote:
We avoid ATL in WebKit/DRT code because ATL is not included with VC+ + Express. Presumably this patch has broken the VC++ Express build.
-Adam
Should I just use standard BSTR's there? rs=you to make the change if that's what is needed?
On Aug 18, 2009, at 6:14 PM, Brian Weinstein wrote:
On Aug 18, 2009, at 3:12 PM, Adam Roben wrote:
We avoid ATL in WebKit/DRT code because ATL is not included with VC+ + Express. Presumably this patch has broken the VC++ Express build.
-Adam
Should I just use standard BSTR's there?
Yes.
rs=you to make the change if that's what is needed?
Yes, if you free the BSTRs with SysFreeString when you're done with them. -Adam
participants (2)
-
Adam Roben
-
Brian Weinstein