Hi WebKittens, I would like to remove ENABLE(INTL) compile time flag and always enable INTL. This is ECMAScript Intl (i18n) feature. This feature depends on ICU. But right now, even JSC (and WTF) always require ICU. Even if we disable ENABLE(INTL), we still require ICU. New INTL features are gurded separately with the compile flags (since some new features require new ICU). So, removing ENABLE(INTL) just enables Intl basic features, which are shipped more than 1 year ago and it is quite mature. Best regards, Yusuke Suzuki -- Regards, Yusuke Suzuki
As a representative from TC39, I celebrate this decision and I hope to see Intl is progressively implemented as the EcmaScript features. Please, let me know if you want feedback from test262 perspective, this might support the information on impl maturity. On Sat, May 19, 2018 at 7:12 AM Yusuke SUZUKI <utatane.tea@gmail.com> wrote:
Hi WebKittens,
I would like to remove ENABLE(INTL) compile time flag and always enable INTL. This is ECMAScript Intl (i18n) feature. This feature depends on ICU. But right now, even JSC (and WTF) always require ICU. Even if we disable ENABLE(INTL), we still require ICU.
New INTL features are gurded separately with the compile flags (since some new features require new ICU). So, removing ENABLE(INTL) just enables Intl basic features, which are shipped more than 1 year ago and it is quite mature.
Best regards, Yusuke Suzuki -- Regards, Yusuke Suzuki _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
19.05.2018, 14:12, "Yusuke SUZUKI" <utatane.tea@gmail.com>:
Hi WebKittens,
I would like to remove ENABLE(INTL) compile time flag and always enable INTL. This is ECMAScript Intl (i18n) feature. This feature depends on ICU. But right now, even JSC (and WTF) always require ICU. Even if we disable ENABLE(INTL), we still require ICU.
For the record, having !ENABLE(INTL) option allowed to build WebKit against old ICU versions, e.g. version that is shipped with RHEL 7.
New INTL features are gurded separately with the compile flags (since some new features require new ICU). So, removing ENABLE(INTL) just enables Intl basic features, which are shipped more than 1 year ago and it is quite mature.
Best regards, Yusuke Suzuki -- Regards, Yusuke Suzuki ,
_______________________________________________ jsc-dev mailing list jsc-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/jsc-dev
-- Regards, Konstantin
On Mon, May 21, 2018 at 8:55 AM, Konstantin Tokarev <annulen@yandex.ru> wrote:
For the record, having !ENABLE(INTL) option allowed to build WebKit against old ICU versions, e.g. version that is shipped with RHEL 7.
For WebKitGTK+, we do not support building without ENABLE(INTL), and we don't need to worry about RHEL 7 since RHEL is shipping an unsupported version of WebKit with bundled ICU. But we do need to support Ubuntu 16.04 (with ICU 55). If ENABLE(INTL) is going to require newer ICU than that, then we would need to expose ENABLE(INTL) and ensure that disabling it works. We do have a buildbot to check this, and it's green right now, so trunk must be fine. But I'm curious if anyone knows what the ICU requirement is for ENABLE(INTL)? Michael
21.05.2018, 17:45, "Michael Catanzaro" <mcatanzaro@igalia.com>:
On Mon, May 21, 2018 at 8:55 AM, Konstantin Tokarev <annulen@yandex.ru> wrote:
For the record, having !ENABLE(INTL) option allowed to build WebKit against old ICU versions, e.g. version that is shipped with RHEL 7.
For WebKitGTK+, we do not support building without ENABLE(INTL), and we don't need to worry about RHEL 7 since RHEL is shipping an unsupported version of WebKit with bundled ICU.
But we do need to support Ubuntu 16.04 (with ICU 55). If ENABLE(INTL) is going to require newer ICU than that, then we would need to expose ENABLE(INTL) and ensure that disabling it works. We do have a buildbot to check this, and it's green right now, so trunk must be fine. But I'm curious if anyone knows what the ICU requirement is for ENABLE(INTL)?
AFAIK ICU 54 is enough
Michael
-- Regards, Konstantin
On Mon, May 21, 2018 at 9:45 AM, Michael Catanzaro <mcatanzaro@igalia.com> wrote:
But I'm curious if anyone knows what the ICU requirement is for ENABLE(INTL)?
Also, Ms2ger reported https://bugs.webkit.org/show_bug.cgi?id=185714 recently. It seems there are new options ENABLE_INTL_NUMBER_FORMAT_TO_PARTS and ENABLE_INTL_PLURAL_RULES, both disabled in WebKitFeatures.cmake. Ideally those would be enabled if ICU is new enough. Does anybody know what ICU versions are required for these? (If so, best comment in the bug.)
Thanks all! OK, so ICU 54 is enough for ENABLE(INTL) and all of our supporting environment just has ICU 54. I'll open a bug for removing ENABLE(INTL) :)
participants (4)
-
Konstantin Tokarev
-
Leo Balter
-
Michael Catanzaro
-
Yusuke SUZUKI