Hi all, I'm seeing failures for the following tests: fast/dom/outerText-no-element fast/dynamic/outerHTML-no-element fast/js/array-every fast/js/array-foreach fast/js/array-some fast/js/toString-stack-overflow All of the diffs are very similar to: -RangeError : Maximum call stack size exceeded. +RangeError: Maximum call stack size exceeded. Looks like we just need to update a few expected results. Unless anyone objects, I'll do that later tonight. -Adele
Looks like an (inadvertent?) change where a space was removed from "RangeError :" John On Jul 15, 2005, at 8:48 PM, Adele Peterson wrote:
Hi all,
I'm seeing failures for the following tests:
fast/dom/outerText-no-element fast/dynamic/outerHTML-no-element fast/js/array-every fast/js/array-foreach fast/js/array-some fast/js/toString-stack-overflow
All of the diffs are very similar to:
-RangeError : Maximum call stack size exceeded. +RangeError: Maximum call stack size exceeded.
Looks like we just need to update a few expected results. Unless anyone objects, I'll do that later tonight.
-Adele _______________________________________________ webkit-dev mailing list webkit-dev@opendarwin.org http://www.opendarwin.org/mailman/listinfo/webkit-dev
Likely from: -rolled in KDE fixes for http://bugzilla.opendarwin.org/show_bug.cgi? id=3601 In error_object.cpp - s += " : " + v.toString(exec); // Mozilla compatible format + s += ": " + v.toString(exec); // Mozilla compatible format So it does look like this was part of the original patch. Not sure if the formatting matters, but since we need to keep the test results in sync, I'll go ahead with updating the results. -Adele On Jul 15, 2005, at 9:07 PM, John Sullivan wrote:
Looks like an (inadvertent?) change where a space was removed from "RangeError :"
John
On Jul 15, 2005, at 8:48 PM, Adele Peterson wrote:
Hi all,
I'm seeing failures for the following tests:
fast/dom/outerText-no-element fast/dynamic/outerHTML-no-element fast/js/array-every fast/js/array-foreach fast/js/array-some fast/js/toString-stack-overflow
All of the diffs are very similar to:
-RangeError : Maximum call stack size exceeded. +RangeError: Maximum call stack size exceeded.
Looks like we just need to update a few expected results. Unless anyone objects, I'll do that later tonight.
-Adele _______________________________________________ webkit-dev mailing list webkit-dev@opendarwin.org http://www.opendarwin.org/mailman/listinfo/webkit-dev
On Jul 15, 2005, at 10:46 PM, Adele Peterson wrote:
Likely from:
-rolled in KDE fixes for http://bugzilla.opendarwin.org/ show_bug.cgi?id=3601
In error_object.cpp - s += " : " + v.toString(exec); // Mozilla compatible format + s += ": " + v.toString(exec); // Mozilla compatible format
So it does look like this was part of the original patch. Not sure if the formatting matters, but since we need to keep the test results in sync, I'll go ahead with updating the results.
I presume this is intentional to be more like Mozilla and make the tests happy - even if not this seems like a minor thing so it's good to be in sync with kjs. Regards, Maciej
-Adele
On Jul 15, 2005, at 9:07 PM, John Sullivan wrote:
Looks like an (inadvertent?) change where a space was removed from "RangeError :"
John
On Jul 15, 2005, at 8:48 PM, Adele Peterson wrote:
Hi all,
I'm seeing failures for the following tests:
fast/dom/outerText-no-element fast/dynamic/outerHTML-no-element fast/js/array-every fast/js/array-foreach fast/js/array-some fast/js/toString-stack-overflow
All of the diffs are very similar to:
-RangeError : Maximum call stack size exceeded. +RangeError: Maximum call stack size exceeded.
Looks like we just need to update a few expected results. Unless anyone objects, I'll do that later tonight.
-Adele _______________________________________________ webkit-dev mailing list webkit-dev@opendarwin.org http://www.opendarwin.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@opendarwin.org http://www.opendarwin.org/mailman/listinfo/webkit-dev
participants (3)
-
Adele Peterson
-
John Sullivan
-
Maciej Stachowiak