Review Flag Requestee field
It seems that the requestee field is a source of confusion for new contributers. Especially so when the new contributor comes from another project where the requestee field may be required (Google, and mozilla I'm told). I would like us to consider disabling the requestee field for the review flag. Pros: - less confusion for new contributers Cons: - loss of this feature (ability to specify that a review is blocked on a specific person?) Thoughts? -eric
I agree with just disabling/removing it. On Oct 5, 2009, at 2:23 PM, Eric Seidel wrote:
It seems that the requestee field is a source of confusion for new contributers. Especially so when the new contributor comes from another project where the requestee field may be required (Google, and mozilla I'm told).
I would like us to consider disabling the requestee field for the review flag.
Pros: - less confusion for new contributers
Cons: - loss of this feature (ability to specify that a review is blocked on a specific person?)
Thoughts?
-eric _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
OK. This is just a single checkbox to check in bugzilla: https://bugs.webkit.org/editflagtypes.cgi?action=edit&id=1 I'll wait another 24 hours for folks to have a chance to respond and then I'll uncheck the box. -eric On Mon, Oct 5, 2009 at 3:34 PM, Darin Adler <darin@apple.com> wrote:
On Oct 5, 2009, at 12:23 PM, Eric Seidel wrote:
I would like us to consider disabling the requestee field for the review
flag.
Yes, I think we should do it.
-- Darin
On Mon, Oct 5, 2009 at 12:23 PM, Eric Seidel <eric@webkit.org> wrote:
It seems that the requestee field is a source of confusion for new contributers. Especially so when the new contributor comes from another project where the requestee field may be required (Google, and mozilla I'm told). I would like us to consider disabling the requestee field for the review flag. Pros: - less confusion for new contributers
I found it very confusing (up until now) in that I was never sure if I should be filling in a value. I'd be happy to see it go. -- --Alex Milowski "The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered." Bertrand Russell in a footnote of Principles of Mathematics
On Oct 5, 2009, at 12:23 PM, Eric Seidel wrote:
It seems that the requestee field is a source of confusion for new contributers. Especially so when the new contributor comes from another project where the requestee field may be required (Google, and mozilla I'm told).
I would like us to consider disabling the requestee field for the review flag.
Yes, we should disable it. - Maciej
I'm convinced now, too. Let's disable it. Geoff On Oct 5, 2009, at 12:53 PM, Maciej Stachowiak wrote:
On Oct 5, 2009, at 12:23 PM, Eric Seidel wrote:
It seems that the requestee field is a source of confusion for new contributers. Especially so when the new contributor comes from another project where the requestee field may be required (Google, and mozilla I'm told).
I would like us to consider disabling the requestee field for the review flag.
Yes, we should disable it.
- Maciej
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Done. Unchecked: [ ] specifically requestable (users can ask specific other users to set flags of this type as opposed to just asking the wind) If you have any troubles, please ask the wind. -eric On Tue, Oct 6, 2009 at 2:25 PM, Geoffrey Garen <ggaren@apple.com> wrote:
I'm convinced now, too. Let's disable it.
Geoff
On Oct 5, 2009, at 12:53 PM, Maciej Stachowiak wrote:
On Oct 5, 2009, at 12:23 PM, Eric Seidel wrote:
It seems that the requestee field is a source of confusion for new contributers. Especially so when the new contributor comes from another project where the requestee field may be required (Google, and mozilla I'm told).
I would like us to consider disabling the requestee field for the review flag.
Yes, we should disable it.
- Maciej
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
participants (6)
-
Alex Milowski
-
Darin Adler
-
David Hyatt
-
Eric Seidel
-
Geoffrey Garen
-
Maciej Stachowiak