If I use '#define ENABLE_XPATH 0' in my config, the build mostly compiles, but not entirely. I get the errors shown below. The compile errors appear to occur because the code below doesn't check for ENABLE(XPATH) (whereas much of the rest of the source code does). Is this an oversight, or am I not understanding something about ENABLE_XPATH? Note: my build is about five weeks old now, and I admit that I don't know how it is that XPATH is used within WebKit. WebCore\JSDocument.cpp(735) : error C2065: 'XPathNSResolver' : undeclared identifier WebCore\JSDocument.cpp(735) : error C2133: 'customResolver' : unknown size WebCore\JSDocument.cpp(735) : error C2512: 'WTF::RefPtr' : no appropriate default constructor available WebCore\JSDocument.cpp(736) : error C2065: 'resolver' : undeclared identifier WebCore\JSDocument.cpp(736) : error C3861: 'toXPathNSResolver': identifier not found WebCore\JSDocument.cpp(738) : error C2653: 'JSCustomXPathNSResolver' : is not a class or namespace name WebCore\JSDocument.cpp(738) : error C3861: 'create': identifier not found WebCore\JSDocument.cpp(741) : error C2662: 'WTF::RefPtr<T>::get' : cannot convert 'this' pointer from 'WTF::RefPtr' to 'const WTF::RefPtr<T> &' Reason: cannot convert from 'WTF::RefPtr' to 'const WTF::RefPtr<T>' Conversion requires a second user-defined-conversion operator or constructor WebCore\JSDocument.cpp(745) : error C2039: 'createExpression' : is not a member of 'WebCore::Document' WebCore\JSDocument.cpp(759) : error C2039: 'createNSResolver' : is not a member of 'WebCore::Document' WebCore\JSDocument.cpp(772) : error C2133: 'customResolver' : unknown size WebCore\JSDocument.cpp(772) : error C2512: 'WTF::RefPtr' : no appropriate default constructor available WebCore\JSDocument.cpp(773) : error C3861: 'toXPathNSResolver': identifier not found WebCore\JSDocument.cpp(775) : error C2653: 'JSCustomXPathNSResolver' : is not a class or namespace name WebCore\JSDocument.cpp(775) : error C3861: 'create': identifier not found WebCore\JSDocument.cpp(778) : error C2662: 'WTF::RefPtr<T>::get' : cannot convert 'this' pointer from 'WTF::RefPtr' to 'const WTF::RefPtr<T> &' Reason: cannot convert from 'WTF::RefPtr' to 'const WTF::RefPtr<T>' Conversion requires a second user-defined-conversion operator or constructor WebCore\JSDocument.cpp(781) : error C2065: 'XPathResult' : undeclared identifier WebCore\JSDocument.cpp(781) : error C2065: 'inResult' : undeclared identifier WebCore\JSDocument.cpp(781) : error C3861: 'toXPathResult': identifier not found WebCore\JSDocument.cpp(784) : error C2039: 'evaluate' : is not a member of 'WebCore::Document' WebCore\JSDOMWindow.cpp(1230) : error C2653: 'JSXPathEvaluator' : is not a class or namespace name WebCore\JSDOMWindow.cpp(1230) : error C3861: 'getConstructor': identifier not found WebCore\JSDOMWindow.cpp(1235) : error C2653: 'JSXPathResult' : is not a class or namespace name WebCore\JSDOMWindow.cpp(1235) : error C3861: 'getConstructor': identifier not found WebCore\JSDOMWindow.cpp(1240) : error C2653: 'JSXPathException' : is not a class or namespace name WebCore\JSDOMWindow.cpp(1240) : error C3861: 'getConstructor': identifier not found
On Aug 5, 2008, at 2:29 PM, Paul Pedriana wrote:
If I use '#define ENABLE_XPATH 0' in my config, the build mostly compiles, but not entirely. I get the errors shown below. The compile errors appear to occur because the code below doesn't check for ENABLE(XPATH) (whereas much of the rest of the source code does). Is this an oversight, or am I not understanding something about ENABLE_XPATH? Note: my build is about five weeks old now, and I admit that I don't know how it is that XPATH is used within WebKit.
These are probably just oversights. I don't think any of our build bots have ENABLE_XPATH turned off, so it's not too surprising that the build has rotted in this configuration. Patches to fix this would be welcome at bugs.webkit.org! -Adam
participants (2)
-
Adam Roben
-
Paul Pedriana