Re: [webkit-dev] [webkit-changes] [47465] trunk/WebKitTools
On Aug 18, 2009, at 8:00 PM, mrowe@apple.com wrote:
Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.
Doesn't this create a race condition between the two timers? -Adam
On Aug 19, 2009, at 6:34 AM, Adam Roben wrote:
On Aug 18, 2009, at 8:00 PM, mrowe@apple.com wrote:
Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.
Doesn't this create a race condition between the two timers?
If a test times out at 15 seconds, what does it matter if the DRT watchdog or the run-webkit-tests watchdog catches it? One or the other might "randomly get there first in a race", but I don't think it's relevant which. ~Brady
-Adam
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Aug 19, 2009, at 12:31 PM, Brady Eidson wrote:
On Aug 19, 2009, at 6:34 AM, Adam Roben wrote:
On Aug 18, 2009, at 8:00 PM, mrowe@apple.com wrote:
Bump waitToDumpWatchdogInterval to 15 seconds to match the time- out used by run-webkit-tests.
Doesn't this create a race condition between the two timers?
If a test times out at 15 seconds, what does it matter if the DRT watchdog or the run-webkit-tests watchdog catches it?
One or the other might "randomly get there first in a race", but I don't think it's relevant which.
I think it is relevant. If run-webkit-tests's timer fires, it tells you that DRT has hung. If the watchdog timer fires, it tells you that the test has an error which causes notifyDone() never to be called, but that DRT is still functioning. The two errors usually have pretty different causes. -Adam
participants (2)
-
Adam Roben
-
Brady Eidson