Why is port 8080 hard-coded in LayoutTests/http/conf/*httpd.conf?
In r24746, the three *httpd.conf files in LayoutTests/http/conf were changed to listen on port 8080 as well. The relevant section in those files looks like this now: # # Listen: Allows you to bind Apache to specific IP addresses and/or # ports, instead of the default. See also the <VirtualHost> # directive. # # Configured from the httpd command line for WebKit layout tests. # Port 8443 is hard-coded as it is needed for the HTTPS configuration later on. # #Listen 3000 Listen 127.0.0.1:8080 Listen 127.0.0.1:8443 Should we add a comment to explain why port 8080 is hard-coded? Why don't we pass -C 'Listen 127.0.0.1:8080' to httpd on the command line? Thanks. -- Anyang Ren Open source developer
On Aug 29, 2007, at 11:32 AM, Anyang Ren wrote:
In r24746, the three *httpd.conf files in LayoutTests/http/conf were changed to listen on port 8080 as well. The relevant section in those files looks like this now:
# # Listen: Allows you to bind Apache to specific IP addresses and/or # ports, instead of the default. See also the <VirtualHost> # directive. # # Configured from the httpd command line for WebKit layout tests. # Port 8443 is hard-coded as it is needed for the HTTPS configuration later on. # #Listen 3000 Listen 127.0.0.1:8080 Listen 127.0.0.1:8443
Should we add a comment to explain why port 8080 is hard-coded?
Why don't we pass -C 'Listen 127.0.0.1:8080' to httpd on the command line?
Port 8080 has to be used because a handful of the tests (mostly security-related) now depend on the specific port number. Regards, MAciej
On 8/29/07 10:32 PM, "Anyang Ren" <anyang.ren@gmail.com> wrote:
Why don't we pass -C 'Listen 127.0.0.1:8080' to httpd on the command line?
Some tests even rely on the regular port being 8000 now, so making it configurable is not particularly useful. I think it's unfortunate, but on the other hand, no actual problems cused by this have been reported yet. - WBR, Alexey Proskuryakov
participants (3)
-
Alexey Proskuryakov
-
Anyang Ren
-
Maciej Stachowiak