If you're currently using "svn commit" or "git svn dcommit" to commit your patches, please consider using "bugzilla-tool land-diff" instead. Why? 1. bugzilla-tool updates (and optionally closes) the bug for you when you're done. 2. bugzilla-tool makes a nice commit entry automatically for you (not quite as cool as commit-log-editor yet, but close). 3. MOST IMPORTANT: bugzilla-tool land-diff will automatically build and run the layout tests before landing! a. Impossible break at least one platform's bots when using bugzilla-tool! b. Impossible to inadvertently land when the tree is red! If you don't have time to build and run the tests before committing, you can always mark your patch for commit-queue+ instead and the commit queue script will commit it for you (after building and running the tests). See "bugzilla-tool --help" for more information. -eric
On 2009-08-17, at 11:36, Eric Seidel wrote:
If you're currently using "svn commit" or "git svn dcommit" to commit your patches, please consider using "bugzilla-tool land-diff" instead.
Why? 1. bugzilla-tool updates (and optionally closes) the bug for you when you're done.
2. bugzilla-tool makes a nice commit entry automatically for you (not quite as cool as commit-log-editor yet, but close).
3. MOST IMPORTANT: bugzilla-tool land-diff will automatically build and run the layout tests before landing! a. Impossible break at least one platform's bots when using bugzilla-tool! b. Impossible to inadvertently land when the tree is red!
4. bugzilla-tool will dump lots of exciting yet irrelevant junk in the bug before closing it (<http://webkit.org/b/26920>). That's always fun! 5. In the interests of keeping life interesting, bugzilla-tool will sometimes commit with the wrong commit message (<http://webkit.org/b/28092
).
- Mark
Yes, there are bugs, like all software. Your flippant response seems inappropriate. On Mon, Aug 17, 2009 at 11:41 AM, Mark Rowe <mrowe@apple.com> wrote:
On 2009-08-17, at 11:36, Eric Seidel wrote:
If you're currently using "svn commit" or "git svn dcommit" to commit your
patches, please consider using "bugzilla-tool land-diff" instead.
Why? 1. bugzilla-tool updates (and optionally closes) the bug for you when you're done.
2. bugzilla-tool makes a nice commit entry automatically for you (not quite as cool as commit-log-editor yet, but close).
3. MOST IMPORTANT: bugzilla-tool land-diff will automatically build and run the layout tests before landing! a. Impossible break at least one platform's bots when using bugzilla-tool! b. Impossible to inadvertently land when the tree is red!
4. bugzilla-tool will dump lots of exciting yet irrelevant junk in the bug before closing it (<http://webkit.org/b/26920>). That's always fun!
5. In the interests of keeping life interesting, bugzilla-tool will sometimes commit with the wrong commit message (<http://webkit.org/b/28092
).
- Mark
On 2009-08-17, at 11:43, Eric Seidel wrote:
Yes, there are bugs, like all software. Your flippant response seems inappropriate.
In the past you've said that you would address these sorts of issues before suggesting wider use. You're now suggesting wider use of the tool but the issues still remain. I think it's reasonable to make people are aware of the problems. I also think it's completely reasonable to request that known issues that result in a mess being made in Bugzilla and the SVN history are addressed as soon as possible. - Mark
On Mon, Aug 17, 2009 at 11:41 AM, Mark Rowe <mrowe@apple.com> wrote:
On 2009-08-17, at 11:36, Eric Seidel wrote:
If you're currently using "svn commit" or "git svn dcommit" to commit your patches, please consider using "bugzilla-tool land-diff" instead.
Why? 1. bugzilla-tool updates (and optionally closes) the bug for you when you're done.
2. bugzilla-tool makes a nice commit entry automatically for you (not quite as cool as commit-log-editor yet, but close).
3. MOST IMPORTANT: bugzilla-tool land-diff will automatically build and run the layout tests before landing! a. Impossible break at least one platform's bots when using bugzilla-tool! b. Impossible to inadvertently land when the tree is red!
4. bugzilla-tool will dump lots of exciting yet irrelevant junk in the bug before closing it (<http://webkit.org/b/26920>). That's always fun!
5. In the interests of keeping life interesting, bugzilla-tool will sometimes commit with the wrong commit message (<http://webkit.org/b/28092
).
- Mark
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Mon, Aug 17, 2009 at 11:48 AM, Mark Rowe <mrowe@apple.com> wrote:
On 2009-08-17, at 11:43, Eric Seidel wrote:
Yes, there are bugs, like all software. Your flippant response seems inappropriate.
In the past you've said that you would address these sorts of issues before suggesting wider use. You're now suggesting wider use of the tool but the issues still remain. I think it's reasonable to make people are aware of the problems. I also think it's completely reasonable to request that known issues that result in a mess being made in Bugzilla and the SVN history are addressed as soon as possible.
Why didn't you say so to begin with? Your follow up explanation was much more useful than you initial, caustic response. The way people generally treat each other on the internet sucks. But we can do better than that on webkit-dev, right? J
On 2009-08-17, at 12:32, Jeremy Orlow wrote:
On Mon, Aug 17, 2009 at 11:48 AM, Mark Rowe <mrowe@apple.com> wrote:
On 2009-08-17, at 11:43, Eric Seidel wrote:
Yes, there are bugs, like all software. Your flippant response seems inappropriate.
In the past you've said that you would address these sorts of issues before suggesting wider use. You're now suggesting wider use of the tool but the issues still remain. I think it's reasonable to make people are aware of the problems. I also think it's completely reasonable to request that known issues that result in a mess being made in Bugzilla and the SVN history are addressed as soon as possible.
Why didn't you say so to begin with? Your follow up explanation was much more useful than you initial, caustic response.
Because I've had this exact conversation with Eric in the past. Given the lack of action that resulted from those conversations it didn't seem like a worthwhile exercise to repeat them. This approach seems much less likely to be ignored. - Mark
Hi Mark, I think this was a needlessly rude way to address the issue. Please try to keep things courteous on webkit-dev. Your most important point, i.e. that 'bugzilla-tool land-diff' is really at "early adopter" maturity and not at "everyone should use it" maturity, was much more clear in your later, less snarky message. That being said, now that you have stated your point, I'd like to hear Eric's feedback on the importance of these bugs. Regards, Maciej On Aug 17, 2009, at 11:41 AM, Mark Rowe wrote:
On 2009-08-17, at 11:36, Eric Seidel wrote:
If you're currently using "svn commit" or "git svn dcommit" to commit your patches, please consider using "bugzilla-tool land- diff" instead.
Why? 1. bugzilla-tool updates (and optionally closes) the bug for you when you're done.
2. bugzilla-tool makes a nice commit entry automatically for you (not quite as cool as commit-log-editor yet, but close).
3. MOST IMPORTANT: bugzilla-tool land-diff will automatically build and run the layout tests before landing! a. Impossible break at least one platform's bots when using bugzilla-tool! b. Impossible to inadvertently land when the tree is red!
4. bugzilla-tool will dump lots of exciting yet irrelevant junk in the bug before closing it (<http://webkit.org/b/26920>). That's always fun!
5. In the interests of keeping life interesting, bugzilla-tool will sometimes commit with the wrong commit message (<http://webkit.org/b/28092
).
- Mark
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
participants (4)
-
Eric Seidel
-
Jeremy Orlow
-
Maciej Stachowiak
-
Mark Rowe