[CMake] Bump cmake_minimum_required version to 3.10
Hi, I'm going to bump cmake_minimum_required version to 3.10 for shining new features. Bug 199181 – [CMake] Bump cmake_minimum_required version to 3.10 https://bugs.webkit.org/show_bug.cgi?id=199181 GTK and WPE's EWS and BuildBot bots maintainers, could you please update your CMake on your bots? If you are using CMake Visual Studio generator, you need CMake 3.12 or newer to avoid an unnecessary recompilation issue. AppleWin port seems still using old Visual Studio 2017. If it will switch to Visual Studio 2019 for better C++17 support, Visual Studio 2019 needs CMake 3.14 or newer. https://cmake.org/cmake/help/v3.14/release/3.14.html#generators Happy WebKit 18th <https://webkit.org/blog/6888/celebrating-15-years-of-webkit/>birthday <https://donmelton.com/2017/06/25/sweet-sixteen-for-safari-and-webkit/>🎂 -- Fujii
jsc-i368 EWS is still failing. Who is igalia-jsc-i386-ews bot maintainer? On Mon, Jun 24, 2019 at 8:21 PM Fujii Hironori <fujii.hironori@gmail.com> wrote:
Hi,
I'm going to bump cmake_minimum_required version to 3.10 for shining new features.
Bug 199181 – [CMake] Bump cmake_minimum_required version to 3.10 https://bugs.webkit.org/show_bug.cgi?id=199181
GTK and WPE's EWS and BuildBot bots maintainers, could you please update your CMake on your bots?
If you are using CMake Visual Studio generator, you need CMake 3.12 or newer to avoid an unnecessary recompilation issue.
AppleWin port seems still using old Visual Studio 2017. If it will switch to Visual Studio 2019 for better C++17 support, Visual Studio 2019 needs CMake 3.14 or newer. https://cmake.org/cmake/help/v3.14/release/3.14.html#generators
Happy WebKit 18th <https://webkit.org/blog/6888/celebrating-15-years-of-webkit/>birthday <https://donmelton.com/2017/06/25/sweet-sixteen-for-safari-and-webkit/>🎂
-- Fujii
Hi, Sorry about that. We'll take care of it ASAP. Cheers, Xan On Thu, Jun 27, 2019, 06:23 Fujii Hironori <fujii.hironori@gmail.com> wrote:
jsc-i368 EWS is still failing. Who is igalia-jsc-i386-ews bot maintainer?
On Mon, Jun 24, 2019 at 8:21 PM Fujii Hironori <fujii.hironori@gmail.com> wrote:
Hi,
I'm going to bump cmake_minimum_required version to 3.10 for shining new features.
Bug 199181 – [CMake] Bump cmake_minimum_required version to 3.10 https://bugs.webkit.org/show_bug.cgi?id=199181
GTK and WPE's EWS and BuildBot bots maintainers, could you please update your CMake on your bots?
If you are using CMake Visual Studio generator, you need CMake 3.12 or newer to avoid an unnecessary recompilation issue.
AppleWin port seems still using old Visual Studio 2017. If it will switch to Visual Studio 2019 for better C++17 support, Visual Studio 2019 needs CMake 3.14 or newer. https://cmake.org/cmake/help/v3.14/release/3.14.html#generators
Happy WebKit 18th <https://webkit.org/blog/6888/celebrating-15-years-of-webkit/>birthday <https://donmelton.com/2017/06/25/sweet-sixteen-for-safari-and-webkit/>🎂
-- Fujii
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Hello, On Thu, 27 Jun 2019 08:36:22 +0200, Xan <xan.lopez@gmail.com> wrote:
Sorry about that. We'll take care of it ASAP.
Cheers, Xan
On Thu, Jun 27, 2019, 06:23 Fujii Hironori <fujii.hironori@gmail.com> wrote:
jsc-i368 EWS is still failing. Who is igalia-jsc-i386-ews bot maintainer?
Done, this EWS has now CMake 3.13 as well (from the Debian Stretch backports repository). I managed to miss this bot yesterday — sorry. Please do let me know if you find any other issues with our bots :) Cheers, —Adrián
On Mon, Jun 24, 2019 at 8:21 PM Fujii Hironori <fujii.hironori@gmail.com> wrote:
Hi,
I'm going to bump cmake_minimum_required version to 3.10 for shining new features.
Bug 199181 – [CMake] Bump cmake_minimum_required version to 3.10 https://bugs.webkit.org/show_bug.cgi?id=199181
GTK and WPE's EWS and BuildBot bots maintainers, could you please update your CMake on your bots?
If you are using CMake Visual Studio generator, you need CMake 3.12 or newer to avoid an unnecessary recompilation issue.
AppleWin port seems still using old Visual Studio 2017. If it will switch to Visual Studio 2019 for better C++17 support, Visual Studio 2019 needs CMake 3.14 or newer. https://cmake.org/cmake/help/v3.14/release/3.14.html#generators
Happy WebKit 18th <https://webkit.org/blog/6888/celebrating-15-years-of-webkit/>birthday <https://donmelton.com/2017/06/25/sweet-sixteen-for-safari-and-webkit/>🎂
-- Fujii
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Non-text part: text/html _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Apple is in the process of bringing up VS2019 now. I would be in favor of moving the minimum to 3.14 so we can safely support VS2019 compiles. -Brent
On Jun 24, 2019, at 8:21 PM, Fujii Hironori <fujii.hironori@gmail.com> wrote:
Hi,
I'm going to bump cmake_minimum_required version to 3.10 for shining new features.
Bug 199181 – [CMake] Bump cmake_minimum_required version to 3.10 https://bugs.webkit.org/show_bug.cgi?id=199181 <https://bugs.webkit.org/show_bug.cgi?id=199181> GTK and WPE's EWS and BuildBot bots maintainers, could you please update your CMake on your bots?
If you are using CMake Visual Studio generator, you need CMake 3.12 or newer to avoid an unnecessary recompilation issue.
AppleWin port seems still using old Visual Studio 2017. If it will switch to Visual Studio 2019 for better C++17 support, Visual Studio 2019 needs CMake 3.14 or newer. https://cmake.org/cmake/help/v3.14/release/3.14.html#generators <https://cmake.org/cmake/help/v3.14/release/3.14.html#generators> Happy WebKit 18th <https://webkit.org/blog/6888/celebrating-15-years-of-webkit/>birthday <https://donmelton.com/2017/06/25/sweet-sixteen-for-safari-and-webkit/>🎂
-- Fujii _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
On Thu, Jun 27, 2019 at 11:20 AM, Brent Fulgham <bfulgham@apple.com> wrote:
Apple is in the process of bringing up VS2019 now. I would be in favor of moving the minimum to 3.14 so we can safely support VS2019 compiles.
The 3.14 target is too aggressive for WPE/GTK, unfortunately. You could use a different cmake_minimum_required for Windows only, of course.
27.06.2019, 20:19, "Michael Catanzaro" <mcatanzaro@igalia.com>:
On Thu, Jun 27, 2019 at 11:20 AM, Brent Fulgham <bfulgham@apple.com> wrote:
Apple is in the process of bringing up VS2019 now. I would be in favor of moving the minimum to 3.14 so we can safely support VS2019 compiles.
The 3.14 target is too aggressive for WPE/GTK, unfortunately. You could use a different cmake_minimum_required for Windows only, of course.
Note that you don't have to raise cmake_minimum_required to use newer CMake in your builds. -- Regards, Konstantin
Good news! Use CMake 3.14.5 to avoid another incremental build issue. Bug 198850 – [CMake][Win] WTF_CopyHeaders copies files everytime in incremental builds if Visual Studio generator is used https://bugs.webkit.org/show_bug.cgi?id=198850 On Fri, Jun 28, 2019 at 1:21 AM Brent Fulgham <bfulgham@apple.com> wrote:
Apple is in the process of bringing up VS2019 now. I would be in favor of moving the minimum to 3.14 so we can safely support VS2019 compiles.
-Brent
On Jun 24, 2019, at 8:21 PM, Fujii Hironori <fujii.hironori@gmail.com> wrote:
Hi,
I'm going to bump cmake_minimum_required version to 3.10 for shining new features.
Bug 199181 – [CMake] Bump cmake_minimum_required version to 3.10 https://bugs.webkit.org/show_bug.cgi?id=199181
GTK and WPE's EWS and BuildBot bots maintainers, could you please update your CMake on your bots?
If you are using CMake Visual Studio generator, you need CMake 3.12 or newer to avoid an unnecessary recompilation issue.
AppleWin port seems still using old Visual Studio 2017. If it will switch to Visual Studio 2019 for better C++17 support, Visual Studio 2019 needs CMake 3.14 or newer. https://cmake.org/cmake/help/v3.14/release/3.14.html#generators
Happy WebKit 18th <https://webkit.org/blog/6888/celebrating-15-years-of-webkit/>birthday <https://donmelton.com/2017/06/25/sweet-sixteen-for-safari-and-webkit/>🎂
-- Fujii _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
participants (6)
-
Adrian Perez de Castro
-
Brent Fulgham
-
Fujii Hironori
-
Konstantin Tokarev
-
Michael Catanzaro
-
Xan