Re: [webkit-dev] Experimental features enabled by default
On Wed, Jun 20, 2018 at 6:05 PM, Tim Horton <thorton@apple.com> wrote:
It’s definitely not OK, no.
Well, we should make sure the right choice is made for each individual feature, but I don't know what those right choices are... hence the motivation for my mail.
I think we have some sorting out of this to do, I think it would be appreciated if you could hold off for a little bit. Sorry for the mess!
OK, I didn't know you were already discussing this. I'll hold off, then. Michael
Hi, We're a lot closer after r233227! There is still IsSecureContextAttributeEnabled. Shall we switch the default value of that one to use DEFAULT_EXPERIMENTAL_FEATURES_ENABLED instead of true? We should also move CSSAnimationTriggersEnabled to the experimental features section of the file, and add the category tag. FullScreenEnabled and EncryptedMediaAPIEnabled should also be moved down in the file. Then we can just update the comment to indicate that custom values like DEFAULT_SERVICE_WORKERS_ENABLED are fine as long as they're thoughtful and consider ENABLE(EXPERIMENTAL_FEATURES), and that will take care of the other cases. Michael
On Jun 26, 2018, at 18:55, Michael Catanzaro <mcatanzaro@igalia.com> wrote:
Hi,
We're a lot closer after r233227!
There is still IsSecureContextAttributeEnabled. Shall we switch the default value of that one to use DEFAULT_EXPERIMENTAL_FEATURES_ENABLED instead of true?
Not sure, waiting for other people to get back to me. There’s some indication that this one, indeed, should follow DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, but I want to make sure :)
We should also move CSSAnimationTriggersEnabled to the experimental features section of the file, and add the category tag. FullScreenEnabled and EncryptedMediaAPIEnabled should also be moved down in the file.
Will have to peek at these!
Then we can just update the comment to indicate that custom values like DEFAULT_SERVICE_WORKERS_ENABLED are fine as long as they're thoughtful and consider ENABLE(EXPERIMENTAL_FEATURES), and that will take care of the other cases.
Makes sense.
Michael
Alright, how’s it looking now? :)
On Jun 26, 2018, at 19:06, Tim Horton <timothy_horton@apple.com> wrote:
On Jun 26, 2018, at 18:55, Michael Catanzaro <mcatanzaro@igalia.com> wrote:
Hi,
We're a lot closer after r233227!
There is still IsSecureContextAttributeEnabled. Shall we switch the default value of that one to use DEFAULT_EXPERIMENTAL_FEATURES_ENABLED instead of true?
Not sure, waiting for other people to get back to me. There’s some indication that this one, indeed, should follow DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, but I want to make sure :)
We should also move CSSAnimationTriggersEnabled to the experimental features section of the file, and add the category tag. FullScreenEnabled and EncryptedMediaAPIEnabled should also be moved down in the file.
Will have to peek at these!
Then we can just update the comment to indicate that custom values like DEFAULT_SERVICE_WORKERS_ENABLED are fine as long as they're thoughtful and consider ENABLE(EXPERIMENTAL_FEATURES), and that will take care of the other cases.
Makes sense.
Michael
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
participants (2)
-
Michael Catanzaro
-
Tim Horton