CI builds fail on all platforms with "ReferenceError: Can't find variable: WebAssembly"
Hi, our CI builds keep failing on all platforms with the following messages: Running stress/web-assembly-constructors-should-not-override-global-object-property.js.default Running stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode: Exception: ReferenceError: Can't find variable: WebAssembly stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode: global code@web-assembly-constructors-should-not-override-global-object-property.js:2:12 stress/web-assembly-constructors-should-not-override-global-object-property.js.default: Exception: ReferenceError: Can't find variable: WebAssembly stress/web-assembly-constructors-should-not-override-global-object-property.js.default: global code@web-assembly-constructors-should-not-override-global-object-property.js:2:12 stress/web-assembly-constructors-should-not-override-global-object-property.js.default: ERROR: Unexpected exit code: 3 FAIL: stress/web-assembly-constructors-should-not-override-global-object-property.js.default stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode: ERROR: Unexpected exit code: 3 FAIL: stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode The exceptions look quite similar to the output given at https://bugs.webkit.org/show_bug.cgi?id=192020 Eike -- GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A
Those tests should be checking if WebAssembly is enabled at all before running the test. Something like: if (this.WebAssembly) { ... put test here ... } Feel free to post a patch and I can review it. - Saam
On Sep 6, 2019, at 2:59 AM, Eike Rathke <erack@redhat.com> wrote:
Hi,
our CI builds keep failing on all platforms with the following messages:
Running stress/web-assembly-constructors-should-not-override-global-object-property.js.default Running stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode: Exception: ReferenceError: Can't find variable: WebAssembly stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode: global code@web-assembly-constructors-should-not-override-global-object-property.js:2:12 stress/web-assembly-constructors-should-not-override-global-object-property.js.default: Exception: ReferenceError: Can't find variable: WebAssembly stress/web-assembly-constructors-should-not-override-global-object-property.js.default: global code@web-assembly-constructors-should-not-override-global-object-property.js:2:12 stress/web-assembly-constructors-should-not-override-global-object-property.js.default: ERROR: Unexpected exit code: 3 FAIL: stress/web-assembly-constructors-should-not-override-global-object-property.js.default stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode: ERROR: Unexpected exit code: 3 FAIL: stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode
The exceptions look quite similar to the output given at https://bugs.webkit.org/show_bug.cgi?id=192020
Eike
-- GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
I’m about to move it into JSTests/wasm/stress. See https://bugs.webkit.org/show_bug.cgi?id=201551 <https://bugs.webkit.org/show_bug.cgi?id=201551>.
On Sep 6, 2019, at 11:31 AM, Saam Barati <sbarati@apple.com> wrote:
Those tests should be checking if WebAssembly is enabled at all before running the test. Something like: if (this.WebAssembly) { ... put test here ... }
Feel free to post a patch and I can review it.
- Saam
On Sep 6, 2019, at 2:59 AM, Eike Rathke <erack@redhat.com> wrote:
Hi,
our CI builds keep failing on all platforms with the following messages:
Running stress/web-assembly-constructors-should-not-override-global-object-property.js.default Running stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode: Exception: ReferenceError: Can't find variable: WebAssembly stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode: global code@web-assembly-constructors-should-not-override-global-object-property.js:2:12 stress/web-assembly-constructors-should-not-override-global-object-property.js.default: Exception: ReferenceError: Can't find variable: WebAssembly stress/web-assembly-constructors-should-not-override-global-object-property.js.default: global code@web-assembly-constructors-should-not-override-global-object-property.js:2:12 stress/web-assembly-constructors-should-not-override-global-object-property.js.default: ERROR: Unexpected exit code: 3 FAIL: stress/web-assembly-constructors-should-not-override-global-object-property.js.default stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode: ERROR: Unexpected exit code: 3 FAIL: stress/web-assembly-constructors-should-not-override-global-object-property.js.mini-mode
The exceptions look quite similar to the output given at https://bugs.webkit.org/show_bug.cgi?id=192020
Eike
-- GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
participants (3)
-
Eike Rathke
-
Mark Lam
-
Saam Barati