Name nitpick: "layout tests"
Hi folks. WebKit regression tests are in a directory named LayoutTests. The object the tests uses to do special test-specific operations is "layoutTestController". Both of these names are unwanted baggage, left over from when the test machinery was only good for testing layout. The directory should be eventually be named Tests or WebKitTests or RegressionTests. Eric Seidel can probably remember talking this over with me the day after we added the LayoutTests directory; sorry that I never fixed it! The object should be named testController, or perhaps someone can think of an even better name. A super-short one would probably be OK; the only practical problem is that we don’t want to choose a name that is likely to conflict with something we’ll add to HTML5 in the future. (I would have used the phrase “the web platform” instead of HTML5, which would be way better for pedants, but I think it would confuse others.) While we may be stuck with the current names for some time, we should not introduce new uses of the word "layout" in the context of our regression test machinery. That’s why the script is named run-webkit-tests, not run-layout-tests. I renamed that one in time, before we went wide with the WebKit project. It’s my fault we didn’t rename those other things sooner. As a first step, I suggest we make the test controller object available under its new name, and start using that name in new tests. Once we convert all the tests, we can drop the layoutTestController name entirely. Your thoughts? -- Darin
On Thu, Jul 29, 2010 at 10:59 AM, Darin Adler <darin@apple.com> wrote:
Hi folks.
WebKit regression tests are in a directory named LayoutTests. The object the tests uses to do special test-specific operations is "layoutTestController". Both of these names are unwanted baggage, left over from when the test machinery was only good for testing layout.
The directory should be eventually be named Tests or WebKitTests or RegressionTests. Eric Seidel can probably remember talking this over with me the day after we added the LayoutTests directory; sorry that I never fixed it!
The object should be named testController, or perhaps someone can think of an even better name. A super-short one would probably be OK; the only practical problem is that we don’t want to choose a name that is likely to conflict with something we’ll add to HTML5 in the future. (I would have used the phrase “the web platform” instead of HTML5, which would be way better for pedants, but I think it would confuse others.)
While we may be stuck with the current names for some time, we should not introduce new uses of the word "layout" in the context of our regression test machinery.
That’s why the script is named run-webkit-tests, not run-layout-tests. I renamed that one in time, before we went wide with the WebKit project. It’s my fault we didn’t rename those other things sooner.
As a first step, I suggest we make the test controller object available under its new name, and start using that name in new tests. Once we convert all the tests, we can drop the layoutTestController name entirely.
Your thoughts?
-- Darin
Sounds good to me. -- Dirk
I'm fine with it as well; the name confuses a lot of new contributors. Kenneth On Thu, Jul 29, 2010 at 3:15 PM, Dirk Pranke <dpranke@chromium.org> wrote:
On Thu, Jul 29, 2010 at 10:59 AM, Darin Adler <darin@apple.com> wrote:
Hi folks.
WebKit regression tests are in a directory named LayoutTests. The object the tests uses to do special test-specific operations is "layoutTestController". Both of these names are unwanted baggage, left over from when the test machinery was only good for testing layout.
The directory should be eventually be named Tests or WebKitTests or RegressionTests. Eric Seidel can probably remember talking this over with me the day after we added the LayoutTests directory; sorry that I never fixed it!
The object should be named testController, or perhaps someone can think of an even better name. A super-short one would probably be OK; the only practical problem is that we don’t want to choose a name that is likely to conflict with something we’ll add to HTML5 in the future. (I would have used the phrase “the web platform” instead of HTML5, which would be way better for pedants, but I think it would confuse others.)
While we may be stuck with the current names for some time, we should not introduce new uses of the word "layout" in the context of our regression test machinery.
That’s why the script is named run-webkit-tests, not run-layout-tests. I renamed that one in time, before we went wide with the WebKit project. It’s my fault we didn’t rename those other things sooner.
As a first step, I suggest we make the test controller object available under its new name, and start using that name in new tests. Once we convert all the tests, we can drop the layoutTestController name entirely.
Your thoughts?
-- Darin
Sounds good to me.
-- Dirk _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-- Kenneth Rohde Christiansen Technical Lead / Senior Software Engineer Qt Labs Americas, Nokia Technology Institute, INdT Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org
29.07.2010, в 10:59, Darin Adler написал(а):
The directory should be eventually be named Tests or WebKitTests or RegressionTests.
Ideally, the directory will have a unique first letter for better tab completion - so WebKitTests is a poor option from that point of view. I like the other two. - WBR, Alexey Proskuryakov
On Aug 2, 2010, at 4:28 AM, Alexey Proskuryakov wrote:
29.07.2010, в 10:59, Darin Adler написал(а):
The directory should be eventually be named Tests or WebKitTests or RegressionTests.
Ideally, the directory will have a unique first letter for better tab completion - so WebKitTests is a poor option from that point of view. I like the other two.
Tests collides with Tools (which is what WebKitTools should be renamed to).
On Mon, Aug 2, 2010 at 7:33 AM, Dan Bernstein <mitz@apple.com> wrote:
On Aug 2, 2010, at 4:28 AM, Alexey Proskuryakov wrote:
29.07.2010, в 10:59, Darin Adler написал(а):
The directory should be eventually be named Tests or WebKitTests or
RegressionTests.
Ideally, the directory will have a unique first letter for better tab
completion - so WebKitTests is a poor option from that point of view. I like the other two.
Tests collides with Tools (which is what WebKitTools should be renamed to).
That sounds like a vote for RegressionTests -Darin
On Mon, Aug 2, 2010 at 9:40 AM, Darin Fisher <darin@chromium.org> wrote:
On Mon, Aug 2, 2010 at 7:33 AM, Dan Bernstein <mitz@apple.com> wrote:
On Aug 2, 2010, at 4:28 AM, Alexey Proskuryakov wrote:
29.07.2010, в 10:59, Darin Adler написал(а):
The directory should be eventually be named Tests or WebKitTests or RegressionTests.
Ideally, the directory will have a unique first letter for better tab completion - so WebKitTests is a poor option from that point of view. I like the other two.
Tests collides with Tools (which is what WebKitTools should be renamed to).
That sounds like a vote for RegressionTests
I know I'm new around here, but my .02: This seems like a lot of busy work that will never really complete. We'll end up with "LayoutTests" in some places and "RegressionTests" in others, indefinitely. It will be even more messy than having the bad name consistently. Keep in mind that there are places that refer to "WebKit's LayoutTests" that aren't even under the WebKit project's control: http://www.google.com/search?q=webkit+layout+tests+-webkit.org It seems simpler and better to me to just have a note on the page on webkit.org that talks about LayoutTests describing the origins of the name and let sleeping dogs lie. - a
I don’t buy in to this at all. We have done many successful renaming projects in the past. The future is bigger than the past and it’s worthwhile to do maintenance like this. -- Darin
On Mon, Aug 2, 2010 at 7:33 AM, Dan Bernstein <mitz@apple.com> wrote:
On Aug 2, 2010, at 4:28 AM, Alexey Proskuryakov wrote:
29.07.2010, в 10:59, Darin Adler написал(а):
The directory should be eventually be named Tests or WebKitTests or
RegressionTests.
Ideally, the directory will have a unique first letter for better tab
completion - so WebKitTests is a poor option from that point of view. I
like the other two.
Tests collides with Tools (which is what
WebKitTools should be renamed
to).
That sounds like a vote for RegressionTests
-Darin
I prefer RegressionTests. Zoltan
participants (8)
-
Aaron Boodman
-
Alexey Proskuryakov
-
Dan Bernstein
-
Darin Adler
-
Darin Fisher
-
Dirk Pranke
-
Kenneth Christiansen
-
Zoltan Horvath