WebKit API native coding style?
Hi, I would like to know whether it's ok to adopt the respective platform's coding style in the WebKit API that a port exposes. I am working on the Haiku port and saw that other ports do this, but I thought I'd better ask before I introduce changes that may eventually be rejected. :-) Best regards, -Stephan
On Fri, Feb 19, 2010 at 3:30 PM, Stephan Assmus <superstippi@gmx.de> wrote:
I would like to know whether it's ok to adopt the respective platform's coding style in the WebKit API that a port exposes. I am working on the Haiku port and saw that other ports do this, but I thought I'd better ask before I introduce changes that may eventually be rejected. :-)
Yes, this is ok. I'm sure you could find the discussion in the list archives with some searches involving the words "port" and "style". ;)
FYI, check-webkit-style now supports the following via configuration variables: (1) Suppressing certain style checks (based on category name) for particular files/folders (2) Enabling custom style checks (again based on category name) for particular files/folders (3) Skipping the style check entirely for particular files/folders Option (2), of course, requires writing additional code for the custom style checks. A consequence of (2) is that not only can ports suppress WebKit style checks -- they can also check for and enforce port-specific style rules. --Chris On Fri, Feb 19, 2010 at 7:18 AM, Evan Martin <evan@chromium.org> wrote:
On Fri, Feb 19, 2010 at 3:30 PM, Stephan Assmus <superstippi@gmx.de> wrote:
I would like to know whether it's ok to adopt the respective platform's coding style in the WebKit API that a port exposes. I am working on the Haiku port and saw that other ports do this, but I thought I'd better ask before I introduce changes that may eventually be rejected. :-)
Yes, this is ok. I'm sure you could find the discussion in the list archives with some searches involving the words "port" and "style". ;) _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Fri, Feb 19, 2010 at 6:30 AM, Stephan Assmus <superstippi@gmx.de> wrote:
Hi,
I would like to know whether it's ok to adopt the respective platform's coding style in the WebKit API that a port exposes. I am working on the Haiku port and saw that other ports do this, but I thought I'd better ask before I introduce changes that may eventually be rejected. :-)
Best regards, -Stephan
For the Chromium WebKit API, we decided to go with the WebKit coding style (instead of Google C++ style used by Chromium), so that it would be easier for the WebKit community to maintain . I think that has been helpful, and I bet you'd probably benefit from doing the same. This way people working in the WebKit codebase only need to know one set of rules. At any rate, I believe you are free to make it match another style as Evan pointed out, but I thought it worth sharing our positive experience w/ using WebKit style. Regards, -Darin
On Feb 19, 2010, at 6:30 AM, Stephan Assmus wrote:
Hi,
I would like to know whether it's ok to adopt the respective platform's coding style in the WebKit API that a port exposes. I am working on the Haiku port and saw that other ports do this, but I thought I'd better ask before I introduce changes that may eventually be rejected. :-)
In general it's ok. For the mac port, we are considering using the standard Apple Objective-C style only in public headers, and using WebKit style in all implementation files. As part of this, we'd propose that the standard WebKit way of naming pointers to Objective-C classes should be "Foo*" instead of "Foo *", to match our handling of C++ classes and other pointers. Regards, Maciej
participants (5)
-
Chris Jerdonek
-
Darin Fisher
-
Evan Martin
-
Maciej Stachowiak
-
Stephan Assmus