Problems with code review tool
Hi, Often when I publish code reviews on bugs.webkit.org, my browser tab gets stuck waiting for ews.webkit.org. Reloading the bug shows my comments, but because the submission doesn't complete, the review comments are still treated as pending by the tool, so publishing again causes duplicates. Has anyone else run into this? (My browser is Chrome on macOS.) Thanks, -Ken -- I support flexible work schedules, and I’m sending this email now because it is within the hours I’m working today. Please do not feel obliged to reply straight away - I understand that you will reply during the hours you work, which may not match mine. (credit: jparent@)
Hi Ken, I think this is a known problem. Unfortunately, this happens to me a few times a year as well. - Saam
On Sep 21, 2020, at 2:26 PM, Ken Russell <kbr@google.com> wrote:
Hi,
Often when I publish code reviews on bugs.webkit.org <http://bugs.webkit.org/>, my browser tab gets stuck waiting for ews.webkit.org <http://ews.webkit.org/>. Reloading the bug shows my comments, but because the submission doesn't complete, the review comments are still treated as pending by the tool, so publishing again causes duplicates.
Has anyone else run into this?
(My browser is Chrome on macOS.)
Thanks,
-Ken
-- I support flexible work schedules, and I’m sending this email now because it is within the hours I’m working today. Please do not feel obliged to reply straight away - I understand that you will reply during the hours you work, which may not match mine. (credit: jparent@)
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Thanks Saam for your reply. Unfortunately this happens nearly every time I use the code review tool. Aakash, since this seems to be related to the EWS, is it something you might be able to debug? I also frequently see bugs.webkit.org tabs display the spinner forever, and it seems to be caused by loading resources from ews.webkit.org. It's likely the same problem. Thanks, -Ken On Tue, Sep 22, 2020 at 7:25 AM Saam Barati <sbarati@apple.com> wrote:
Hi Ken,
I think this is a known problem. Unfortunately, this happens to me a few times a year as well.
- Saam
On Sep 21, 2020, at 2:26 PM, Ken Russell <kbr@google.com> wrote:
Hi,
Often when I publish code reviews on bugs.webkit.org, my browser tab gets stuck waiting for ews.webkit.org. Reloading the bug shows my comments, but because the submission doesn't complete, the review comments are still treated as pending by the tool, so publishing again causes duplicates.
Has anyone else run into this?
(My browser is Chrome on macOS.)
Thanks,
-Ken
-- I support flexible work schedules, and I’m sending this email now because it is within the hours I’m working today. Please do not feel obliged to reply straight away - I understand that you will reply during the hours you work, which may not match mine. (credit: jparent@)
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
-- I support flexible work schedules, and I’m sending this email now because it is within the hours I’m working today. Please do not feel obliged to reply straight away - I understand that you will reply during the hours you work, which may not match mine. (credit: jparent@)
Interesting. I haven't noticed such problem myself and wasn't aware of this issue. I was aware that the EWS status-bubble loading time has been increasing steadily as we have been increasing number of EWS queues. Tracked in https://bugs.webkit.org/show_bug.cgi?id=214821. I will prioritize fixing it. Also bugs.webkit.org loads ews status-bubbles from ews.webkit.org in an iframe. I never noticed any issue on bugs.webkit.org itself because of slow loading of status-bubble. It would be interesting to know if this is a browser specific issue. Thanks Aakash
On Sep 23, 2020, at 5:39 PM, Ken Russell <kbr@google.com> wrote:
Thanks Saam for your reply.
Unfortunately this happens nearly every time I use the code review tool.
Aakash, since this seems to be related to the EWS, is it something you might be able to debug? I also frequently see bugs.webkit.org <http://bugs.webkit.org/> tabs display the spinner forever, and it seems to be caused by loading resources from ews.webkit.org <http://ews.webkit.org/>. It's likely the same problem.
Thanks,
-Ken
On Tue, Sep 22, 2020 at 7:25 AM Saam Barati <sbarati@apple.com <mailto:sbarati@apple.com>> wrote: Hi Ken,
I think this is a known problem. Unfortunately, this happens to me a few times a year as well.
- Saam
On Sep 21, 2020, at 2:26 PM, Ken Russell <kbr@google.com <mailto:kbr@google.com>> wrote:
Hi,
Often when I publish code reviews on bugs.webkit.org <http://bugs.webkit.org/>, my browser tab gets stuck waiting for ews.webkit.org <http://ews.webkit.org/>. Reloading the bug shows my comments, but because the submission doesn't complete, the review comments are still treated as pending by the tool, so publishing again causes duplicates.
Has anyone else run into this?
(My browser is Chrome on macOS.)
Thanks,
-Ken
-- I support flexible work schedules, and I’m sending this email now because it is within the hours I’m working today. Please do not feel obliged to reply straight away - I understand that you will reply during the hours you work, which may not match mine. (credit: jparent@)
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org <mailto:webkit-dev@lists.webkit.org> https://lists.webkit.org/mailman/listinfo/webkit-dev <https://lists.webkit.org/mailman/listinfo/webkit-dev>
-- I support flexible work schedules, and I’m sending this email now because it is within the hours I’m working today. Please do not feel obliged to reply straight away - I understand that you will reply during the hours you work, which may not match mine. (credit: jparent@)
Thanks for your reply. I wouldn't be surprised if the form posting hanging is a Chrome-specific problem, and have filed http://crbug.com/1132508 about it. Chrome also usually displays the spinner forever for individual bugs on bugs.webkit.org because the ews.webkit.org iframe never finishes loading. It's probably the same reason the form posting hangs. Thanks for looking into it. -Ken On Wed, Sep 23, 2020 at 3:18 PM Aakash Jain <aakash_jain@apple.com> wrote:
Interesting. I haven't noticed such problem myself and wasn't aware of this issue. I was aware that the EWS status-bubble loading time has been increasing steadily as we have been increasing number of EWS queues. Tracked in https://bugs.webkit.org/show_bug.cgi?id=214821. I will prioritize fixing it.
Also bugs.webkit.org loads ews status-bubbles from ews.webkit.org in an iframe. I never noticed any issue on bugs.webkit.org itself because of slow loading of status-bubble. It would be interesting to know if this is a browser specific issue.
Thanks Aakash
On Sep 23, 2020, at 5:39 PM, Ken Russell <kbr@google.com> wrote:
Thanks Saam for your reply.
Unfortunately this happens nearly every time I use the code review tool.
Aakash, since this seems to be related to the EWS, is it something you might be able to debug? I also frequently see bugs.webkit.org tabs display the spinner forever, and it seems to be caused by loading resources from ews.webkit.org. It's likely the same problem.
Thanks,
-Ken
On Tue, Sep 22, 2020 at 7:25 AM Saam Barati <sbarati@apple.com> wrote:
Hi Ken,
I think this is a known problem. Unfortunately, this happens to me a few times a year as well.
- Saam
On Sep 21, 2020, at 2:26 PM, Ken Russell <kbr@google.com> wrote:
Hi,
Often when I publish code reviews on bugs.webkit.org, my browser tab gets stuck waiting for ews.webkit.org. Reloading the bug shows my comments, but because the submission doesn't complete, the review comments are still treated as pending by the tool, so publishing again causes duplicates.
Has anyone else run into this?
(My browser is Chrome on macOS.)
Thanks,
-Ken
-- I support flexible work schedules, and I’m sending this email now because it is within the hours I’m working today. Please do not feel obliged to reply straight away - I understand that you will reply during the hours you work, which may not match mine. (credit: jparent@)
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
-- I support flexible work schedules, and I’m sending this email now because it is within the hours I’m working today. Please do not feel obliged to reply straight away - I understand that you will reply during the hours you work, which may not match mine. (credit: jparent@)
-- I support flexible work schedules, and I’m sending this email now because it is within the hours I’m working today. Please do not feel obliged to reply straight away - I understand that you will reply during the hours you work, which may not match mine. (credit: jparent@)
participants (3)
-
Aakash Jain
-
Ken Russell
-
Saam Barati