We seem to have a zillion EFL patches up for review. Who are the EFL reviewers? (I think part of the trouble is that it seems the EFL port is trying to do too much in WebKit. I'm not sure where the EFL browser is, but some of the patches look like they should be re-directed to that project instead of WebKit.) -eric
Mostly myself and Kenneth. We do what we can, but we also to work on our stuff (as everybody else :). It really needs other reviewers to help out with reviewing, since EFL port guys are working really hard on it. On Sun, Apr 10, 2011 at 7:51 PM, Eric Seidel <eric@webkit.org> wrote:
We seem to have a zillion EFL patches up for review.
Who are the EFL reviewers?
(I think part of the trouble is that it seems the EFL port is trying to do too much in WebKit. I'm not sure where the EFL browser is, but some of the patches look like they should be re-directed to that project instead of WebKit.)
-eric
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-- --Antonio Gomes
The problem is that as I am not working on the port myself, I find it quite hard to review their API's without getting input from someone else working on EFL. I think Antonio feels likewise. Kenneth On Mon, Apr 11, 2011 at 2:13 AM, Antonio Gomes <tonikitoo@gmail.com> wrote:
Mostly myself and Kenneth. We do what we can, but we also to work on our stuff (as everybody else :). It really needs other reviewers to help out with reviewing, since EFL port guys are working really hard on it.
On Sun, Apr 10, 2011 at 7:51 PM, Eric Seidel <eric@webkit.org> wrote:
We seem to have a zillion EFL patches up for review. Who are the EFL reviewers? (I think part of the trouble is that it seems the EFL port is trying to do too much in WebKit. I'm not sure where the EFL browser is, but some of the patches look like they should be re-directed to that project instead of WebKit.) -eric _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-- --Antonio Gomes
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-- Kenneth Rohde Christiansen Senior Engineer Application and Service Frameworks, Nokia Danmark A/S Phone +45 4093 0598 / E-mail kenneth.christiansen at gmail.com http://codeposts.blogspot.com ﹆﹆﹆
Hi, Is it possible to promote some other peoples to reviewers in the EFL port? Tomasz
The problem is that as I am not working on the port myself, I find it quite hard to review their API's without getting input from someone else working on EFL.
I think Antonio feels likewise.
Kenneth
On Mon, Apr 11, 2011 at 2:13 AM, Antonio Gomes<tonikitoo@gmail.com> wrote:
Mostly myself and Kenneth. We do what we can, but we also to work on our stuff (as everybody else :). It really needs other reviewers to help out with reviewing, since EFL port guys are working really hard on it.
On Sun, Apr 10, 2011 at 7:51 PM, Eric Seidel<eric@webkit.org> wrote:
We seem to have a zillion EFL patches up for review. Who are the EFL reviewers? (I think part of the trouble is that it seems the EFL port is trying to do too much in WebKit. I'm not sure where the EFL browser is, but some of the patches look like they should be re-directed to that project instead of WebKit.) -eric _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-- --Antonio Gomes
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Mon, Apr 11, 2011 at 3:40 AM, Tomasz Morawski <t.morawski@samsung.com>wrote:
Hi, Is it possible to promote some other peoples to reviewers in the EFL port?
A step that I usually suggest to chromium folks before becoming reviewers is to actually do reviews on patches. Do everything except the r+ (with the submitter's permission). These are helpful to show when the reviewer nomination happens (as supporting evidence). If there are folks in the efl community who feel that they like to be reviewers, perhaps they can start doing this. (Then someone who is a reviewer can come along and give the final r+. I view it as a kind of mentorship thing because the reviewer should do a review as well and then the original person can learn from that if there were things that they missed.) dave
Tomasz
The problem is that as I am not working on the port myself, I find it
quite hard to review their API's without getting input from someone else working on EFL.
I think Antonio feels likewise.
Kenneth
On Mon, Apr 11, 2011 at 2:13 AM, Antonio Gomes<tonikitoo@gmail.com> wrote:
Mostly myself and Kenneth. We do what we can, but we also to work on our stuff (as everybody else :). It really needs other reviewers to help out with reviewing, since EFL port guys are working really hard on it.
On Sun, Apr 10, 2011 at 7:51 PM, Eric Seidel<eric@webkit.org> wrote:
We seem to have a zillion EFL patches up for review. Who are the EFL reviewers? (I think part of the trouble is that it seems the EFL port is trying to do too much in WebKit. I'm not sure where the EFL browser is, but some of the patches look like they should be re-directed to that project instead of WebKit.) -eric _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-- --Antonio Gomes
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
That sounds like a very good idea and I would be happy to help along giving the final r+ Kenneth On Mon, Apr 11, 2011 at 6:08 PM, David Levin <levin@chromium.org> wrote:
On Mon, Apr 11, 2011 at 3:40 AM, Tomasz Morawski <t.morawski@samsung.com> wrote:
Hi, Is it possible to promote some other peoples to reviewers in the EFL port?
A step that I usually suggest to chromium folks before becoming reviewers is to actually do reviews on patches. Do everything except the r+ (with the submitter's permission). These are helpful to show when the reviewer nomination happens (as supporting evidence). If there are folks in the efl community who feel that they like to be reviewers, perhaps they can start doing this. (Then someone who is a reviewer can come along and give the final r+. I view it as a kind of mentorship thing because the reviewer should do a review as well and then the original person can learn from that if there were things that they missed.) dave
Tomasz
The problem is that as I am not working on the port myself, I find it quite hard to review their API's without getting input from someone else working on EFL.
I think Antonio feels likewise.
Kenneth
On Mon, Apr 11, 2011 at 2:13 AM, Antonio Gomes<tonikitoo@gmail.com> wrote:
Mostly myself and Kenneth. We do what we can, but we also to work on our stuff (as everybody else :). It really needs other reviewers to help out with reviewing, since EFL port guys are working really hard on it.
On Sun, Apr 10, 2011 at 7:51 PM, Eric Seidel<eric@webkit.org> wrote:
We seem to have a zillion EFL patches up for review. Who are the EFL reviewers? (I think part of the trouble is that it seems the EFL port is trying to do too much in WebKit. I'm not sure where the EFL browser is, but some of the patches look like they should be re-directed to that project instead of WebKit.) -eric _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-- --Antonio Gomes
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-- Kenneth Rohde Christiansen Senior Engineer Application and Service Frameworks, Nokia Danmark A/S Phone +45 4093 0598 / E-mail kenneth.christiansen at gmail.com http://codeposts.blogspot.com ﹆﹆﹆
On Mon, Apr 11, 2011 at 1:08 PM, David Levin <levin@chromium.org> wrote:
Hi, Is it possible to promote some other peoples to reviewers in the EFL port?
A step that I usually suggest to chromium folks before becoming reviewers is to actually do reviews on patches. Do everything except the r+ (with the submitter's permission).
We (me, Lucas De Marchi, and Rafael Antognolli) are already informally reviewing patches; our reviews are then used by an official reviewer that either gives a r+ or rs+ based on our comments. I'm not currently allocated to work on WebKit, but if that would speed up the review queue (and provide some relief on Antonio and Kenneth, who have been primarily reviewing EFL patches), I could be a reviewer, yes. However, only one reviewer isn't optimal; I've worked mostly on the build system (besides quick fixes here and there), and Rafael and Lucas worked deep on the port, so they know more about how things work internally. It would be nice if one of them could also become a reviewer, but I can't speak for them. Leandro
On Sun, Apr 10, 2011 at 8:51 PM, Eric Seidel <eric@webkit.org> wrote:
We seem to have a zillion EFL patches up for review. Who are the EFL reviewers?
As other mentioned, as of now there are none. I've been doing some informal reviews, but it seems that I'm not receiving all the zillions of patches. Last Friday I reviewed all the bugs I was CC'ed and I didn't notice there were more pending in which I was not CC'ed. Another problem is that sometimes people disappear. I reviewed some patches asking for clarification or to change something and they were never answered. I think the best to do is just to close these bugs. thanks Lucas De Marchi
participants (7)
-
Antonio Gomes
-
David Levin
-
Eric Seidel
-
Kenneth Rohde Christiansen
-
Leandro Pereira
-
Lucas De Marchi
-
Tomasz Morawski