request to add SH4 platform
Hi, I would like to gratify you for your great work. I'm working in porting WebKit for SH4 platform. I had some problems related to non-aligned memory accesses as done in WebCore::equal(StringImpl* string, const UChar* characters, unsigned length) function for the SH4 platform. My question is: can you add support in WebKit sources for SH4 platform? In attachment you can find two little patches (against WebKit trunk) that introduce the SH4 platform and solves the non-aligned memory accesses (I use the same code as per ARM platform). Best regards. Tnx, Simone.
Hi Simone, Code contribution guidelines are here: http://webkit.org/coding/contributing.html Please open a new bug on <https://bugs.webkit.org/> and post your patch there with its review flag set. (Feel free to CC me on the bug.) Note that your patch should also have ChangeLog entries, as explained on the webkit.org web site. Looking at the two patches, I think they're fine as-is and would have no problem landing in the source tree. Thanks for your contribution! Dave ________________________________ From: Simone Fiorentino <simone.fiorentino@consulenti.fastweb.it> To: webkit-dev@lists.webkit.org Sent: Thursday, March 5, 2009 5:33:27 AM Subject: [webkit-dev] request to add SH4 platform Hi, I would like to gratify you for your great work. I'm working in porting WebKit for SH4 platform. I had some problems related to non-aligned memory accesses as done in WebCore::equal(StringImpl* string, const UChar* characters, unsigned length) function for the SH4 platform. My question is: can you add support in WebKit sources for SH4 platform? In attachment you can find two little patches (against WebKit trunk) that introduce the SH4 platform and solves the non-aligned memory accesses (I use the same code as per ARM platform). Best regards. Tnx, Simone.
participants (2)
-
David Kilzer
-
Simone Fiorentino