Re: [webkit-dev] currently failing regression tests on Mac OS X Leopard
On Mar 6, 2009, at 8:36 AM, Dimitri Glazkov wrote:
Since I checked in the failing tests, I feel responsible, too.
I'd say let's remove these tests and work to get the CSS2.1 suite updated. WDYT?
I think it's an acceptable strategy to have these new separate tests. I just think someone needs to generate the correct expected results. Changing the CSS 2.1 suite itself would be OK, but I don't think it would have a big effect. We'd still need correct expected results. I think the main question is who will generate expected results that are correct for Mac OS X. -- Darin
Jungshik already did, just waiting for review: https://bugs.webkit.org/show_bug.cgi?id=23482 :DG< On Fri, Mar 6, 2009 at 9:20 AM, Darin Adler <darin@apple.com> wrote:
On Mar 6, 2009, at 8:36 AM, Dimitri Glazkov wrote:
Since I checked in the failing tests, I feel responsible, too.
I'd say let's remove these tests and work to get the CSS2.1 suite updated. WDYT?
I think it's an acceptable strategy to have these new separate tests. I just think someone needs to generate the correct expected results.
Changing the CSS 2.1 suite itself would be OK, but I don't think it would have a big effect. We'd still need correct expected results.
I think the main question is who will generate expected results that are correct for Mac OS X.
-- Darin
Oh wait. He did an in-place update patch. I'll ask him. :DG< On Fri, Mar 6, 2009 at 9:25 AM, Dimitri Glazkov <dglazkov@chromium.org> wrote:
Jungshik already did, just waiting for review: https://bugs.webkit.org/show_bug.cgi?id=23482
:DG<
On Fri, Mar 6, 2009 at 9:20 AM, Darin Adler <darin@apple.com> wrote:
On Mar 6, 2009, at 8:36 AM, Dimitri Glazkov wrote:
Since I checked in the failing tests, I feel responsible, too.
I'd say let's remove these tests and work to get the CSS2.1 suite updated. WDYT?
I think it's an acceptable strategy to have these new separate tests. I just think someone needs to generate the correct expected results.
Changing the CSS 2.1 suite itself would be OK, but I don't think it would have a big effect. We'd still need correct expected results.
I think the main question is who will generate expected results that are correct for Mac OS X.
-- Darin
On Mar 6, 2009, at 9:25 AM, Dimitri Glazkov wrote:
Jungshik already did, just waiting for review: https://bugs.webkit.org/show_bug.cgi?id=23482
I am really confused now. I thought we agreed to leave the CSS 2.1 tests alone unless the official test suite changed. I'd like to see a patch that just fixes the current regression test failures and doesn't make additional changes. -- Darin
participants (2)
-
Darin Adler
-
Dimitri Glazkov