Is anyone maintaining Nicosia scrolling code?
There’s a bunch of code in Source/WebCore/page/scrolling/nicosia/ that I keep breaking with scrolling tree refactoring. Most of it it stubs. Is anyone maintaining this code, because it obviously doesn’t work, and I’d like to remove the maintenance burden. Simon
On Sat, Feb 23, 2019, at 2:47 AM, Simon Fraser wrote:
There’s a bunch of code in Source/WebCore/page/scrolling/nicosia/ that I keep breaking with scrolling tree refactoring. Most of it it stubs. Is anyone maintaining this code, because it obviously doesn’t work, and I’d like to remove the maintenance burden.
I added the stubs there, and was planning to start adding actual implementations there in the following weeks, now that a new release cycle was just entered. I wouldn't mind disabling or removing the code temporarily in order to enable you an easier time refactoring around it. But given that the async scrolling capability is something we plan to add support for in the WPE and GTK ports, I'd appreciate some input about the scope and the timeframe of your work and possibility of sharing as much of the implementation as possible between different ports. Cheers, Zan
Simon
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
On Sat, Feb 23, 2019 at 1:30 PM <zan@falconsigh.net> wrote:
On Sat, Feb 23, 2019, at 2:47 AM, Simon Fraser wrote:
There’s a bunch of code in Source/WebCore/page/scrolling/nicosia/ that I keep breaking with scrolling tree refactoring. Most of it it stubs. Is anyone maintaining this code, because it obviously doesn’t work, and I’d like to remove the maintenance burden.
I added the stubs there, and was planning to start adding actual implementations there in the following weeks, now that a new release cycle was just entered.
I wouldn't mind disabling or removing the code temporarily in order to enable you an easier time refactoring around it.
Please do. It is unreasonable to push maintenance burden of this dead code to people who are working on async scrolling. See https://bugs.webkit.org/show_bug.cgi?id=198292 for an example. antti
But given that the async scrolling capability is something we plan to add support for in the WPE and GTK ports, I'd appreciate some input about the scope and the timeframe of your work and possibility of sharing as much of the implementation as possible between different ports.
Cheers, Zan
Simon
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
On Feb 23, 2019, at 3:29 AM, zan@falconsigh.net wrote:
On Sat, Feb 23, 2019, at 2:47 AM, Simon Fraser wrote:
There’s a bunch of code in Source/WebCore/page/scrolling/nicosia/ that I keep breaking with scrolling tree refactoring. Most of it it stubs. Is anyone maintaining this code, because it obviously doesn’t work, and I’d like to remove the maintenance burden.
I added the stubs there, and was planning to start adding actual implementations there in the following weeks, now that a new release cycle was just entered.
I wouldn't mind disabling or removing the code temporarily in order to enable you an easier time refactoring around it. But given that the async scrolling capability is something we plan to add support for in the WPE and GTK ports, I'd appreciate some input about the scope and the timeframe of your work and possibility of sharing as much of the implementation as possible between different ports.
I’m hitting Nicosia compile issues again (https://bugs.webkit.org/show_bug.cgi?id=208282) and the last Nicosia-related commit was on October 3. Does Nicosia qualify as a “science project” in the sense listed at https://webkit.org/project/ <https://webkit.org/project/> . Googling for Nicosia finds no technology-related hits on the first page. Simon
participants (3)
-
Antti Koivisto
-
Simon Fraser
-
zan＠falconsigh.net