Some landed patches have incorrect date in commit messages and ChangeLog
Hi, I noticed that several patches landed recently have the incorrect date put in the commit messages and ChangeLog. Please fix the incorrect information in ChangeLog. For the commit messages, anyone know if we can fix them or not? Please make sure the correct date is used when you land your patch manually. Thanks. Jian
On Mon, Aug 9, 2010 at 10:51 AM, Jian Li <jianli@chromium.org> wrote:
Please make sure the correct date is used when you land your patch manually.
This is one of my favorite features of webkit-patch, which seems to do the right thing at least in the case of git. Martin
What about the case where between the time you submit the patch and it gets committed, a day passes by...does the commit queue fix this automatically, or does someone have to go back and fix it manually? Fady On Mon, Aug 9, 2010 at 1:51 PM, Jian Li <jianli@chromium.org> wrote:
Hi,
I noticed that several patches landed recently have the incorrect date put in the commit messages and ChangeLog. Please fix the incorrect information in ChangeLog. For the commit messages, anyone know if we can fix them or not?
Please make sure the correct date is used when you land your patch manually. Thanks.
Jian
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Yes. The commit-queue uses svn-apply which knows how to fix the date using: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/VCSUtils.pm#L1231 -eric On Mon, Aug 9, 2010 at 2:06 PM, Fady Samuel <fsamuel@google.com> wrote:
What about the case where between the time you submit the patch and it gets committed, a day passes by...does the commit queue fix this automatically, or does someone have to go back and fix it manually?
Fady
On Mon, Aug 9, 2010 at 1:51 PM, Jian Li <jianli@chromium.org> wrote:
Hi, I noticed that several patches landed recently have the incorrect date put in the commit messages and ChangeLog. Please fix the incorrect information in ChangeLog. For the commit messages, anyone know if we can fix them or not? Please make sure the correct date is used when you land your patch manually. Thanks. Jian
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Mon, Aug 9, 2010 at 10:51 AM, Jian Li <jianli@chromium.org> wrote:
I noticed that several patches landed recently have the incorrect date put in the commit messages and ChangeLog. Please fix the incorrect information in ChangeLog. For the commit messages, anyone know if we can fix them or not? Please make sure the correct date is used when you land your patch manually.
I didn't realize this was a bad thing. I thought it was potentially useful information in the ChangeLog to know the date a change was written, especially since the commit time is available from SVN already; obviously the position within the ChangeLog shows where it lies in the history of the project. I agree that if tools don't manage this it will be easy to overlook.
Hi, I'm sorry that I did it yesterday. Usually I use webkit-patch. But that patch had 2 bug URLs and webkit-patch didn't work for it. So I rewrote ChangeLogs - with the wrong way. If "webkit-patch land" support --bug-id, it might be helpful for my case. Thanks. -- morita On Tue, Aug 10, 2010 at 2:51 AM, Jian Li <jianli@chromium.org> wrote:
Hi, I noticed that several patches landed recently have the incorrect date put in the commit messages and ChangeLog. Please fix the incorrect information in ChangeLog. For the commit messages, anyone know if we can fix them or not? Please make sure the correct date is used when you land your patch manually. Thanks. Jian
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-- morita
participants (6)
-
Eric Seidel
-
Evan Martin
-
Fady Samuel
-
Hajime Morita
-
Jian Li
-
Martin Robinson