What about the case where between the time you submit the patch and it gets committed, a day passes by...does the commit queue fix this automatically, or does someone have to go back and fix it manually? Fady On Mon, Aug 9, 2010 at 1:51 PM, Jian Li <jianli@chromium.org> wrote:

Hi,

I noticed that several patches landed recently have the incorrect date put in the commit messages and ChangeLog. Please fix the incorrect information in ChangeLog. For the commit messages, anyone know if we can fix them or not?

Please make sure the correct date is used when you land your patch manually. Thanks.

Jian

_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

On Mon, Aug 9, 2010 at 10:51 AM, Jian Li <jianli@chromium.org> wrote:

I noticed that several patches landed recently have the incorrect date put in the commit messages and ChangeLog. Please fix the incorrect information in ChangeLog. For the commit messages, anyone know if we can fix them or not? Please make sure the correct date is used when you land your patch manually.

I didn't realize this was a bad thing. I thought it was potentially useful information in the ChangeLog to know the date a change was written, especially since the commit time is available from SVN already; obviously the position within the ChangeLog shows where it lies in the history of the project. I agree that if tools don't manage this it will be easy to overlook.