JavaScriptCore cleanup
Now that SquirrelFish Extreme has landed, we should perform some of the cleanup that we've been itching to do for a while now. A few items immediately come to mind, but I am sure there are others: 1) Directory reorganization. We should split the code into more logical units than kjs, pcre, wrec, and VM (which is also in capitals in violation of our style guidelines). Some things in the VM directory also don't really belong there. Sam and Maciej talked about this in detail in the past, and I think everyone is essentially in agreement about what to do, so we should do it in the next few days. 2) Bringing all source files up to our coding style guidelines. Sam, myself, and others have been doing this bit by bit, but we should finish the job. 3) Removing the KJS namespace. There are a few options: 1) JavaScriptCore 2) JSC 3) JSCore 4) SFX A lot of people feel that #1 is too long. I like #2, and think that #4. We should decide on something and carry out the change soon. Cameron
I like JSC or SFX or JSCore. JavaScriptCore is too long. - Maciej On Sep 7, 2008, at 1:56 PM, Cameron Zwarich wrote:
Now that SquirrelFish Extreme has landed, we should perform some of the cleanup that we've been itching to do for a while now. A few items immediately come to mind, but I am sure there are others:
1) Directory reorganization. We should split the code into more logical units than kjs, pcre, wrec, and VM (which is also in capitals in violation of our style guidelines). Some things in the VM directory also don't really belong there. Sam and Maciej talked about this in detail in the past, and I think everyone is essentially in agreement about what to do, so we should do it in the next few days.
2) Bringing all source files up to our coding style guidelines. Sam, myself, and others have been doing this bit by bit, but we should finish the job.
3) Removing the KJS namespace. There are a few options:
1) JavaScriptCore
2) JSC
3) JSCore
4) SFX
A lot of people feel that #1 is too long. I like #2, and think that #4. We should decide on something and carry out the change soon.
Cameron _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
I like JSCore. dave On Sep 7, 2008, at 7:16 PM, Maciej Stachowiak wrote:
I like JSC or SFX or JSCore. JavaScriptCore is too long.
- Maciej
On Sep 7, 2008, at 1:56 PM, Cameron Zwarich wrote:
Now that SquirrelFish Extreme has landed, we should perform some of the cleanup that we've been itching to do for a while now. A few items immediately come to mind, but I am sure there are others:
1) Directory reorganization. We should split the code into more logical units than kjs, pcre, wrec, and VM (which is also in capitals in violation of our style guidelines). Some things in the VM directory also don't really belong there. Sam and Maciej talked about this in detail in the past, and I think everyone is essentially in agreement about what to do, so we should do it in the next few days.
2) Bringing all source files up to our coding style guidelines. Sam, myself, and others have been doing this bit by bit, but we should finish the job.
3) Removing the KJS namespace. There are a few options:
1) JavaScriptCore
2) JSC
3) JSCore
4) SFX
A lot of people feel that #1 is too long. I like #2, and think that #4. We should decide on something and carry out the change soon.
Cameron _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Sep 7, 2008, at 5:34 PM, Sam Weinig wrote:
like JSCore or JSC. I prefer JSCore.
I know I had JSCore on my list of ok names, but now that I think about it more I really don't like the half-abbreviation. And this namespace, unlike the WebCore namespace, is used quite a bit in code so short is good. - Maciej
-Sam
For what it is worth I like JSC. While short it is probably less confusing and eyebrow-raising than other abbreviations I have seen in WebKit code, like WTF. WTF? WTF! Regards, Ryan
participants (6)
-
Cameron Zwarich
-
Dan Bernstein
-
David Hyatt
-
Maciej Stachowiak
-
Ryan Leavengood
-
Sam Weinig