Have EWS compile patches that are review+ once it is done with the ones that are review?
It’s not great that if I review a patch that means it won’t get EWS results. Maybe the EWS could be changed to test out “review+” patches once it gets done with all the “review?” patches? Is that practical? -- Darin
If they are r+'ed, there is a big change that they are soon to become committed, so maybe they should get even more priority? Kenneth On Fri, Sep 24, 2010 at 2:25 PM, Darin Adler <darin@apple.com> wrote:
It’s not great that if I review a patch that means it won’t get EWS results. Maybe the EWS could be changed to test out “review+” patches once it gets done with all the “review?” patches?
Is that practical?
-- Darin
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
-- Kenneth Rohde Christiansen Technical Lead / Senior Software Engineer Qt Labs Americas, Nokia Technology Institute, INdT Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org http://codeposts.blogspot.com ﹆﹆﹆
Eric and I have slowly been making progress on this problem. The underlying issue is that there does seem to be a bugzilla query for quite the right set of things (Eric knows the details here). To make this work, we're shifting the list of patches to analyze over to our AppEngine instance. So far, we've moved the commit-queue to this model, which lets us run three instances of the commit-queue in parallel, making it more of a "commit-cluster." Moving the EWS over to this model is probably one or two days more work. Hopefully that should be done sometime next week. Adam On Fri, Sep 24, 2010 at 10:25 AM, Darin Adler <darin@apple.com> wrote:
It’s not great that if I review a patch that means it won’t get EWS results. Maybe the EWS could be changed to test out “review+” patches once it gets done with all the “review?” patches?
Is that practical?
-- Darin
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
On Fri, Sep 24, 2010 at 10:59 AM, Adam Barth <abarth@webkit.org> wrote:
Eric and I have slowly been making progress on this problem. The underlying issue is that there does seem to be a bugzilla query for
*doesn't
quite the right set of things (Eric knows the details here). To make this work, we're shifting the list of patches to analyze over to our AppEngine instance. So far, we've moved the commit-queue to this model, which lets us run three instances of the commit-queue in parallel, making it more of a "commit-cluster."
Moving the EWS over to this model is probably one or two days more work. Hopefully that should be done sometime next week.
Adam
On Fri, Sep 24, 2010 at 10:25 AM, Darin Adler <darin@apple.com> wrote:
It’s not great that if I review a patch that means it won’t get EWS results. Maybe the EWS could be changed to test out “review+” patches once it gets done with all the “review?” patches?
Is that practical?
-- Darin
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
participants (3)
-
Adam Barth
-
Darin Adler
-
Kenneth Rohde Christiansen